From: Lee Jones <lee.jones@linaro.org>
To: 'Wei Yongjun <weiyongjun1@huawei.com>
Cc: Lubomir Rintel <lkundrak@v3.sk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static
Date: Wed, 10 Mar 2021 09:05:59 +0000 [thread overview]
Message-ID: <20210310090559.GI4931@dell> (raw)
In-Reply-To: <20210308123147.2340998-1-weiyongjun1@huawei.com>
On Mon, 08 Mar 2021, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/mfd/ene-kb3930.c:36:15: warning:
> symbol 'kb3930_power_off' was not declared. Should it be static?
>
> This symbol is not used outside of ene-kb3930.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Lubomir Rintel <lkundrak@v3.sk>
This should have been a Reviewed-by.
> ---
> drivers/mfd/ene-kb3930.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-03-10 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 12:31 [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static 'Wei Yongjun
2021-03-10 9:05 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310090559.GI4931@dell \
--to=lee.jones@linaro.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.