From: Christoph Hellwig <hch@lst.de>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Ian Campbell <ijc@hellion.org.uk>,
Jaya Kumar <jayakumar.lkml@gmail.com>,
Jani Nikula <jani.nikula@intel.com>,
Christoph Hellwig <hch@lst.de>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fb_defio: Remove custom address_space_operations
Date: Wed, 10 Mar 2021 17:54:47 +0100 [thread overview]
Message-ID: <20210310165447.GA18299@lst.de> (raw)
In-Reply-To: <20210310135128.846868-1-willy@infradead.org>
On Wed, Mar 10, 2021 at 01:51:28PM +0000, Matthew Wilcox (Oracle) wrote:
> There's no need to give the page an address_space. Leaving the
> page->mapping as NULL will cause the VM to handle set_page_dirty()
> the same way that it's set now, and that was the only reason to
> set the address_space in the first place.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-03-10 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 13:51 [PATCH] fb_defio: Remove custom address_space_operations Matthew Wilcox (Oracle)
2021-03-10 13:51 ` Matthew Wilcox (Oracle)
2021-03-10 16:54 ` Christoph Hellwig [this message]
2021-03-10 18:38 ` William Kucharski
2021-03-10 18:38 ` William Kucharski
2021-03-10 18:49 ` Matthew Wilcox
2021-03-10 18:49 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310165447.GA18299@lst.de \
--to=hch@lst.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=ijc@hellion.org.uk \
--cc=jani.nikula@intel.com \
--cc=jayakumar.lkml@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.