From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lKEJt-0004ID-Cn for mharc-grub-devel@gnu.org; Thu, 11 Mar 2021 00:57:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKEJr-0004I3-LT for grub-devel@gnu.org; Thu, 11 Mar 2021 00:57:11 -0500 Received: from de-smtp-delivery-102.mimecast.com ([62.140.7.102]:22554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKEJp-0007sS-7f for grub-devel@gnu.org; Thu, 11 Mar 2021 00:57:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1615442225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gz86ECDkX62WqW2Dc+/KGbhfFhtotahEuMsIdlz8TG0=; b=iKm2MXhldaD/u7lfIwAX03EdzYbfI8noXzFyLiHtp6feeGx32llRfF5QXQpvbfG5foI6RA U3Lx7V7qp8E/H8FMeNatCUeihFlY78TGa5zE0fAf4vyNmriPTE0zzejW4nCKY1hmYH4Rs4 4AyAwcOTikgxzP3cf6VmxOFIsv8RyKI= Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2104.outbound.protection.outlook.com [104.47.18.104]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-22-Kvhhq0BJMPGJAGCM_IiyXg-1; Thu, 11 Mar 2021 06:57:03 +0100 X-MC-Unique: Kvhhq0BJMPGJAGCM_IiyXg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J3n8JLSfEXOlo5dUe+2NpSM0QNU+YYjL3OUvDGpYIcY3WY1kzx6N5iY73Y355y8Fapm6z3BBPYytONab29W94gkIrZnfvU/AuxT7hnz/GeWAbIiPpCyyzPVkc8XKsIWgxo4vO2dT0a6CJwz0kmQPNi7aHdqeEBc0EW2dZzro3ke3pUlNE0yyWp6mvtCNldoc9XtYxP8qlizvFUbdmBejMVo2osKTPwK9YyFEHq0EdbtZPlecRQCcjFBxFoimsPe3i1xQFRjzO0lpDQzMmffdBuEr0RmDLWup68Rec4EYRe8Aq94tNWLP7OohBaRsGhf8YEt6oIXQrsI/bxG9G+kvvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gz86ECDkX62WqW2Dc+/KGbhfFhtotahEuMsIdlz8TG0=; b=drOoxOwpSrr2bQnuBvS11i5wA27d5b7XAJwEFFOvRDGJ/gcnfMjeBI4UMab8tuvbGrOSpx5mn30AuouBB5wbWGEQKI/9Ajt4Wwfl5GmNVBHpBjfVrc1GMJ5Zk699hOccXVGX+wlabBAMahl5EfrD73SHzS7PRSkjDwb3rIyRDRYwHkZPe/qOljaEtOfXdr12ekJe3qFyMA6jzpMZYvC57QeebvhS3V58/1p2qNZU0m6DwHrKugWtJflqljjYZp/4W5EfxUbJOfxKCvDBITUx53DWxjjAPV657IfovZdDU4S/IzR9CP5Bp3M6VYzQACAiq7iROtT716+UJCGS3U0GAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: net-space.pl; dkim=none (message not signed) header.d=none;net-space.pl; dmarc=none action=none header.from=suse.com; Received: from VI1PR04MB4991.eurprd04.prod.outlook.com (2603:10a6:803:57::28) by VE1PR04MB7359.eurprd04.prod.outlook.com (2603:10a6:800:1a0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Thu, 11 Mar 2021 05:57:02 +0000 Received: from VI1PR04MB4991.eurprd04.prod.outlook.com ([fe80::28b7:e423:c3d7:7ccf]) by VI1PR04MB4991.eurprd04.prod.outlook.com ([fe80::28b7:e423:c3d7:7ccf%6]) with mapi id 15.20.3912.028; Thu, 11 Mar 2021 05:57:02 +0000 Date: Thu, 11 Mar 2021 13:56:52 +0800 From: Michael Chang To: Daniel Kiper Cc: grub-devel@gnu.org, dimitri.ledkov@canonical.com, javierm@redhat.com, thomas.frauendorfer@gmail.com Subject: Re: IS: 2.06-rc1 cut... WAS: Re: [PATCH v2] Add chainloaded image as shim's verifiable object Message-ID: <20210311055652.GA622@mercury> References: <20210305134853.32586-1-mchang@suse.com> <20210309161822.bokjfdo6jjilqxfx@tomti.i.net-space.pl> <20210310035647.GA6796@mercury> <20210310160631.quwlvne2b2wkcadr@tomti.i.net-space.pl> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210310160631.quwlvne2b2wkcadr@tomti.i.net-space.pl> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [2001:b011:30d0:19a2:5231:f6e2:a0cb:7586] X-ClientProxiedBy: HK2PR06CA0018.apcprd06.prod.outlook.com (2603:1096:202:2e::30) To VI1PR04MB4991.eurprd04.prod.outlook.com (2603:10a6:803:57::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mercury (2001:b011:30d0:19a2:5231:f6e2:a0cb:7586) by HK2PR06CA0018.apcprd06.prod.outlook.com (2603:1096:202:2e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Thu, 11 Mar 2021 05:57:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 078e03d1-2e10-4939-febf-08d8e4527dbb X-MS-TrafficTypeDiagnostic: VE1PR04MB7359: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rOwd4uB5wLbykAtUW8gQc/vNUQ+I+KIfD1/0VxRM8urD+KErZSbxO+gGaytYiNiHaDsUMSFC/iYkdkzVemFaSTQDMz3OsiaO+Z9v1xKTLRRqd49iQvPTY+prorHNqihPTcV6ysvGwlOv9fKFa+ZmOEjrs1vdFShERK3XVqjvnOQI14NLbTcMfAjEVIdD/wtREMKZi6/mwHfQRY3fvt00buenXRr6cn6KWXUV/qN9hwkF39aIO1ccvD980eIcEAZstn97KXBItAkwCXazeukf19LG2L7pW1V/pBAUmtmq2V867qKvMdzUbOaSjrUetX3xM1QEtmdCCmxI1s9sF4Wm80WLkcDs5mnW3HwqochZcp9MDIGzy5kljaLM/vdi7wlD0DU2/N+Rz4s7dXsa+SjYp53+D4tj2kS9NZbAkeMskmRH46HfXxRhXnQPEtJHlV/DODPKw4Rh4nyU5SdcG3ronfo+Q4ZzkcyMUxxxjgoTf1tocLM1Dygg4jpJiTrrv7Xr5/XNwe3L4zpMljdjH6gdtQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB4991.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39860400002)(346002)(136003)(396003)(366004)(4326008)(2906002)(316002)(33656002)(86362001)(55016002)(9686003)(6916009)(6496006)(1076003)(8936002)(9576002)(6666004)(8676002)(5660300002)(186003)(16526019)(33716001)(52116002)(83380400001)(478600001)(45080400002)(66556008)(66946007)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?MeD7MfhyJZmvJ5BYsFrFjUGTLFYzE/zmTl5do+dPS4VYYAkgICVjSdOcpDxi?= =?us-ascii?Q?TvnvKlnfvux606IpGVh7jfCCXqQCJQQt/PFu2eyYqG3XN0HoDbv6CbMvBQgI?= =?us-ascii?Q?HhcCAPtGPGjZaKDcrX7f8+GQodS3woRVy9LrBYzWb9WI3JOitRsPippSMhGf?= =?us-ascii?Q?hx//oX4xsE3cW+Oz+fSnbUsf2TMsEFnFmOtAhRyljO4xFQOBKuhdyeh9Tv70?= =?us-ascii?Q?job63jZRAVfVJaYB7a6zTVQTD/bdSdaXftTOVa0v7ndHZ4Nk97EGT0z8p1Gs?= =?us-ascii?Q?02F9yyVgerrOuQX3MgclfLGY1Ps4whPFTPGGtIIWeXCrsg4+9ihjKfEfrjAk?= =?us-ascii?Q?j2qTGjVzzTQ1BfFJIAxgR7DT56XT5p6wgHage7Ty4zQY92+57O6zVRUri0Y6?= =?us-ascii?Q?veC72XF/FjaUkRgWuReEXmkspXvx5v1+ByHi7DswFOw9VvYXYr1Ss78sqYSD?= =?us-ascii?Q?q/Kv8Y8eJkz9CnXKh1zamcdW66UEG6rfTgL8EYyiy8qf5crPUjoJC4tO25N8?= =?us-ascii?Q?OzR0WJCDl3HTpOVuGKNeF1cIAzOeUztp0jVfjmRJI7z2biv3wtKdYOZnf4lL?= =?us-ascii?Q?BGI1vYtcva6GguFxMYOSDufZORQAWuzJ+qHC8OhC5/C0E28EntS7QuPFGXwV?= =?us-ascii?Q?dfSZC647UQefL3jPxEvIbM3SPHOfK9CTT6HFmOn7F/G3ZMLxsW0kTBQ/t+Tp?= =?us-ascii?Q?6Q0gzbZm/jj4MWFw52lOv5Y1V34wA5yuUCkG+DBikLrq5WpYp0X4KQCwOsm4?= =?us-ascii?Q?pQlUvGyPeVmGyTYoT6fqtW1DueAWq2U84dTtYISATP/KYBjuSNiZGjKx9UId?= =?us-ascii?Q?ep/nwrPHM/mNLbULKd5mA2VHNR/IFkDK2TOZfKtNwgOkr4MvoGA1ovUaipHE?= =?us-ascii?Q?QSQuAKEswI9P8tU9pXi2Q2thVCiNsA/27pN8fNROzHk55XbVVFmzIE87rvKL?= =?us-ascii?Q?vQC7ZF9+HnahhlDwzIseBV8inN+7b9bDvUDtMT0l3qj1WJQmsSheeWWyIw5F?= =?us-ascii?Q?UiQGfX7tFK6RT99yisCHW9zJweaQDo1T8iYea8NPj3RF/tnCZ9tE3nWG2zD3?= =?us-ascii?Q?QRGEmkrQthOPvcl3sKbHo2jRiRmxwFbGbsMn802Qh/ec3uS/JXZEDZGoPfQA?= =?us-ascii?Q?FPFpD+6UVPwZY0mDhVctPD0ggkjGoJo4aVvuiKfnnZGrhQwDGduvX8O3g0LB?= =?us-ascii?Q?XJrOpfch6CmygW2NmjmRvN6EDUV6mqPIMx3m8vqN7NFtz7/6b1s0dx1Uzbu8?= =?us-ascii?Q?neJ/mEX3S28X2q5YkPY42i+9gBgprexREV+vnkwZMa/5jWG7d5YO626BIotB?= =?us-ascii?Q?gC2BAJU7atzYenrOgqQ/ob8SS5fuAI7dGY1hRX1+r3rhDMw8Fa9xD1RlkfTa?= =?us-ascii?Q?d3/waeMegoShl6Z7kHXdoWDe3V09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 078e03d1-2e10-4939-febf-08d8e4527dbb X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4991.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 05:57:02.2188 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SPVXMop65H3N9/a/Ha6DrR3Z9TqJrlddiVucdMeq1pAYtJqvYJvIc8QWQnpdIAHn X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7359 Received-SPF: pass client-ip=62.140.7.102; envelope-from=mchang@suse.com; helo=de-smtp-delivery-102.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2021 05:57:11 -0000 On Wed, Mar 10, 2021 at 05:06:31PM +0100, Daniel Kiper wrote: > On Wed, Mar 10, 2021 at 11:56:47AM +0800, Michael Chang via Grub-devel wrote: > > On Tue, Mar 09, 2021 at 05:18:22PM +0100, Daniel Kiper wrote: > > > On Fri, Mar 05, 2021 at 09:48:53PM +0800, Michael Chang via Grub-devel wrote: > > > > While attempting to dual boot Microsoft Windows with efi chainloader, it > > > > failed with below error when secure boot was enabled. > > > > > > > > error ../../grub-core/kern/verifiers.c:119:verification requested but > > > > nobody cares: /EFI/Microsoft/Boot/bootmgfw.efi. > > > > > > > > It is a regression, as previously it worked without problem. > > > > > > > > It turns out chainloading image has been locked down introduced by > > > > > > > > 578c95298 kern: Add lockdown support > > > > > > > > However we should consider it as verifiable object to shim to allow > > > > booting in secure boot enabled mode. The chainloaded image could also > > > > have trusted signature signed by vendor with their pubkey cert in db. > > > > For that matters it's usage should not be locked down in secure boot, > > > > and instead use shim to validate it's signature before running it. > > > > > > > > V2: > > > > Keep GRUB_FILE_TYPE_EFI_CHAINLOADED_IMAGE in the lockdown list as it > > > > ensures at least one verifer has validated the image. > > > > > > > > Signed-off-by: Michael Chang > > > > > > Reviewed-by: Daniel Kiper > > > > May I ask if the patch is planned or going to be merged to the master > > hence available in the 2.06-rc1 cut ? > > I have just pushed it together with other fixes and cleanups from the > grub-devel. If you can see something important missing drop me a line > immediately. Now I am working on 2.06-rc1 cut. If nothing blows up expect > it tomorrow or on Friday... Many thanks to picking up the patch. Tested the efi chainloader now could successfully load and start the signed uefi binary, meanwhile reject the one with invalid signature in secure boot enabled mode. This function is restored. Thanks, Michael > > Daniel >