From: Johan Hovold <johan@kernel.org>
To: linux-usb@vger.kernel.org
Cc: "Michael G. Katzmann" <michaelk@IEEE.org>,
"Charles Yeh" <charlesyeh522@gmail.com>,
"Yeh.Charles [葉榮鑫]" <charles-yeh@prolific.com.tw>,
"Johan Hovold" <johan@kernel.org>
Subject: [PATCH 3/5] USB: serial: pl2303: rename legacy PL2303H type
Date: Thu, 11 Mar 2021 17:14:49 +0100 [thread overview]
Message-ID: <20210311161451.1496-4-johan@kernel.org> (raw)
In-Reply-To: <20210311161451.1496-1-johan@kernel.org>
Rename the legacy type which is supposedly a PL2303H which came in two
variants (and which we handle the same way).
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/pl2303.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 42dcc3cfb449..cd2acd8c5246 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -173,7 +173,7 @@ MODULE_DEVICE_TABLE(usb, id_table);
static void pl2303_set_break(struct usb_serial_port *port, bool enable);
enum pl2303_type {
- TYPE_01, /* Type 0 and 1 (difference unknown) */
+ TYPE_H,
TYPE_HX,
TYPE_TA,
TYPE_TB,
@@ -203,7 +203,7 @@ struct pl2303_private {
};
static const struct pl2303_type_data pl2303_type_data[TYPE_COUNT] = {
- [TYPE_01] = {
+ [TYPE_H] = {
.max_baud_rate = 1228800,
.quirks = PL2303_QUIRK_LEGACY,
.no_autoxonxoff = true,
@@ -382,16 +382,16 @@ static int pl2303_detect_type(struct usb_serial *serial)
u8 buf;
/*
- * Legacy types 0 and 1, difference unknown.
+ * Legacy PL2303H, variants 0 and 1 (difference unknown).
*/
if (desc->bDeviceClass == 0x02)
- return TYPE_01; /* type 0 */
+ return TYPE_H; /* variant 0 */
if (desc->bMaxPacketSize0 != 0x40) {
if (desc->bDeviceClass == 0x00 || desc->bDeviceClass == 0xff)
- return TYPE_01; /* type 1 */
+ return TYPE_H; /* variant 1 */
- return TYPE_01; /* type 0 */
+ return TYPE_H; /* variant 0 */
}
/*
--
2.26.2
next prev parent reply other threads:[~2021-03-11 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 16:14 [PATCH 0/5] USB: serial: pl2303: amend device-type detection Johan Hovold
2021-03-11 16:14 ` [PATCH 1/5] USB: serial: pl2303: clean up type detection Johan Hovold
2021-03-11 16:14 ` [PATCH 2/5] USB: serial: pl2303: amend and tighten " Johan Hovold
2021-03-11 16:14 ` Johan Hovold [this message]
2021-03-11 16:14 ` [PATCH 4/5] USB: serial: pl2303: tighten type HXN (G) detection Johan Hovold
2021-03-11 16:14 ` [PATCH 5/5] USB: serial: pl2303: add device-type names Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311161451.1496-4-johan@kernel.org \
--to=johan@kernel.org \
--cc=charles-yeh@prolific.com.tw \
--cc=charlesyeh522@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=michaelk@IEEE.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.