From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94AF8C433DB for ; Fri, 12 Mar 2021 15:18:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3041B64DBA for ; Fri, 12 Mar 2021 15:18:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3041B64DBA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/xht/0gDXuR/9kLVV4XbQ9a44M/D+9/8mtjMt51rDkM=; b=ji+8pF9yfdrCpTSVcM8P9zBCD AyLkgrgWQxWbqaYvHLGrJ7f8Zk3bLox6TwLg2/cn28Cat7XTSJC9PnASRfMdxwIdwegz+tVSklVK3 g0506K3ddhjRcvVndxzifSYYMzXbA16CHkzXm7rTUlt9gwFXi4lb5f7ihc/CZ6ScQm7jy4tmsYDnt KUFw+QNiXSKoDbR/3jVDbeVGKgRuVUVa5bTsJI6KoAR2LI+uSC6XP/RClIbNvqTTlQm41OxWZkQHQ 7p/Rr/PKVZZ3L6SesBwbhhjJ3aJZ9D7d/O+ND10wN55yhkK9Ge1aBTf+RZ6MQ9Jk5xTdsh8HCdB7q INCHv+aqg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKjXP-00Bl3w-E8; Fri, 12 Mar 2021 15:17:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKjXJ-00Bl3G-Ec for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 15:17:11 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E727464FCE; Fri, 12 Mar 2021 15:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615562228; bh=teWZH5IRebQbacXOyacm0Vpj0YMmVKRVQuQG4BAku70=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DdG006f34lXoAhj+kle8myJouN4B/Mp6GIsf5SWMRHQAijeAH8qQ1ZQAZKaToEReO 5zz9sIIf+bX/KL7865OEL1LBZB+xhPvOPVTMXC9a7p1V47iL9/DUK9m/KFhBrKqocl AvofOOZTmW0EyUQnPy0owuvfSXD124VGbV7sI2IQEqCRZ55ItVAX/3CmRrzrvJ7YsL snALUtWJSO2c3V5QRnPI0O1lBWRXPMKmF4Ml/Lt5rdtBmzfWKafy5pDWuK3VRHggr0 PMAyfP0VWM2DI7YuabDq9QAwvroqq8VVsU+g6nBYVsZNV4OdaK3eHZ2qHmEVlr0YbM FFEWbfANhqj6w== Date: Fri, 12 Mar 2021 16:17:04 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Andrew Lunn Cc: Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, pali@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: <20210312161704.5e575906@kernel.org> In-Reply-To: References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> <87czw4kath.fsf@BL-laptop> <20210312101027.1997ec75@kernel.org> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_151710_010787_EEF300D9 X-CRM114-Status: GOOD ( 34.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxMiBNYXIgMjAyMSAxNTo0ODoxNCArMDEwMApBbmRyZXcgTHVubiA8YW5kcmV3QGx1 bm4uY2g+IHdyb3RlOgoKPiBPbiBGcmksIE1hciAxMiwgMjAyMSBhdCAxMDoxMDoyN0FNICswMTAw LCBNYXJlayBCZWjDum4gd3JvdGU6Cj4gPiBPbiBGcmksIDEyIE1hciAyMDIxIDA5OjU4OjM0ICsw MTAwCj4gPiBHcmVnb3J5IENMRU1FTlQgPGdyZWdvcnkuY2xlbWVudEBib290bGluLmNvbT4gd3Jv dGU6Cj4gPiAgIAo+ID4gPiBIZWxsbyBNYXJlaywKPiA+ID4gICAKPiA+ID4gPiBGcm9tOiBQYWxp IFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPgo+ID4gPiA+Cj4gPiA+ID4gTW92ZSB0aGUgdHVycmlz LW1veC1yd3RtIGZpcm13YXJlIG5vZGUgZnJvbSBUdXJyaXMgTU9YJyBkZXZpY2UgdHJlZSBpbnRv Cj4gPiA+ID4gdGhlIGdlbmVyaWMgYXJtYWRhLTM3eHguZHRzaSBmaWxlLiAgICAKPiA+ID4gCj4g PiA+IEkgZGlzYWdyZWUgd2l0aCB0aGlzIHBhdGNoLiBUaGlzIGZpcm13YXJlIGlzIHNwZWNpZmlj IHRvIFR1cnJpcyBNT1ggc28KPiA+ID4gaXQgaXMgbm90IHNvbWV0aGluZyB0aGF0IHNob3VsZCBi ZSBleHBvc2VkIHRvIGFsbCB0aGUgQXJtYWRhIDM3MDAgYmFzZWQKPiA+ID4gYm9hcmRzLgo+ID4g PiAKPiA+ID4gSWYgeW91IHdhbnQgeW91IHN0aWxsIGNhbiBjcmVhdGUgYW4gZHRzaSBmb3IgdGhp cyBhbmQgaW5jbHVkZSBpdCB3aGVuCj4gPiA+IG5lZWRlZC4KPiA+ID4gCj4gPiA+IEdyZWdvcnkg IAo+ID4gCj4gPiBHcmVnb3J5LCB3ZSBhcmUgcGxhbm5pbmcgdG8gc2VuZCBwdWxsLXJlcXVlc3Qg Zm9yIFRGLUEgZG9jdW1lbnRhdGlvbiwKPiA+IGFkZGluZyBpbmZvcm1hdGlvbiB0aGF0IHBlb3Bs ZSBjYW4gY29tcGlsZSB0aGUgZmlybXdhcmUgd2l0aCBDWi5OSUMncwo+ID4gZmlybXdhcmUuCj4g PiAKPiA+IFNpbmNlIHRoaXMgZmlybXdhcmUgZXhwb3NlcyBIVyByYW5kb20gbnVtYmVyIGdlbmVy YXRvciwgaXQgaXMKPiA+IHBvc3NpYmxlIHRoYXQgcGVvcGxlIHdpbGwgc3RhcnQgdXNpbmcgaXQg Zm9yIGVzcHJlc3NvYmluLgo+ID4gCj4gPiBJbiB0aGF0IGNhc2UgdGhpcyB3b24ndCBiZSBzcGVj aWZpYyBmb3IgVHVycmlzIE1PWCBhbnltb3JlLiAgCj4gCj4gUGFydCBvZiB0aGUgcHJvYmxlbSBp cyB0aGF0IGl0IGxvb2tzIHNwZWNpZmljIHRvIHRoZSBUdXJyaXMgTU9YLgo+IAo+IEJ1dCBwbGVh c2UgaGVscCBtZSB1bmRlcnN0YW5kIHRoZSBiaWcgcGljdHVyZSBmaXJzdC4gIEhvdyBpcyB0aGUK PiBmaXJtd2FyZSBkaXN0cmlidXRlZD8gSXMgdGhlIGJpbmFyeSBwYXJ0IG9mIGxpbnV4LWZpcm13 YXJlPyBIb3cgZG9lcwo+IGl0IGdldCBsb2FkZWQ/IERvZXMgdGhlIGZpcm13YXJlIGNvbnRhaW4g YW55dGhpbmcgd2hpY2ggaXMgc3BlY2lmaWMgdG8KPiB0aGUgVHVycmlzIE1PWD8gQ291bGQgdGhl IGhhcmR3YXJlIG51bWJlciBnZW5lcmF0b3IgcGFydCBiZSBzcGxpdCBvdXQKPiBpbnRvIGEgbW9y ZSBnZW5lcmljIHNvdW5kaW5nIG5hbWUgYmxvYj8KPiAKPiAgICAgIEFuZHJldwoKSGVsbG8gQW5k cmV3LAoKVGhlIFdUTUkgZmlybXdhcmUgaXMgbG9hZGVkIGJlZm9yZSBrZXJuZWwuIFRoaXMgZmly bXdhcmUgaXMgbG9hZGVkIGJ5CkJvb3RST00sIGFuZCBpdCBpcyB0aGlzIGZpcm13YXJlIHRoYXQg ZG9lcyBERFIgdHJhaW5pbmcgYmVmb3JlIGxvYWRpbmcKVEYtQSArIFUtQm9vdC4KCkZvciBleGFt cGxlIGZvciBFU1BSRVNTT2JpbiB5b3UgaGF2ZSBzZXZlcmFsIHJlcG9zaXRvcmllcyB5b3UgbmVl ZCB0bwpjcmVhdGUgYSBmaW5hbCBmbGFzaC1pbWFnZS5iaW4gY29udGFpbmluZyB0aGlzIFdUTUkg ZmlybXdhcmUgKyBURi1BICsKVS1Cb290LiBUaGVzZSByZXBvc2l0b3JpZXMgYXJlOgogIHRydXN0 ZWQtZmlybXdhcmUtYSAoY29udGFpbnMgZG9jdW1lbnRhdGlvbiBob3cgdG8gYnVpbGQgYWxsIHRo aXMpCiAgQTM3MDAtdXRpbHMtbWFydmVsbAogIHUtYm9vdAogIG12LWRkci1tYXJ2ZWxsCkZyb20g dGhlc2Ugc291cmNlcyB5b3UgYXJlIGFibGUgdG8gY3JlYXRlIGEgZmluYWwgZmxhc2gtaW1hZ2Uu YmluIHRoYXQKeW91IGNhbiBmbGFzaCBvbnRvIHRoZSBTUEktTk9SIChvciBlTU1DIG9yIG90aGVy IGRldmljZXMgd2hpY2ggQTM3MjAKY2FuIGJvb3QgZnJvbSkuCgpUaGUgQTM3MDAtdXRpbHMtbWFy dmVsbCByZXBvc2l0b3J5IGNvbnRhaW5zIHRoZSBjb2RlIG9mIHRoZSBXVE1JCmZpcm13YXJlLgoK T24gVHVycmlzIE1PWCB0aGlzIGlzIGEgbGl0dGxlIGJpdCBkaWZmZXJlbnQsIGJlY2F1c2UKLSB3 ZSBoYXZlIGltcGxlbWVudGVkIHRoZSBXVE1JIGZpcm13YXJlIGRpZmZlcmVudGx5IChtb3JlIG1h aWxib3gKICBjb21tYW5kcywgSFcgY3J5cHRvLCAuLi4pCi0gaXQgc3VwcG9ydHMgcmV0cmlldmlu ZyBNT1ggYm9hcmQgaW5mb3JtYXRpb24gKE1BQyBhZGRyZXNzZXMsIHNlcmlhbAogIG51bWJlcikg c3RvcmVkIGluIGVGdXNlcyAodGhpcyBpbmZvcm1hdGlvbiBpcyBzdG9yZWQgaW4gYSBzcGVjaWZp YwogIHdheSB0aGF0IGluIG9ubHkgdHJ1ZSBmb3IgTU9YKQotIHRoZSBmaXJtd2FyZSBiaW5hcnkg bXVzdCBiZSBzaWduZWQgYnkgb3VyIHByaXZhdGUga2V5IGluIG9yZGVyIHRvCiAgYm9vdCBvbiBN T1guCgogIFRoaXMgaXMgYmVjYXVzZSB0aGUgc2VjdXJlIGZpcm13YXJlIGhhcyBhY2Nlc3MgdG8g YW4gRUNEU0EgZW5naW5lCiAgd2l0aCBhIHByaXZhdGUga2V5IHN0b3JhZ2UgaW4gZUZ1c2VzIChl YWNoIE1PWCBoYXMgaXRzIG93biBwcml2YXRlCiAga2V5IGdlbmVyYXRlZCBhbmQgc3RvcmVkIGlu dG8gdGhlIGVGdXNlcyB3aGVuIG1hbnVmYWN0dXJlZCkKICBJbiBvcmRlciB0byBkaXNhbGxvdyBo YWNrZXJzIHRvIHNvbWVob3cgZXh0cmFjdCB0aGUgcHJpdmF0ZSBrZXksCiAgdGhlIGZpcm13YXJl IG11c3QgYmUgc2lnbmVkIHNvIHRoYXQgdGhleSBjYW5ub3QgbG9hZCBhcmJpdHJhcnkKICBmaXJt d2FyZSBpbnRvIHRoZSBzZWN1cmUgcHJvY2Vzc29yLgoKQlVUCi0gc2luY2UgdGhpcyBmaXJtd2Fy ZSBpcyBhYmxlIHRvIHByb3ZpZGUgSFdSTkcsIHdlIHdhbnRlZCB0byBtYWtlIGl0CiAgYXZhaWxh YmxlIGZvciBvdGhlciBBcm1hZGEgMzcyMCBib2FyZHMKLSB3ZSB1cGRhdGVkIHRoZSBjb2RlIHNv IHRoYXQgdXNlcnMgY2FuIGJ1aWxkIGl0IGZvciBub24tTU9YIGRldmljZXMKLSBpdCBkb2VzIG5v dCBoYXZlIHRvIGJlIHNpZ25lZCBmb3Igb3RoZXIgZGV2aWNlcwotIGl0IGRvZXMgbm90IGNvbnRh aW4gTU9YIHNwZWNpZmljIHN0dWZmIGZvciBub24tTU9YIGRldmljZXMKClNvIGN1cnJlbnRseSB3 aGVuIHVzZXJzIGJ1aWxkIHRoZSBmbGFzaC1pbWFnZS5iaW4gYmluYXJ5IGNvbnRhaW5pbmcKV1RN SSBmaXJtd2FyZSwgdGhleSBhcmUgdXNpbmcgY29kZSBmcm9tIEEzNzAwLXV0aWxzLW1hcnZlbGwu IFRoaXMgY29kZQppcyBzcGxpdCBpbnRvIDIgcGFydHM6Ci0gc3lzX2luaXQgLSBkb2VzIEhXIGFu ZCBERFIgaW5pdGlhbGl6YXRpb24gYW5kIGV4ZWN1dGlvbiBvZiBhbiAiYXBwIgotIGVmdXNlIC0g ZGVmYXVsdCAiYXBwIiB3aGljaCBpcyBsb2FkZWQgYnkgc3lzX2luaXQKVGhlIHdheSBpdCBpcyB3 cml0dGVuIGlzIHRoYXQgdXNlciBjYW4gc2VsZWN0IGEgZGlmZmVyZW50ICJhcHAiIHdoZW4KYnVp bGRpbmcsIGFuZCB3ZSBoYXZlIHVwZGF0ZWQgVHVycmlzIE1PWCBmaXJtd2FyZSBjb2RlIHRvIGJl IGxvYWRhYmxlCmFzIHRoaXMgImFwcCIgZm9yIHN5c19pbml0LiAoQW5kIHdlIGhhdmUgcmVuYW1l ZCBpdCBmcm9tICJUdXJyaXMgTU9YCnNlY3VyZSBmaXJtd2FyZSIgdG8gIkNaLk5JQydzIEFybWFk YSAzNzIwIHNlY3VyZSBmaXJtd2FyZSIpLgoKPiBDb3VsZCB0aGUgaGFyZHdhcmUgbnVtYmVyIGdl bmVyYXRvciBwYXJ0IGJlIHNwbGl0IG91dCBpbnRvIGEgbW9yZQo+IGdlbmVyaWMgc291bmRpbmcg bmFtZSBibG9iPwoKSXQgYmFzaWNhbGx5IGlzLiBBcyBJIGhhdmUgd3JpdHRlbiBhYm92ZSwgd2hl biB1c2VycyBidWlsZCB0aGUKZmxhc2gtaW1hZ2UuYmluIHdpdGggQ1ouTklDJ3MgZmlybXdhcmUs IHRoZSBwcm9tcHQgZG9lcyBub3Qgc2F5CmFueXRoaW5nIGFib3V0IFR1cnJpcyBNT1guIEluc3Rl YWQgaXQgc2F5cyBzb21ldGhpbmcgbGlrZQogIENaLk5JQydzIEFybWFkYSAzNzIwIFNlY3VyZSBG aXJtd2FyZSB2ZXJzaW9uIGJ1aWxkIGRhdGUKICBSdW5uaW5nIG9uIEVTUFJFU1NPYmluCmFuZCBj dXJyZW50bHkgcHJvdmlkZXMgb25seSB0aGUgcmFuZG9tIG51bWJlciBnZW5lcmF0b3IgY29tbWFu ZC4KClNvIHRoZW9yZXRpY2FsbHkgdGhlIHR1cnJpcy1tb3gtcnd0bSBkcml2ZXIgY2FuIGJlIHJl bmFtZWQgaW50bwpzb21ldGhpbmcgZWxzZSBhbmQgd2UgY2FuIGFkZCBhIGRpZmZlcmVudCBjb21w YXRpYmxlIGluIG9yZGVyIG5vdCB0bwpzb3VuZCBzbyB0dXJyaXMtbW94IHNwZWNpZmljLgoKTWFy ZWsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A88C433E9 for ; Fri, 12 Mar 2021 15:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 754CB64FE2 for ; Fri, 12 Mar 2021 15:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbhCLPRZ (ORCPT ); Fri, 12 Mar 2021 10:17:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:46778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230388AbhCLPRI (ORCPT ); Fri, 12 Mar 2021 10:17:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E727464FCE; Fri, 12 Mar 2021 15:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615562228; bh=teWZH5IRebQbacXOyacm0Vpj0YMmVKRVQuQG4BAku70=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DdG006f34lXoAhj+kle8myJouN4B/Mp6GIsf5SWMRHQAijeAH8qQ1ZQAZKaToEReO 5zz9sIIf+bX/KL7865OEL1LBZB+xhPvOPVTMXC9a7p1V47iL9/DUK9m/KFhBrKqocl AvofOOZTmW0EyUQnPy0owuvfSXD124VGbV7sI2IQEqCRZ55ItVAX/3CmRrzrvJ7YsL snALUtWJSO2c3V5QRnPI0O1lBWRXPMKmF4Ml/Lt5rdtBmzfWKafy5pDWuK3VRHggr0 PMAyfP0VWM2DI7YuabDq9QAwvroqq8VVsU+g6nBYVsZNV4OdaK3eHZ2qHmEVlr0YbM FFEWbfANhqj6w== Date: Fri, 12 Mar 2021 16:17:04 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Andrew Lunn Cc: Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, pali@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: <20210312161704.5e575906@kernel.org> In-Reply-To: References: <20210308153703.23097-1-kabel@kernel.org> <20210308153703.23097-4-kabel@kernel.org> <87czw4kath.fsf@BL-laptop> <20210312101027.1997ec75@kernel.org> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, 12 Mar 2021 15:48:14 +0100 Andrew Lunn wrote: > On Fri, Mar 12, 2021 at 10:10:27AM +0100, Marek Beh=C3=BAn wrote: > > On Fri, 12 Mar 2021 09:58:34 +0100 > > Gregory CLEMENT wrote: > > =20 > > > Hello Marek, > > > =20 > > > > From: Pali Roh=C3=A1r > > > > > > > > Move the turris-mox-rwtm firmware node from Turris MOX' device tree= into > > > > the generic armada-37xx.dtsi file. =20 > > >=20 > > > I disagree with this patch. This firmware is specific to Turris MOX so > > > it is not something that should be exposed to all the Armada 3700 bas= ed > > > boards. > > >=20 > > > If you want you still can create an dtsi for this and include it when > > > needed. > > >=20 > > > Gregory =20 > >=20 > > Gregory, we are planning to send pull-request for TF-A documentation, > > adding information that people can compile the firmware with CZ.NIC's > > firmware. > >=20 > > Since this firmware exposes HW random number generator, it is > > possible that people will start using it for espressobin. > >=20 > > In that case this won't be specific for Turris MOX anymore. =20 >=20 > Part of the problem is that it looks specific to the Turris MOX. >=20 > But please help me understand the big picture first. How is the > firmware distributed? Is the binary part of linux-firmware? How does > it get loaded? Does the firmware contain anything which is specific to > the Turris MOX? Could the hardware number generator part be split out > into a more generic sounding name blob? >=20 > Andrew Hello Andrew, The WTMI firmware is loaded before kernel. This firmware is loaded by BootROM, and it is this firmware that does DDR training before loading TF-A + U-Boot. For example for ESPRESSObin you have several repositories you need to create a final flash-image.bin containing this WTMI firmware + TF-A + U-Boot. These repositories are: trusted-firmware-a (contains documentation how to build all this) A3700-utils-marvell u-boot mv-ddr-marvell =46rom these sources you are able to create a final flash-image.bin that you can flash onto the SPI-NOR (or eMMC or other devices which A3720 can boot from). The A3700-utils-marvell repository contains the code of the WTMI firmware. On Turris MOX this is a little bit different, because - we have implemented the WTMI firmware differently (more mailbox commands, HW crypto, ...) - it supports retrieving MOX board information (MAC addresses, serial number) stored in eFuses (this information is stored in a specific way that in only true for MOX) - the firmware binary must be signed by our private key in order to boot on MOX. This is because the secure firmware has access to an ECDSA engine with a private key storage in eFuses (each MOX has its own private key generated and stored into the eFuses when manufactured) In order to disallow hackers to somehow extract the private key, the firmware must be signed so that they cannot load arbitrary firmware into the secure processor. BUT - since this firmware is able to provide HWRNG, we wanted to make it available for other Armada 3720 boards - we updated the code so that users can build it for non-MOX devices - it does not have to be signed for other devices - it does not contain MOX specific stuff for non-MOX devices So currently when users build the flash-image.bin binary containing WTMI firmware, they are using code from A3700-utils-marvell. This code is split into 2 parts: - sys_init - does HW and DDR initialization and execution of an "app" - efuse - default "app" which is loaded by sys_init The way it is written is that user can select a different "app" when building, and we have updated Turris MOX firmware code to be loadable as this "app" for sys_init. (And we have renamed it from "Turris MOX secure firmware" to "CZ.NIC's Armada 3720 secure firmware"). > Could the hardware number generator part be split out into a more > generic sounding name blob? It basically is. As I have written above, when users build the flash-image.bin with CZ.NIC's firmware, the prompt does not say anything about Turris MOX. Instead it says something like CZ.NIC's Armada 3720 Secure Firmware version build date Running on ESPRESSObin and currently provides only the random number generator command. So theoretically the turris-mox-rwtm driver can be renamed into something else and we can add a different compatible in order not to sound so turris-mox specific. Marek