All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/bash: fix seventh patch
Date: Fri, 12 Mar 2021 19:16:08 +0100	[thread overview]
Message-ID: <20210312191608.3beff368@gmx.net> (raw)
In-Reply-To: <20210312070803.768698-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Fri, 12 Mar 2021 08:08:03 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Since bump to version 5.1 in commit
> 9e778b044c949d165207150cc9e79fdcfbafcb9d, seventh patch wrongly defines
> wcdequote_pathname as static which will result in the following build
> failure:
>
> smatch.c:(.text+0x22f0): undefined reference to `wcdequote_pathname'
>
> Fixes:
>  - http://autobuild.buildroot.org/results/d83f5d260dccd38984ec6fdb340835ca928bb687
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Thanks for taking care of the failure and fixing it...

Tested-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter

> ---
>  ...-glob-fix-dequote_pathname-vs.-udequote_pathname.patch | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/package/bash/0007-glob-fix-dequote_pathname-vs.-udequote_pathname.patch b/package/bash/0007-glob-fix-dequote_pathname-vs.-udequote_pathname.patch
> index b769dc296e..a801f68236 100644
> --- a/package/bash/0007-glob-fix-dequote_pathname-vs.-udequote_pathname.patch
> +++ b/package/bash/0007-glob-fix-dequote_pathname-vs.-udequote_pathname.patch
> @@ -27,13 +27,7 @@ diff --git a/lib/glob/glob.c b/lib/glob/glob.c
>  index eb6277f..c903b15 100644
>  --- a/lib/glob/glob.c
>  +++ b/lib/glob/glob.c
> -@@ -117,12 +117,11 @@ static int mbskipname PARAMS((char *, char *, int));
> - #endif
> - void udequote_pathname PARAMS((char *));
> - #if HANDLE_MULTIBYTE
> --void wcdequote_pathname PARAMS((wchar_t *));
> -+static void wcdequote_pathname PARAMS((wchar_t *));
> - static void wdequote_pathname PARAMS((char *));
> +@@ -117,6 +117,5 @@ static int mbskipname PARAMS((char *, char *, int));
>   #else
>   #  define dequote_pathname udequote_pathname
>   #endif

  reply	other threads:[~2021-03-12 18:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  7:08 [Buildroot] [PATCH 1/1] package/bash: fix seventh patch Fabrice Fontaine
2021-03-12 18:16 ` Peter Seiderer [this message]
2021-03-12 19:51 ` Ryan Barnett
2021-03-12 21:02 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312191608.3beff368@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.