From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v1 1/1] iio: imu: fxos8700: Drop unneeded explicit castings
Date: Sat, 13 Mar 2021 15:10:14 +0000 [thread overview]
Message-ID: <20210313151014.071bccd0@archlinux> (raw)
In-Reply-To: <20210312134538.3759-1-andriy.shevchenko@linux.intel.com>
On Fri, 12 Mar 2021 15:45:38 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> In a few places the unnecessary explicit castings are being used.
> Drop them for good.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied, Thanks
> ---
> drivers/iio/imu/fxos8700_i2c.c | 3 +--
> drivers/iio/imu/fxos8700_spi.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/fxos8700_i2c.c b/drivers/iio/imu/fxos8700_i2c.c
> index 3ceb76366313..40a570325b0a 100644
> --- a/drivers/iio/imu/fxos8700_i2c.c
> +++ b/drivers/iio/imu/fxos8700_i2c.c
> @@ -26,8 +26,7 @@ static int fxos8700_i2c_probe(struct i2c_client *client,
>
> regmap = devm_regmap_init_i2c(client, &fxos8700_regmap_config);
> if (IS_ERR(regmap)) {
> - dev_err(&client->dev, "Failed to register i2c regmap %d\n",
> - (int)PTR_ERR(regmap));
> + dev_err(&client->dev, "Failed to register i2c regmap %ld\n", PTR_ERR(regmap));
> return PTR_ERR(regmap);
> }
>
> diff --git a/drivers/iio/imu/fxos8700_spi.c b/drivers/iio/imu/fxos8700_spi.c
> index 57e7bb6444e7..27e694cce173 100644
> --- a/drivers/iio/imu/fxos8700_spi.c
> +++ b/drivers/iio/imu/fxos8700_spi.c
> @@ -17,8 +17,7 @@ static int fxos8700_spi_probe(struct spi_device *spi)
>
> regmap = devm_regmap_init_spi(spi, &fxos8700_regmap_config);
> if (IS_ERR(regmap)) {
> - dev_err(&spi->dev, "Failed to register spi regmap %d\n",
> - (int)PTR_ERR(regmap));
> + dev_err(&spi->dev, "Failed to register spi regmap %ld\n", PTR_ERR(regmap));
> return PTR_ERR(regmap);
> }
>
prev parent reply other threads:[~2021-03-13 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 13:45 [PATCH v1 1/1] iio: imu: fxos8700: Drop unneeded explicit castings Andy Shevchenko
2021-03-13 15:10 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210313151014.071bccd0@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.