From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
brouer@redhat.com
Subject: Re: [PATCH v3 net-next 0/2] pktgen: scripts improvements
Date: Mon, 15 Mar 2021 09:45:30 +0100 [thread overview]
Message-ID: <20210315094530.6a77018f@carbon> (raw)
In-Reply-To: <20210311103253.14676-1-irusskikh@marvell.com>
On Thu, 11 Mar 2021 11:32:51 +0100
Igor Russkikh <irusskikh@marvell.com> wrote:
> Hello netdev community,
>
> Please consider small improvements to pktgen scripts we use in our environment.
>
> Adding delay parameter through command line,
> Adding new -a (append) parameter to make flex runs
>
> v3: change us to ns in docs
> v2: Review comments from Jesper
>
> CC: Jesper Dangaard Brouer <brouer@redhat.com>
Did a quick review and everything looks okay.
The patches are already applied, but you will still get my ACK,
even-though it will not make it to the commit log.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Igor Russkikh (2):
> samples: pktgen: allow to specify delay parameter via new opt
> samples: pktgen: new append mode
>
> samples/pktgen/README.rst | 18 +++++++++++
> samples/pktgen/functions.sh | 7 ++++-
> samples/pktgen/parameters.sh | 15 ++++++++-
> .../pktgen_bench_xmit_mode_netif_receive.sh | 3 --
> .../pktgen_bench_xmit_mode_queue_xmit.sh | 3 --
> samples/pktgen/pktgen_sample01_simple.sh | 25 ++++++++-------
> samples/pktgen/pktgen_sample02_multiqueue.sh | 29 +++++++++--------
> .../pktgen_sample03_burst_single_flow.sh | 15 ++++-----
> samples/pktgen/pktgen_sample04_many_flows.sh | 17 +++++-----
> .../pktgen/pktgen_sample05_flow_per_thread.sh | 17 +++++-----
> ...sample06_numa_awared_queue_irq_affinity.sh | 31 ++++++++++---------
> 11 files changed, 110 insertions(+), 70 deletions(-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2021-03-15 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:32 [PATCH v3 net-next 0/2] pktgen: scripts improvements Igor Russkikh
2021-03-11 10:32 ` [PATCH v3 net-next 1/2] samples: pktgen: allow to specify delay parameter via new opt Igor Russkikh
2021-03-11 10:32 ` [PATCH v3 net-next 2/2] samples: pktgen: new append mode Igor Russkikh
2021-03-14 21:30 ` [PATCH v3 net-next 0/2] pktgen: scripts improvements patchwork-bot+netdevbpf
2021-03-15 8:45 ` Jesper Dangaard Brouer [this message]
2021-03-15 11:55 ` [EXT] " Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315094530.6a77018f@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.