Re: Linux 5.11: i2c: Confusing error message

[Wolfram Sang <wsa@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

Hello Klaus,

On Mon, Mar 15, 2021 at 07:58:21AM +0100, Klaus Kudielka wrote:

Thanks for the report! I am CCing the I2C list, please add it next time,
too.

> Hello,
> 
> I recently upgraded my Turris Omnia (Marvell Armada 385) to 5.11, and now
> get the following error message during boot:
> 
>     i2c i2c-0: Not using recovery: no recover_bus() found
> 
> As far as I understand the situation:
> 
>  * After commit 9c7cae2427715502227f823364a6a77828fdf3ea mv64xxx-i2c
>    unconditionally sets bus_recovery_info and bus_recovery_info->pinctrl
>  * The i2c bus node in the turris-omnia DTS does *not* have a pinctrl
>    state "gpio" or "recovery" (like any other Marvell Armada board, AFAICS)
>  * i2c_gpio_init_recovery() throws a debug message "no gpio or recovery
>    state found for GPIO recovery", which (under normal circumstances)
>    users won't see
>  * After i2c_gpio_init_recovery() returns, i2c_init_recovery() throws
>    above-mentioned error message
> 
> Is this the intended behaviour?
> Personally, I believe an "error" message is quite strong for this common
> scenario, and a bit misleading.

You are right. The case that a pinctrl is provided but not the necessary
states for recovery has been overlooked so far.

I will think of something right now.

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]