From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F1BC433E0 for ; Mon, 15 Mar 2021 11:17:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8BA164E10 for ; Mon, 15 Mar 2021 11:17:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8BA164E10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9HO8cAFoTdkeqnG6lSER3w7jCp+GimSBgrY4invo/Y4=; b=MSX2JBudICkhwwOEAAkoWplZX fmM9FVIbAzuYwpLEGQZAla5Yh1bUTfgsu/goXxR45xg2Nx+XTyl+18r0wTxZSPyzcv0QD7KMxgq1n A2xWGTe7adYKfTGIL/xsLrQJwvp+GQSy3fKjIaeOWSkAHubngQq0ewHkaGIgIvk3O2p5X1R8HDed4 2dct5LkdBr1LzQYXXrxUGGG5WzyfXPXP2+9tMBzYwW1pJncIDnXI0jcnYdCv1YtoNYTTelHbvN+Qj Ot+O8iMKrdKWVfwBY5yEF0MOZylNiSj/ADA3pAr1Aqb6MwrqaJ9XWpDL+yHKmS3rQwftp3t1q5UeX AHe8hB0Yg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLlBU-00FduZ-KA; Mon, 15 Mar 2021 11:14:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLlBL-00Fdsh-Cu for linux-arm-kernel@lists.infradead.org; Mon, 15 Mar 2021 11:14:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id ADDC364E61; Mon, 15 Mar 2021 11:14:36 +0000 (UTC) Date: Mon, 15 Mar 2021 11:14:34 +0000 From: Catalin Marinas To: Valdis =?utf-8?Q?Kl=C4=93tnieks?= Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: arm64: kernel/sys.c - silence initialization warnings. Message-ID: <20210315111433.GA22897@arm.com> References: <162859.1615542946@turing-police> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <162859.1615542946@turing-police> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_111444_868485_70C9B5FA X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMTIsIDIwMjEgYXQgMDQ6NTU6NDZBTSAtMDUwMCwgVmFsZGlzIEtsxJN0bmll a3Mgd3JvdGU6Cj4gQnVpbGRpbmcgYXJjaC9hcm02NC9rZXJuZWwvc3lzLm8gd2l0aCBXPTEgdGhy b3dzIG92ZXIgMzAwIHdhcm5pbmdzOgo+IAo+IC91c3Ivc3JjL2xpbnV4LW5leHQvYXJjaC9hcm02 NC9rZXJuZWwvc3lzLmM6NTY6NDA6IHdhcm5pbmc6IGluaXRpYWxpemVkIGZpZWxkIG92ZXJ3cml0 dGVuIFstV292ZXJyaWRlLWluaXRdCj4gICAgNTYgfCAjZGVmaW5lIF9fU1lTQ0FMTChuciwgc3lt KSAgICAgIFtucl0gPSBfX2FybTY0XyMjc3ltLAo+ICAgICAgIHwgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn4KPiAvdXNyL3NyYy9saW51eC1uZXh0L2luY2x1 ZGUvdWFwaS9hc20tZ2VuZXJpYy91bmlzdGQuaDoyOTozNzogbm90ZTogaW4gZXhwYW5zaW9uIG9m IG1hY3JvICdfX1NZU0NBTEwnCj4gICAgMjkgfCAjZGVmaW5lIF9fU0NfQ09NUChfbnIsIF9zeXMs IF9jb21wKSBfX1NZU0NBTEwoX25yLCBfc3lzKQo+ICAgICAgIHwgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+Cj4gL3Vzci9zcmMvbGludXgtbmV4dC9pbmNsdWRl L3VhcGkvYXNtLWdlbmVyaWMvdW5pc3RkLmg6MzQ6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1h Y3JvICdfX1NDX0NPTVAnCj4gICAgMzQgfCBfX1NDX0NPTVAoX19OUl9pb19zZXR1cCwgc3lzX2lv X3NldHVwLCBjb21wYXRfc3lzX2lvX3NldHVwKQo+ICAgICAgIHwgXn5+fn5+fn5+Cj4gCj4gV2Ug a25vdyB0aGF0J3MgcHJldHR5IG11Y2ggdGhlIGZpbGUncyBwdXJwb3NlIGluIGxpZmUsIHNvIHRl bGwgdGhlCj4gYnVpbGQgc3lzdGVtIHRvIG5vdCByZW1pbmQgdXMuICBUaGlzIG1ha2VzIHRoZSAx IG90aGVyIHdhcm5pbmcgYQo+IGxvdCBtb3JlIG5vdGljZWFibGUuIAo+IAo+IFNpZ25lZC1vZmYt Ynk6IFZhbGRpcyBLbGV0bmlla3MgPHZhbGRpcy5rbGV0bmlla3NAdnQuZWR1Pgo+IAo+IGRpZmYg LS1naXQgYS9hcmNoL2FybTY0L2tlcm5lbC9NYWtlZmlsZSBiL2FyY2gvYXJtNjQva2VybmVsL01h a2VmaWxlCj4gaW5kZXggZWQ2NTU3NmNlNzEwLi45MTZiMjFkMmIzNWIgMTAwNjQ0Cj4gLS0tIGEv YXJjaC9hcm02NC9rZXJuZWwvTWFrZWZpbGUKPiArKysgYi9hcmNoL2FybTY0L2tlcm5lbC9NYWtl ZmlsZQo+IEBAIC04LDYgKzgsNyBAQCBDRkxBR1NfYXJtdjhfZGVwcmVjYXRlZC5vIDo9IC1JJChz cmMpCj4gIENGTEFHU19SRU1PVkVfZnRyYWNlLm8gPSAkKENDX0ZMQUdTX0ZUUkFDRSkKPiAgQ0ZM QUdTX1JFTU9WRV9pbnNuLm8gPSAkKENDX0ZMQUdTX0ZUUkFDRSkKPiAgQ0ZMQUdTX1JFTU9WRV9y ZXR1cm5fYWRkcmVzcy5vID0gJChDQ19GTEFHU19GVFJBQ0UpCj4gK0NGTEFHU19zeXMubyArPSAk KGNhbGwgY2MtZGlzYWJsZS13YXJuaW5nLCBvdmVycmlkZS1pbml0KQoKV2UgZG8gc2ltaWxhciBp bml0aWFsaXNhdGlvbiBpbiBhcmNoL2FybTY0L2tlcm5lbC9zeXMzMi5jIGFuZAphcmNoL2FybTY0 L2tlcm5lbC90cmFwcy5jIGZvciBleGFtcGxlLiBJdCdzIGEgcHJldHR5IGNvbW1vbiBwYXR0ZXJu CnRocm91Z2hvdXQgdGhlIGtlcm5lbC4KClNvIHdlIGVpdGhlciB0cmVhdCBXPTEgb3V0cHV0IGFz IGRpZmYgYWdhaW5zdCB0aGUgdmFuaWxsYSBrZXJuZWwgd2hlbgpjaGVja2luZyBuZXcgcGF0Y2hl cyBvciB3ZSByZW1vdmUgb3ZlcnJpZGUtaW5pdCBhbHRvZ2V0aGVyIGZyb20gVz0xLgpNYXJrIFJ1 dGxhbmQgcG9pbnRlZCBtZSB0byBhbiBvbGRlciB0aHJlYWQ6CgpodHRwczovL2xvcmUua2VybmVs Lm9yZy9saW51eC1hcm0ta2VybmVsLzIwMTkwODA5MDgzMjUxLkdBNDg0MjNAbGFrcmlkcy5jYW1i cmlkZ2UuYXJtLmNvbS8KCi0tIApDYXRhbGluCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB11AC433DB for ; Mon, 15 Mar 2021 11:15:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB24264E61 for ; Mon, 15 Mar 2021 11:15:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229721AbhCOLPG (ORCPT ); Mon, 15 Mar 2021 07:15:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:46462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbhCOLOh (ORCPT ); Mon, 15 Mar 2021 07:14:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ADDC364E61; Mon, 15 Mar 2021 11:14:36 +0000 (UTC) Date: Mon, 15 Mar 2021 11:14:34 +0000 From: Catalin Marinas To: Valdis =?utf-8?Q?Kl=C4=93tnieks?= Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: arm64: kernel/sys.c - silence initialization warnings. Message-ID: <20210315111433.GA22897@arm.com> References: <162859.1615542946@turing-police> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <162859.1615542946@turing-police> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 12, 2021 at 04:55:46AM -0500, Valdis Klētnieks wrote: > Building arch/arm64/kernel/sys.o with W=1 throws over 300 warnings: > > /usr/src/linux-next/arch/arm64/kernel/sys.c:56:40: warning: initialized field overwritten [-Woverride-init] > 56 | #define __SYSCALL(nr, sym) [nr] = __arm64_##sym, > | ^~~~~~~~ > /usr/src/linux-next/include/uapi/asm-generic/unistd.h:29:37: note: in expansion of macro '__SYSCALL' > 29 | #define __SC_COMP(_nr, _sys, _comp) __SYSCALL(_nr, _sys) > | ^~~~~~~~~ > /usr/src/linux-next/include/uapi/asm-generic/unistd.h:34:1: note: in expansion of macro '__SC_COMP' > 34 | __SC_COMP(__NR_io_setup, sys_io_setup, compat_sys_io_setup) > | ^~~~~~~~~ > > We know that's pretty much the file's purpose in life, so tell the > build system to not remind us. This makes the 1 other warning a > lot more noticeable. > > Signed-off-by: Valdis Kletnieks > > diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile > index ed65576ce710..916b21d2b35b 100644 > --- a/arch/arm64/kernel/Makefile > +++ b/arch/arm64/kernel/Makefile > @@ -8,6 +8,7 @@ CFLAGS_armv8_deprecated.o := -I$(src) > CFLAGS_REMOVE_ftrace.o = $(CC_FLAGS_FTRACE) > CFLAGS_REMOVE_insn.o = $(CC_FLAGS_FTRACE) > CFLAGS_REMOVE_return_address.o = $(CC_FLAGS_FTRACE) > +CFLAGS_sys.o += $(call cc-disable-warning, override-init) We do similar initialisation in arch/arm64/kernel/sys32.c and arch/arm64/kernel/traps.c for example. It's a pretty common pattern throughout the kernel. So we either treat W=1 output as diff against the vanilla kernel when checking new patches or we remove override-init altogether from W=1. Mark Rutland pointed me to an older thread: https://lore.kernel.org/linux-arm-kernel/20190809083251.GA48423@lakrids.cambridge.arm.com/ -- Catalin