From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: linux-mm@kvack.org, akpm@linux-foundation.org
Cc: peterz@infradead.org, kaleshsingh@google.com,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
joel@joelfernandes.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v2 3/6] mm/mremap: Use pmd/pud_poplulate to update page table entries
Date: Mon, 15 Mar 2021 17:08:21 +0530 [thread overview]
Message-ID: <20210315113824.270796-4-aneesh.kumar@linux.ibm.com> (raw)
In-Reply-To: <20210315113824.270796-1-aneesh.kumar@linux.ibm.com>
pmd/pud_populate is the right interface to be used to set the respective
page table entries. Some architectures like ppc64 do assume that set_pmd/pud_at
can only be used to set a hugepage PTE. Since we are not setting up a hugepage
PTE here, use the pmd/pud_populate interface.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
mm/mremap.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/mm/mremap.c b/mm/mremap.c
index ec8f840399ed..574287f9bb39 100644
--- a/mm/mremap.c
+++ b/mm/mremap.c
@@ -26,6 +26,7 @@
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
+#include <asm/pgalloc.h>
#include "internal.h"
@@ -257,9 +258,8 @@ static bool move_normal_pmd(struct vm_area_struct *vma, unsigned long old_addr,
pmd_clear(old_pmd);
VM_BUG_ON(!pmd_none(*new_pmd));
+ pmd_populate(mm, new_pmd, (pgtable_t)pmd_page_vaddr(pmd));
- /* Set the new pmd */
- set_pmd_at(mm, new_addr, new_pmd, pmd);
flush_tlb_range(vma, old_addr, old_addr + PMD_SIZE);
if (new_ptl != old_ptl)
spin_unlock(new_ptl);
@@ -306,8 +306,7 @@ static bool move_normal_pud(struct vm_area_struct *vma, unsigned long old_addr,
VM_BUG_ON(!pud_none(*new_pud));
- /* Set the new pud */
- set_pud_at(mm, new_addr, new_pud, pud);
+ pud_populate(mm, new_pud, (pmd_t *)pud_page_vaddr(pud));
flush_tlb_range(vma, old_addr, old_addr + PUD_SIZE);
if (new_ptl != old_ptl)
spin_unlock(new_ptl);
--
2.29.2
next prev parent reply other threads:[~2021-03-15 11:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 11:38 [PATCH v2 0/6] Speedup mremap on ppc64 Aneesh Kumar K.V
2021-03-15 11:38 ` [PATCH v2 1/6] selftest/mremap_test: Update the test to handle pagesize other than 4K Aneesh Kumar K.V
2021-03-15 11:38 ` [PATCH v2 2/6] selftest/mremap_test: Avoid crash with static build Aneesh Kumar K.V
2021-03-15 11:38 ` Aneesh Kumar K.V [this message]
2021-03-22 14:42 ` [LTP] [mm/mremap] c10e9d3441: Bad_pagetable:#[##] kernel test robot
2021-03-22 14:42 ` kernel test robot
2021-03-22 14:42 ` kernel test robot
2021-03-22 14:42 ` kernel test robot
2021-03-15 11:38 ` [PATCH v2 4/6] mm/mremap: Use mmu gather interface instead of flush_tlb_range Aneesh Kumar K.V
2021-03-18 8:22 ` kernel test robot
2021-03-18 8:22 ` kernel test robot
2021-03-18 8:22 ` kernel test robot
2021-03-18 8:34 ` Nicholas Piggin
2021-03-18 8:34 ` Nicholas Piggin
2021-03-15 11:38 ` [PATCH v2 5/6] mm/mremap: Allow arch runtime override Aneesh Kumar K.V
2021-03-15 11:38 ` [PATCH v2 6/6] powerpc/mm: Enable move pmd/pud Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315113824.270796-4-aneesh.kumar@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=joel@joelfernandes.org \
--cc=kaleshsingh@google.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.