Re: [PATCH 2/2] mmc: renesas_sdhi: do hard reset if possible

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]


> Adding the function itself seems OK. However, I checked the code, and then
> adding hard reset into renesas_sdhi_reset() seems to break the following:
> -----
> commit 5b0739d76227fd5a3f02f014385bfa9c86e0404b
> Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Date:   Thu Aug 20 15:25:37 2020 +0200
> 
>     mmc: tmio: don't reset whole IP core when tuning fails
> 
>     SDHI needs to reset the SCC only, not the whole IP core. So, if tuning
>     fails, don't handle specifics in the generic TMIO core, but in the
>     specific drivers. For SDHI, we need to move around the reset routine a
>     bit. It is not modified.
> ------
> 
> So, perhaps, we have to fix renesas_sdhi_execute_tuning() somehow before
> adding hard reset. But, what do you think?

Thanks for the pointer, Shimoda-san! It seems it gets messy again, so
time for getting clearer, I think. I will introduce a reset_scc funtion
again which is seperate from reset_sdhi, so we have a clear distinction.
Then, I will call reset_scc from renesas_sdhi_execute_tuning() and the
rest stays with reset_sdhi. I have a prototype patch which I will test
some more and  hopefully send out later.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]