From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org,
evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: ipa: fix another QMI message definition
Date: Tue, 16 Mar 2021 09:12:08 +0530 [thread overview]
Message-ID: <20210316034208.GD29414@work> (raw)
In-Reply-To: <20210315152112.1907968-3-elder@linaro.org>
On Mon, Mar 15, 2021 at 10:21:11AM -0500, Alex Elder wrote:
> The ipa_init_modem_driver_req_ei[] encoding array for the
> INIT_MODEM_DRIVER request message has some errors in it.
>
> First, the tlv_type associated with the hw_stats_quota_size field is
> wrong; it duplicates the valiue used for the hw_stats_quota_base_addr
> field (0x1f) and should use 0x20 instead. The tlv_type value for
> the hw_stats_drop_size field also uses the same duplicate value; it
> should use 0x22 instead.
>
> Second, there is no definition for the hw_stats_drop_base_addr
> field. It is an optional 32-bit enumerated type value.
>
> Finally, the hw_stats_quota_base_addr, hw_stats_quota_size, and
> hw_stats_drop_size fields are defined as enumerated types; they
> should be unsigned 4-byte values.
>
> Reported-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Alex Elder <elder@linaro.org>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/net/ipa/ipa_qmi_msg.c | 34 +++++++++++++++++++++++++++-------
> 1 file changed, 27 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c
> index e00f829a783f6..e4a6efbe9bd00 100644
> --- a/drivers/net/ipa/ipa_qmi_msg.c
> +++ b/drivers/net/ipa/ipa_qmi_msg.c
> @@ -530,7 +530,7 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = {
> hw_stats_quota_base_addr_valid),
> },
> {
> - .data_type = QMI_SIGNED_4_BYTE_ENUM,
> + .data_type = QMI_UNSIGNED_4_BYTE,
> .elem_len = 1,
> .elem_size =
> sizeof_field(struct ipa_init_modem_driver_req,
> @@ -545,37 +545,57 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = {
> .elem_size =
> sizeof_field(struct ipa_init_modem_driver_req,
> hw_stats_quota_size_valid),
> - .tlv_type = 0x1f,
> + .tlv_type = 0x20,
> .offset = offsetof(struct ipa_init_modem_driver_req,
> hw_stats_quota_size_valid),
> },
> {
> - .data_type = QMI_SIGNED_4_BYTE_ENUM,
> + .data_type = QMI_UNSIGNED_4_BYTE,
> .elem_len = 1,
> .elem_size =
> sizeof_field(struct ipa_init_modem_driver_req,
> hw_stats_quota_size),
> - .tlv_type = 0x1f,
> + .tlv_type = 0x20,
> .offset = offsetof(struct ipa_init_modem_driver_req,
> hw_stats_quota_size),
> },
> + {
> + .data_type = QMI_OPT_FLAG,
> + .elem_len = 1,
> + .elem_size =
> + sizeof_field(struct ipa_init_modem_driver_req,
> + hw_stats_drop_base_addr_valid),
> + .tlv_type = 0x21,
> + .offset = offsetof(struct ipa_init_modem_driver_req,
> + hw_stats_drop_base_addr_valid),
> + },
> + {
> + .data_type = QMI_UNSIGNED_4_BYTE,
> + .elem_len = 1,
> + .elem_size =
> + sizeof_field(struct ipa_init_modem_driver_req,
> + hw_stats_drop_base_addr),
> + .tlv_type = 0x21,
> + .offset = offsetof(struct ipa_init_modem_driver_req,
> + hw_stats_drop_base_addr),
> + },
> {
> .data_type = QMI_OPT_FLAG,
> .elem_len = 1,
> .elem_size =
> sizeof_field(struct ipa_init_modem_driver_req,
> hw_stats_drop_size_valid),
> - .tlv_type = 0x1f,
> + .tlv_type = 0x22,
> .offset = offsetof(struct ipa_init_modem_driver_req,
> hw_stats_drop_size_valid),
> },
> {
> - .data_type = QMI_SIGNED_4_BYTE_ENUM,
> + .data_type = QMI_UNSIGNED_4_BYTE,
> .elem_len = 1,
> .elem_size =
> sizeof_field(struct ipa_init_modem_driver_req,
> hw_stats_drop_size),
> - .tlv_type = 0x1f,
> + .tlv_type = 0x22,
> .offset = offsetof(struct ipa_init_modem_driver_req,
> hw_stats_drop_size),
> },
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-03-16 3:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 15:21 [PATCH net-next 0/3] net: ipa: QMI fixes Alex Elder
2021-03-15 15:21 ` [PATCH net-next 1/3] net: ipa: fix a duplicated tlv_type value Alex Elder
2021-03-16 3:37 ` Manivannan Sadhasivam
2021-03-15 15:21 ` [PATCH net-next 2/3] net: ipa: fix another QMI message definition Alex Elder
2021-03-16 3:42 ` Manivannan Sadhasivam [this message]
2021-03-15 15:21 ` [PATCH net-next 3/3] net: ipa: extend the INDICATION_REGISTER request Alex Elder
2021-03-16 3:43 ` Manivannan Sadhasivam
2021-03-15 16:38 ` [PATCH net-next 0/3] net: ipa: QMI fixes Manivannan Sadhasivam
2021-03-15 16:50 ` Alex Elder
2021-03-16 3:25 ` Manivannan Sadhasivam
2021-03-16 16:00 ` Alex Elder
2021-03-16 16:38 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316034208.GD29414@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.