From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kvm-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B8758C433DB
	for <kvm@archiver.kernel.org>; Tue, 16 Mar 2021 06:28:31 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 841966520A
	for <kvm@archiver.kernel.org>; Tue, 16 Mar 2021 06:28:31 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231394AbhCPG1x (ORCPT <rfc822;kvm@archiver.kernel.org>);
        Tue, 16 Mar 2021 02:27:53 -0400
Received: from verein.lst.de ([213.95.11.211]:58538 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229775AbhCPG1X (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 16 Mar 2021 02:27:23 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 5C35268C4E; Tue, 16 Mar 2021 07:27:20 +0100 (CET)
Date:   Tue, 16 Mar 2021 07:27:20 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Christoph Hellwig <hch@lst.de>, Cornelia Huck <cohuck@redhat.com>,
        kvm@vger.kernel.org, Alex Williamson <alex.williamson@redhat.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Leon Romanovsky <leonro@nvidia.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Tarun Gupta <targupta@nvidia.com>
Subject: Re: [PATCH v2 07/14] vfio/pci: Move VGA and VF initialization to
 functions
Message-ID: <20210316062720.GA13303@lst.de>
References: <0-v2-20d933792272+4ff-vfio1_jgg@nvidia.com> <7-v2-20d933792272+4ff-vfio1_jgg@nvidia.com> <20210315084534.GC29269@lst.de> <20210315230746.GJ2356281@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210315230746.GJ2356281@nvidia.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org

On Mon, Mar 15, 2021 at 08:07:46PM -0300, Jason Gunthorpe wrote:
> So the goto unwind looks quite odd when this is open coded. At least
> with the helpers you can read the init then uninit and go 'yah, OK,
> this makes sense'

Still looks odd to me.  But this is your series and overall a major
improvements, so:

Reviewed-by: Christoph Hellwig <hch@lst.de>