From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org,
Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [PATCH 1/2] nvme-pci: allocate nvme_command within driver pdu
Date: Tue, 16 Mar 2021 19:34:45 +0100 [thread overview]
Message-ID: <20210316183444.GA30936@lst.de> (raw)
In-Reply-To: <f1fea65d-2be1-dc87-5f64-116884f452e9@grimberg.me>
On Tue, Mar 16, 2021 at 11:27:20AM -0700, Sagi Grimberg wrote:
>
>>>> All the nvme transport drivers had allocated the nvme command within the
>>>> driver's pdu except for pci. Align pci with everyone else and replace
>>>> the stack variable with the pdu command.
>>>
>>> At some point in this series nvme_request.cmd should become the
>>> actual structure instead of a pointer so that we can remove this
>>> indiretion. I'd be tempted to just do this in the initial patch,
>>> but I'm fine with any kind of patch ordering.
>>
>> I tried to start off in that direction, but had some trouble. All the
>> fabrics drivers embed their preallocated command within a larger
>> protocol specific payload, so we either need the indirection or have a
>> copy of the command.
>
> Yes, tcp and fc have headers that prepend the command so its better
> for them to have cmd+header allocated together.
Ok, I guess we need to keep the pointer than. Would have been nice
to avoid that, though.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-16 18:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 17:06 [PATCH 1/2] nvme-pci: allocate nvme_command within driver pdu Keith Busch
2021-03-16 17:06 ` [PATCH 2/2] nvme: use driver pdu command for passthrough Keith Busch
2021-03-16 17:44 ` Sagi Grimberg
2021-03-16 18:08 ` Keith Busch
2021-03-17 6:47 ` Christoph Hellwig
2021-03-17 9:46 ` Kanchan Joshi
2021-03-17 14:06 ` Keith Busch
2021-03-16 17:44 ` [PATCH 1/2] nvme-pci: allocate nvme_command within driver pdu Sagi Grimberg
2021-03-16 18:02 ` Christoph Hellwig
2021-03-16 18:13 ` Keith Busch
2021-03-16 18:27 ` Sagi Grimberg
2021-03-16 18:34 ` Christoph Hellwig [this message]
2021-03-17 6:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316183444.GA30936@lst.de \
--to=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.