From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6D7C43381 for ; Wed, 17 Mar 2021 00:57:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D91964FC0 for ; Wed, 17 Mar 2021 00:57:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D91964FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2TiPsc//iFIPm/AaNmwYpqJaDmVNuAWs5iYO7TLKcXM=; b=L62IR60PK+WpNM9+WjJ+SotVe FiWYlGiNw1qX5QRUN0vTL0zGASiedcI7kY+JNMG050QD7ugmPbJSNfk2lMe8LZ/f4WdzWY8kSjAm7 w3/LYIXc8hkfzJ2cnaiEEwKKqJtrGPTwmNMScuvcvv4BcjuJXQJJ0QvO7inz+PtOf4E8jYBpe5m9p Nyi0YEYTJfLAbL8mC/A8+fVnWF7DU30GdH97El9ihPCjTIhlyQI/04ZuhSbjUgSmH9ua7G7iGBFM9 Nqg8oG0kQhPaWFt8jeWtkFwvyTnOTvL+QjHOIofPZi8WDxeyrRa8I0cdY/MU9onc8DYsLZ+HZqrB5 ZxImAGbBA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMKUf-0026rC-BM; Wed, 17 Mar 2021 00:57:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMKUJ-0026ed-HK for linux-nvme@lists.infradead.org; Wed, 17 Mar 2021 00:56:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 47EDD64FAE; Wed, 17 Mar 2021 00:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615942598; bh=ins3jRxi8A8HCIgmPLDKTRyzEZNWsAkHvBknS68+8sY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QUFhl8vXrjt/7rR8gxq0GzxtCr+pLe1T+Xs9CPomBF9OuRGHMNnCDy5OSUXW6TqZc bO+Mx+e7owSVKZSjYJ1zRyJPel8ulyHUgnQnOmtGevuFFe3vJipKHTaDtOWiIRjaP0 NIfEK4/Uyvp9mFfCOyNH1jI+v504DCO5Octr+TM12D2RWiyzyNGO51lnjRkWNozeQO ms+QVIAnj+QMI1+NtrKq6xiN9/w+AEkDqImF4ASU6wz4oYFOy6ZKupbWxdSz6l7zW6 q7DVRPrH51Dq6NKJ/mkDPQj9LhihTUmnxREshjlQBekJ+357VHDTlibURYI9ToV21g XaC6X2mApU10w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hannes Reinecke , Keith Busch , Sagi Grimberg , Chao Leng , Daniel Wagner , Christoph Hellwig , Sasha Levin , linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 5.11 50/61] nvme: add NVME_REQ_CANCELLED flag in nvme_cancel_request() Date: Tue, 16 Mar 2021 20:55:24 -0400 Message-Id: <20210317005536.724046-50-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210317005536.724046-1-sashal@kernel.org> References: <20210317005536.724046-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_005639_971103_409A54BE X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Hannes Reinecke [ Upstream commit d3589381987ec879b03f8ce3039df57e87f05901 ] NVME_REQ_CANCELLED is translated into -EINTR in nvme_submit_sync_cmd(), so we should be setting this flags during nvme_cancel_request() to ensure that the callers to nvme_submit_sync_cmd() will get the correct error code when the controller is reset. Signed-off-by: Hannes Reinecke Reviewed-by: Keith Busch Reviewed-by: Sagi Grimberg Reviewed-by: Chao Leng Reviewed-by: Daniel Wagner Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 1d6576b6bda3..28bfe5bbf769 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -366,6 +366,7 @@ bool nvme_cancel_request(struct request *req, void *data, bool reserved) return true; nvme_req(req)->status = NVME_SC_HOST_ABORTED_CMD; + nvme_req(req)->flags |= NVME_REQ_CANCELLED; blk_mq_complete_request(req); return true; } -- 2.30.1 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04DDC41518 for ; Wed, 17 Mar 2021 00:58:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 833C664F9E for ; Wed, 17 Mar 2021 00:58:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231837AbhCQA56 (ORCPT ); Tue, 16 Mar 2021 20:57:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:34226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230521AbhCQA4i (ORCPT ); Tue, 16 Mar 2021 20:56:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 47EDD64FAE; Wed, 17 Mar 2021 00:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615942598; bh=ins3jRxi8A8HCIgmPLDKTRyzEZNWsAkHvBknS68+8sY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QUFhl8vXrjt/7rR8gxq0GzxtCr+pLe1T+Xs9CPomBF9OuRGHMNnCDy5OSUXW6TqZc bO+Mx+e7owSVKZSjYJ1zRyJPel8ulyHUgnQnOmtGevuFFe3vJipKHTaDtOWiIRjaP0 NIfEK4/Uyvp9mFfCOyNH1jI+v504DCO5Octr+TM12D2RWiyzyNGO51lnjRkWNozeQO ms+QVIAnj+QMI1+NtrKq6xiN9/w+AEkDqImF4ASU6wz4oYFOy6ZKupbWxdSz6l7zW6 q7DVRPrH51Dq6NKJ/mkDPQj9LhihTUmnxREshjlQBekJ+357VHDTlibURYI9ToV21g XaC6X2mApU10w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hannes Reinecke , Keith Busch , Sagi Grimberg , Chao Leng , Daniel Wagner , Christoph Hellwig , Sasha Levin , linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 5.11 50/61] nvme: add NVME_REQ_CANCELLED flag in nvme_cancel_request() Date: Tue, 16 Mar 2021 20:55:24 -0400 Message-Id: <20210317005536.724046-50-sashal@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210317005536.724046-1-sashal@kernel.org> References: <20210317005536.724046-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hannes Reinecke [ Upstream commit d3589381987ec879b03f8ce3039df57e87f05901 ] NVME_REQ_CANCELLED is translated into -EINTR in nvme_submit_sync_cmd(), so we should be setting this flags during nvme_cancel_request() to ensure that the callers to nvme_submit_sync_cmd() will get the correct error code when the controller is reset. Signed-off-by: Hannes Reinecke Reviewed-by: Keith Busch Reviewed-by: Sagi Grimberg Reviewed-by: Chao Leng Reviewed-by: Daniel Wagner Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 1d6576b6bda3..28bfe5bbf769 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -366,6 +366,7 @@ bool nvme_cancel_request(struct request *req, void *data, bool reserved) return true; nvme_req(req)->status = NVME_SC_HOST_ABORTED_CMD; + nvme_req(req)->flags |= NVME_REQ_CANCELLED; blk_mq_complete_request(req); return true; } -- 2.30.1