From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [linux-next:master 2190/5053] drivers/tty/serial/pch_uart.c:1815:9: error: use of undeclared identifier 'port_regs_ops'
Date: Wed, 17 Mar 2021 19:39:10 +0800 [thread overview]
Message-ID: <202103171900.vKL7wCVE-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5181 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fa903833ae344e4f4d798a8b85ba3ef0c5ce96c9
commit: 4dec5f1af694526db760dfbb47211236e556e27c [2190/5053] tty: serial: pch_uart.c: remove debugfs dentry pointer
config: powerpc64-randconfig-r024-20210317 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8ef111222a3dd12a9175f69c3bff598c46e8bdf7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4dec5f1af694526db760dfbb47211236e556e27c
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 4dec5f1af694526db760dfbb47211236e556e27c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/tty/serial/pch_uart.c:1815:9: error: use of undeclared identifier 'port_regs_ops'
&port_regs_ops);
^
1 error generated.
vim +/port_regs_ops +1815 drivers/tty/serial/pch_uart.c
1725
1726 static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev,
1727 const struct pci_device_id *id)
1728 {
1729 struct eg20t_port *priv;
1730 int ret;
1731 unsigned int iobase;
1732 unsigned int mapbase;
1733 unsigned char *rxbuf;
1734 int fifosize;
1735 int port_type;
1736 struct pch_uart_driver_data *board;
1737 char name[32];
1738
1739 board = &drv_dat[id->driver_data];
1740 port_type = board->port_type;
1741
1742 priv = kzalloc(sizeof(struct eg20t_port), GFP_KERNEL);
1743 if (priv == NULL)
1744 goto init_port_alloc_err;
1745
1746 rxbuf = (unsigned char *)__get_free_page(GFP_KERNEL);
1747 if (!rxbuf)
1748 goto init_port_free_txbuf;
1749
1750 switch (port_type) {
1751 case PORT_PCH_8LINE:
1752 fifosize = 256; /* EG20T/ML7213: UART0 */
1753 break;
1754 case PORT_PCH_2LINE:
1755 fifosize = 64; /* EG20T:UART1~3 ML7213: UART1~2*/
1756 break;
1757 default:
1758 dev_err(&pdev->dev, "Invalid Port Type(=%d)\n", port_type);
1759 goto init_port_hal_free;
1760 }
1761
1762 pci_enable_msi(pdev);
1763 pci_set_master(pdev);
1764
1765 spin_lock_init(&priv->lock);
1766
1767 iobase = pci_resource_start(pdev, 0);
1768 mapbase = pci_resource_start(pdev, 1);
1769 priv->mapbase = mapbase;
1770 priv->iobase = iobase;
1771 priv->pdev = pdev;
1772 priv->tx_empty = 1;
1773 priv->rxbuf.buf = rxbuf;
1774 priv->rxbuf.size = PAGE_SIZE;
1775
1776 priv->fifo_size = fifosize;
1777 priv->uartclk = pch_uart_get_uartclk();
1778 priv->port_type = port_type;
1779 priv->port.dev = &pdev->dev;
1780 priv->port.iobase = iobase;
1781 priv->port.membase = NULL;
1782 priv->port.mapbase = mapbase;
1783 priv->port.irq = pdev->irq;
1784 priv->port.iotype = UPIO_PORT;
1785 priv->port.ops = &pch_uart_ops;
1786 priv->port.flags = UPF_BOOT_AUTOCONF;
1787 priv->port.fifosize = fifosize;
1788 priv->port.line = board->line_no;
1789 priv->port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_PCH_UART_CONSOLE);
1790 priv->trigger = PCH_UART_HAL_TRIGGER_M;
1791
1792 snprintf(priv->irq_name, IRQ_NAME_SIZE,
1793 KBUILD_MODNAME ":" PCH_UART_DRIVER_DEVICE "%d",
1794 priv->port.line);
1795
1796 spin_lock_init(&priv->port.lock);
1797
1798 pci_set_drvdata(pdev, priv);
1799 priv->trigger_level = 1;
1800 priv->fcr = 0;
1801
1802 if (pdev->dev.of_node)
1803 of_property_read_u32(pdev->dev.of_node, "clock-frequency"
1804 , &user_uartclk);
1805
1806 #ifdef CONFIG_SERIAL_PCH_UART_CONSOLE
1807 pch_uart_ports[board->line_no] = priv;
1808 #endif
1809 ret = uart_add_one_port(&pch_uart_driver, &priv->port);
1810 if (ret < 0)
1811 goto init_port_hal_free;
1812
1813 snprintf(name, sizeof(name), "uart%d_regs", priv->port.line);
1814 debugfs_create_file(name, S_IFREG | S_IRUGO, NULL, priv,
> 1815 &port_regs_ops);
1816
1817 return priv;
1818
1819 init_port_hal_free:
1820 #ifdef CONFIG_SERIAL_PCH_UART_CONSOLE
1821 pch_uart_ports[board->line_no] = NULL;
1822 #endif
1823 free_page((unsigned long)rxbuf);
1824 init_port_free_txbuf:
1825 kfree(priv);
1826 init_port_alloc_err:
1827
1828 return NULL;
1829 }
1830
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38016 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [linux-next:master 2190/5053] drivers/tty/serial/pch_uart.c:1815:9: error: use of undeclared identifier 'port_regs_ops'
Date: Wed, 17 Mar 2021 19:39:10 +0800 [thread overview]
Message-ID: <202103171900.vKL7wCVE-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5039 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fa903833ae344e4f4d798a8b85ba3ef0c5ce96c9
commit: 4dec5f1af694526db760dfbb47211236e556e27c [2190/5053] tty: serial: pch_uart.c: remove debugfs dentry pointer
config: powerpc64-randconfig-r024-20210317 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8ef111222a3dd12a9175f69c3bff598c46e8bdf7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4dec5f1af694526db760dfbb47211236e556e27c
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 4dec5f1af694526db760dfbb47211236e556e27c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/tty/serial/pch_uart.c:1815:9: error: use of undeclared identifier 'port_regs_ops'
&port_regs_ops);
^
1 error generated.
vim +/port_regs_ops +1815 drivers/tty/serial/pch_uart.c
1725
1726 static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev,
1727 const struct pci_device_id *id)
1728 {
1729 struct eg20t_port *priv;
1730 int ret;
1731 unsigned int iobase;
1732 unsigned int mapbase;
1733 unsigned char *rxbuf;
1734 int fifosize;
1735 int port_type;
1736 struct pch_uart_driver_data *board;
1737 char name[32];
1738
1739 board = &drv_dat[id->driver_data];
1740 port_type = board->port_type;
1741
1742 priv = kzalloc(sizeof(struct eg20t_port), GFP_KERNEL);
1743 if (priv == NULL)
1744 goto init_port_alloc_err;
1745
1746 rxbuf = (unsigned char *)__get_free_page(GFP_KERNEL);
1747 if (!rxbuf)
1748 goto init_port_free_txbuf;
1749
1750 switch (port_type) {
1751 case PORT_PCH_8LINE:
1752 fifosize = 256; /* EG20T/ML7213: UART0 */
1753 break;
1754 case PORT_PCH_2LINE:
1755 fifosize = 64; /* EG20T:UART1~3 ML7213: UART1~2*/
1756 break;
1757 default:
1758 dev_err(&pdev->dev, "Invalid Port Type(=%d)\n", port_type);
1759 goto init_port_hal_free;
1760 }
1761
1762 pci_enable_msi(pdev);
1763 pci_set_master(pdev);
1764
1765 spin_lock_init(&priv->lock);
1766
1767 iobase = pci_resource_start(pdev, 0);
1768 mapbase = pci_resource_start(pdev, 1);
1769 priv->mapbase = mapbase;
1770 priv->iobase = iobase;
1771 priv->pdev = pdev;
1772 priv->tx_empty = 1;
1773 priv->rxbuf.buf = rxbuf;
1774 priv->rxbuf.size = PAGE_SIZE;
1775
1776 priv->fifo_size = fifosize;
1777 priv->uartclk = pch_uart_get_uartclk();
1778 priv->port_type = port_type;
1779 priv->port.dev = &pdev->dev;
1780 priv->port.iobase = iobase;
1781 priv->port.membase = NULL;
1782 priv->port.mapbase = mapbase;
1783 priv->port.irq = pdev->irq;
1784 priv->port.iotype = UPIO_PORT;
1785 priv->port.ops = &pch_uart_ops;
1786 priv->port.flags = UPF_BOOT_AUTOCONF;
1787 priv->port.fifosize = fifosize;
1788 priv->port.line = board->line_no;
1789 priv->port.has_sysrq = IS_ENABLED(CONFIG_SERIAL_PCH_UART_CONSOLE);
1790 priv->trigger = PCH_UART_HAL_TRIGGER_M;
1791
1792 snprintf(priv->irq_name, IRQ_NAME_SIZE,
1793 KBUILD_MODNAME ":" PCH_UART_DRIVER_DEVICE "%d",
1794 priv->port.line);
1795
1796 spin_lock_init(&priv->port.lock);
1797
1798 pci_set_drvdata(pdev, priv);
1799 priv->trigger_level = 1;
1800 priv->fcr = 0;
1801
1802 if (pdev->dev.of_node)
1803 of_property_read_u32(pdev->dev.of_node, "clock-frequency"
1804 , &user_uartclk);
1805
1806 #ifdef CONFIG_SERIAL_PCH_UART_CONSOLE
1807 pch_uart_ports[board->line_no] = priv;
1808 #endif
1809 ret = uart_add_one_port(&pch_uart_driver, &priv->port);
1810 if (ret < 0)
1811 goto init_port_hal_free;
1812
1813 snprintf(name, sizeof(name), "uart%d_regs", priv->port.line);
1814 debugfs_create_file(name, S_IFREG | S_IRUGO, NULL, priv,
> 1815 &port_regs_ops);
1816
1817 return priv;
1818
1819 init_port_hal_free:
1820 #ifdef CONFIG_SERIAL_PCH_UART_CONSOLE
1821 pch_uart_ports[board->line_no] = NULL;
1822 #endif
1823 free_page((unsigned long)rxbuf);
1824 init_port_free_txbuf:
1825 kfree(priv);
1826 init_port_alloc_err:
1827
1828 return NULL;
1829 }
1830
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38016 bytes --]
next reply other threads:[~2021-03-17 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 11:39 kernel test robot [this message]
2021-03-17 11:39 ` [linux-next:master 2190/5053] drivers/tty/serial/pch_uart.c:1815:9: error: use of undeclared identifier 'port_regs_ops' kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103171900.vKL7wCVE-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.