Re: [RFC PATCH v4 13/19] dyndbg+module: expose ddebug_sites to modules

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4101 bytes --]

Hi Jim,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tip/x86/core]
[also build test ERROR on jeyu/modules-next tip/x86/vdso efi/next drm-intel/for-linux-next kbuild/for-next linus/master v5.12-rc3 next-20210317]
[cannot apply to asm-generic/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jim-Cromie/dyndbg-split-struct-_ddebug-move-display-fields-to-new-_ddebug_site/20210317-155358
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git f935178b5c1c32ff803b15892a8ba85a1280cb01
config: mips-randconfig-r015-20210317 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5e967879ab4f65ac82fbc4ee3593aa31c801cc84
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jim-Cromie/dyndbg-split-struct-_ddebug-move-display-fields-to-new-_ddebug_site/20210317-155358
        git checkout 5e967879ab4f65ac82fbc4ee3593aa31c801cc84
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   kernel/module.c: In function 'dynamic_debug_setup':
>> kernel/module.c:2788:27: warning: passing argument 2 of 'ddebug_add_module' makes integer from pointer without a cast [-Wint-conversion]
    2788 |  ddebug_add_module(debug, sites, num, mod->name);
         |                           ^~~~~
         |                           |
         |                           struct _ddebug_site *
   In file included from kernel/module.c:57:
   include/linux/dynamic_debug.h:206:71: note: expected 'unsigned int' but argument is of type 'struct _ddebug_site *'
     206 | static inline int ddebug_add_module(struct _ddebug *tab, unsigned int n,
         |                                                          ~~~~~~~~~~~~~^
>> kernel/module.c:2788:34: warning: passing argument 3 of 'ddebug_add_module' makes pointer from integer without a cast [-Wint-conversion]
    2788 |  ddebug_add_module(debug, sites, num, mod->name);
         |                                  ^~~
         |                                  |
         |                                  unsigned int
   In file included from kernel/module.c:57:
   include/linux/dynamic_debug.h:207:21: note: expected 'const char *' but argument is of type 'unsigned int'
     207 |         const char *modname)
         |         ~~~~~~~~~~~~^~~~~~~
>> kernel/module.c:2788:2: error: too many arguments to function 'ddebug_add_module'
    2788 |  ddebug_add_module(debug, sites, num, mod->name);
         |  ^~~~~~~~~~~~~~~~~
   In file included from kernel/module.c:57:
   include/linux/dynamic_debug.h:206:19: note: declared here
     206 | static inline int ddebug_add_module(struct _ddebug *tab, unsigned int n,
         |                   ^~~~~~~~~~~~~~~~~
   kernel/module.c: At top level:
   kernel/module.c:4678:6: warning: no previous prototype for 'module_layout' [-Wmissing-prototypes]
    4678 | void module_layout(struct module *mod,
         |      ^~~~~~~~~~~~~


vim +/ddebug_add_module +2788 kernel/module.c

  2782	
  2783	static void dynamic_debug_setup(struct module *mod, struct _ddebug *debug,
  2784					struct _ddebug_site *sites, unsigned int num)
  2785	{
  2786		if (!debug)
  2787			return;
> 2788		ddebug_add_module(debug, sites, num, mod->name);
  2789	}
  2790	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24627 bytes --]