From: Huang Rui <ray.huang@amd.com>
To: "Du, Xiaojian" <Xiaojian.Du@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: enable mode-2 gpu reset for vangogh
Date: Thu, 18 Mar 2021 15:33:33 +0800 [thread overview]
Message-ID: <20210318073333.GC2497230@hr-amd> (raw)
In-Reply-To: <20210318072120.10535-1-Xiaojian.Du@amd.com>
On Thu, Mar 18, 2021 at 03:21:20PM +0800, Du, Xiaojian wrote:
> From: Xiaojian Du <xiaojian.du@amd.com>
>
> From: Xiaojian Du <Xiaojian.Du@amd.com>
>
> This patch is to enable mdoe-2 gpu reset for vangogh.
>
> Signed-off-by: Xiaojian Du <Xiaojian.Du@amd.com>
Please add the fix PSP firmware version in the commit to let us know the
good version for reset.
Others look good for me, good job!
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/nv.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
> index 5846eac292c3..a31ef68ee2ab 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nv.c
> @@ -561,10 +561,6 @@ static int nv_asic_reset(struct amdgpu_device *adev)
> int ret = 0;
> struct smu_context *smu = &adev->smu;
>
> - /* skip reset on vangogh for now */
> - if (adev->asic_type == CHIP_VANGOGH)
> - return 0;
> -
> switch (nv_asic_reset_method(adev)) {
> case AMD_RESET_METHOD_PCI:
> dev_info(adev->dev, "PCI reset\n");
> --
> 2.17.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2021-03-18 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 7:21 [PATCH] drm/amdgpu: enable mode-2 gpu reset for vangogh Xiaojian Du
2021-03-18 7:33 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318073333.GC2497230@hr-amd \
--to=ray.huang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.