From: Wolfram Sang <wsa@kernel.org>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>
Cc: paul@crapouillou.net, stable@vger.kernel.org,
linux-mips@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, sernia.zhou@foxmail.com
Subject: Re: [PATCH] I2C: JZ4780: Fix bug for Ingenic X1000.
Date: Thu, 18 Mar 2021 18:06:23 +0100 [thread overview]
Message-ID: <20210318170623.GA1961@ninjato> (raw)
In-Reply-To: <1616084743-112402-2-git-send-email-zhouyanjie@wanyeetech.com>
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
On Fri, Mar 19, 2021 at 12:25:43AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> Only send "X1000_I2C_DC_STOP" when last byte, or it will cause
> error when I2C write operation.
Any write operation? I wonder then why nobody noticed before?
> - while ((i2c_sta & JZ4780_I2C_STA_TFNF) &&
> - (i2c->wt_len > 0)) {
> + while ((i2c_sta & JZ4780_I2C_STA_TFNF) && (i2c->wt_len > 0)) {
This is a cosmetic change only IIUC. Shouldn't be in a bugfix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-18 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 16:25 Fix bug for Ingenic X1000 周琰杰 (Zhou Yanjie)
2021-03-18 16:25 ` [PATCH] I2C: JZ4780: " 周琰杰 (Zhou Yanjie)
2021-03-18 17:01 ` Greg KH
2021-03-18 17:06 ` Wolfram Sang [this message]
2021-03-19 6:58 ` Zhou Yanjie
2021-03-31 7:18 ` Wolfram Sang
2021-04-02 15:30 ` Zhou Yanjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318170623.GA1961@ninjato \
--to=wsa@kernel.org \
--cc=aric.pzqi@ingenic.com \
--cc=dongsheng.qiu@ingenic.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sernia.zhou@foxmail.com \
--cc=stable@vger.kernel.org \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.