From: Wolfram Sang <wsa@kernel.org>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: linux@rempel-privat.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, sumit.semwal@linaro.org,
christian.koenig@amd.com, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: imx: Use devm_request_irq()
Date: Fri, 19 Mar 2021 10:40:24 +0100 [thread overview]
Message-ID: <20210319094024.GA1003@ninjato> (raw)
In-Reply-To: <1616146420-6468-1-git-send-email-tiantao6@hisilicon.com>
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On Fri, Mar 19, 2021 at 05:33:40PM +0800, Tian Tao wrote:
> Use devm_request_irq() to get rid of manual unregistration.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Please don't send such patches unless you have a deep understanding of
the hardware. devm and interrupts are a dangerous combination because
you can get interrupts when the driver is gone already ( == OOPS) if you
don't pay close attention.
For this reason, I won't take janitorial patches with regard to devm and
interrupts.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-03-19 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 9:33 [PATCH] i2c: imx: Use devm_request_irq() Tian Tao
2021-03-19 9:40 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319094024.GA1003@ninjato \
--to=wsa@kernel.org \
--cc=christian.koenig@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.