From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 729C9C433DB for ; Fri, 19 Mar 2021 13:10:21 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 024D764EE6 for ; Fri, 19 Mar 2021 13:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 024D764EE6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9EB8C6071A; Fri, 19 Mar 2021 13:10:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uLJeP2f0XWGI; Fri, 19 Mar 2021 13:10:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id 02E9F6063B; Fri, 19 Mar 2021 13:10:17 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CB804C000B; Fri, 19 Mar 2021 13:10:17 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3014BC0001 for ; Fri, 19 Mar 2021 13:10:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 09E22400C0 for ; Fri, 19 Mar 2021 13:10:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wc1PQqXhi91A for ; Fri, 19 Mar 2021 13:10:16 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7687A400AB for ; Fri, 19 Mar 2021 13:10:16 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 3E99C68BFE; Fri, 19 Mar 2021 14:10:12 +0100 (CET) Date: Fri, 19 Mar 2021 14:10:11 +0100 From: Christoph Hellwig To: Ricardo Ribalda Subject: Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API Message-ID: <20210319131011.GA3372@lst.de> References: <20210312235521.1408503-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Sergey Senozhatsky , Linux Media Mailing List , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Laurent Pinchart , Mauro Carvalho Chehab , Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Mar 19, 2021 at 02:05:21PM +0100, Ricardo Ribalda wrote: > > + uvc_urb->sgt, > > + uvc_stream_dir(uvc_urb->stream)); > > + return usb_submit_urb(uvc_urb->urb, GFP_KERNEL); > > +} > > We should have mem_flags instead of GFP_KERNEL here > > > Is it too late to fix it in your tree? Do I need to send a patch to fix it? As far as I know we don't have anything that has pulled in the tree yet, so I can just fold the fix in. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525B7C433DB for ; Fri, 19 Mar 2021 13:11:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1852364ED7 for ; Fri, 19 Mar 2021 13:11:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbhCSNKs (ORCPT ); Fri, 19 Mar 2021 09:10:48 -0400 Received: from verein.lst.de ([213.95.11.211]:46143 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhCSNKQ (ORCPT ); Fri, 19 Mar 2021 09:10:16 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3E99C68BFE; Fri, 19 Mar 2021 14:10:12 +0100 (CET) Date: Fri, 19 Mar 2021 14:10:11 +0100 From: Christoph Hellwig To: Ricardo Ribalda Cc: Christoph Hellwig , Mauro Carvalho Chehab , Marek Szyprowski , Tomasz Figa , Sergey Senozhatsky , Laurent Pinchart , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Robin Murphy , Linux Kernel Mailing List , Linux Media Mailing List Subject: Re: [PATCH v4 6/6] media: uvcvideo: Use dma_alloc_noncontiguous API Message-ID: <20210319131011.GA3372@lst.de> References: <20210312235521.1408503-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Mar 19, 2021 at 02:05:21PM +0100, Ricardo Ribalda wrote: > > + uvc_urb->sgt, > > + uvc_stream_dir(uvc_urb->stream)); > > + return usb_submit_urb(uvc_urb->urb, GFP_KERNEL); > > +} > > We should have mem_flags instead of GFP_KERNEL here > > > Is it too late to fix it in your tree? Do I need to send a patch to fix it? As far as I know we don't have anything that has pulled in the tree yet, so I can just fold the fix in.