From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6574935248915171513==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] printk: fix returnvar.cocci warnings Date: Sat, 20 Mar 2021 13:22:39 +0800 Message-ID: <20210320052238.GA145070@b88dfbd5dd5f> In-Reply-To: <202103201327.GiEajyhA-lkp@intel.com> List-Id: --===============6574935248915171513== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot kernel/printk/printk.c:2195:5-8: Unneeded variable: "ret". Return "- ENOMEM= " on line 2300 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: 44b90e30fdd3 ("printk: move console printing to kthreads") CC: John Ogness Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.g= it linux-5.12.y-rt-rebase head: 2664a7f5d3d24da4b2657a1e933181d376b77616 commit: 44b90e30fdd3fbb4997b8d75679816678214efb5 [32/193] printk: move cons= ole printing to kthreads printk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2192,7 +2192,6 @@ static int printk_kthread_func(void *dat struct printk_record r; char *ext_text =3D NULL; size_t dropped_len; - int ret =3D -ENOMEM; char *text =3D NULL; char *write_text; size_t len; @@ -2297,7 +2296,7 @@ out: pr_info("%sconsole [%s%d]: printing thread stopped\n", (con->flags & CON_BOOT) ? "boot" : "", con->name, con->index); - return ret; + return -ENOMEM; } = /* Must be called within console_lock(). */ --===============6574935248915171513==--