From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH mac80211-next v6] mac80211: Switch to a virtual time-based airtime scheduler
Date: Sat, 20 Mar 2021 08:29:03 +0800 [thread overview]
Message-ID: <202103200814.UIN6eVVs-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 6964 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210318213142.138707-1-toke@redhat.com>
References: <20210318213142.138707-1-toke@redhat.com>
TO: "Toke Høiland-Jørgensen" <toke@redhat.com>
TO: linux-wireless(a)vger.kernel.org
CC: "Toke Høiland-Jørgensen" <toke@redhat.com>
CC: make-wifi-fast(a)lists.bufferbloat.net
CC: Felix Fietkau <nbd@nbd.name>
CC: Rajkumar Manoharan <rmanohar@codeaurora.org>
CC: Kan Yan <kyan@google.com>
CC: Yibo Zhao <yiboz@codeaurora.org>
Hi "Toke,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mac80211-next/master]
url: https://github.com/0day-ci/linux/commits/Toke-H-iland-J-rgensen/mac80211-Switch-to-a-virtual-time-based-airtime-scheduler/20210319-053617
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
:::::: branch date: 27 hours ago
:::::: commit date: 27 hours ago
config: mips-randconfig-s032-20210318 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-277-gc089cd2d-dirty
# https://github.com/0day-ci/linux/commit/23d429aa540736e04237eb11c63c03d929653774
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Toke-H-iland-J-rgensen/mac80211-Switch-to-a-virtual-time-based-airtime-scheduler/20210319-053617
git checkout 23d429aa540736e04237eb11c63c03d929653774
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
command-line: note: in included file:
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
builtin:0:0: sparse: this was the original definition
>> net/mac80211/tx.c:3999:6: sparse: sparse: context imbalance in 'ieee80211_txq_may_transmit' - wrong count at exit
vim +/ieee80211_txq_may_transmit +3999 net/mac80211/tx.c
3ace10f5b5ad94 Kan Yan 2019-11-18 3998
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 @3999 bool ieee80211_txq_may_transmit(struct ieee80211_hw *hw,
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4000 struct ieee80211_txq *txq)
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4001 {
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4002 struct txq_info *first_txqi = NULL, *txqi = to_txq_info(txq);
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4003 struct ieee80211_local *local = hw_to_local(hw);
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4004 struct airtime_sched_info *air_sched;
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4005 struct airtime_info *air_info;
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4006 struct rb_node *node = NULL;
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4007 bool ret = false;
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4008 u64 now;
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4009
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4010
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4011 if (!ieee80211_txq_airtime_check(hw, txq))
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4012 return false;
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4013
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4014 air_sched = &local->airtime[txq->ac];
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4015 spin_lock_bh(&air_sched->lock);
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4016
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4017 if (RB_EMPTY_NODE(&txqi->schedule_order))
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4018 goto out;
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4019
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4020 now = ktime_get_boottime_ns();
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4021
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4022 /* Like in ieee80211_next_txq(), make sure the first station in the
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4023 * scheduling order is eligible for transmission to avoid starvation.
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4024 */
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4025 node = rb_first_cached(&air_sched->active_txqs);
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4026 if (node) {
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4027 first_txqi = container_of(node, struct txq_info,
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4028 schedule_order);
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4029 air_info = to_airtime_info(&first_txqi->txq);
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4030
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4031 if (air_sched->v_t < air_info->v_t)
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4032 airtime_catchup_v_t(air_sched, air_info->v_t, now);
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4033 }
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4034
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4035 air_info = to_airtime_info(&txqi->txq);
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4036 if (air_info->v_t <= air_sched->v_t) {
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4037 air_sched->last_schedule_activity = now;
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4038 ret = true;
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4039 }
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4040
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4041 spin_unlock_bh(&air_sched->lock);
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4042 out:
23d429aa540736 Toke Høiland-Jørgensen 2021-03-18 4043 return ret;
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4044 }
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4045 EXPORT_SYMBOL(ieee80211_txq_may_transmit);
b4809e9484da14 Toke Høiland-Jørgensen 2018-12-18 4046
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 25280 bytes --]
next reply other threads:[~2021-03-20 0:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 0:29 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-18 21:31 [PATCH mac80211-next v6] mac80211: Switch to a virtual time-based airtime scheduler Toke Høiland-Jørgensen
2021-03-18 21:57 ` Felix Fietkau
2021-03-18 22:55 ` Toke Høiland-Jørgensen
2021-03-31 15:07 ` Toke Høiland-Jørgensen
2021-03-18 23:31 ` kernel test robot
2021-03-18 23:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103200814.UIN6eVVs-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.