Re: [PATCH v2 4/4] clk: bcm: Add BCM63268 timer clock and reset driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2968 bytes --]

Hi "Álvaro,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on robh/for-next pza/reset/next v5.12-rc3 next-20210319]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/clk-add-BCM63268-timer-clock-and-reset/20210315-202837
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f163044e385e4769e7b9c8ea16f34575f3db4516
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review lvaro-Fern-ndez-Rojas/clk-add-BCM63268-timer-clock-and-reset/20210315-202837
        git checkout f163044e385e4769e7b9c8ea16f34575f3db4516
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/clk/bcm/clk-bcm63268-timer.c: In function 'bcm63268_timer_reset_update':
>> drivers/clk/bcm/clk-bcm63268-timer.c:89:8: error: implicit declaration of function '__raw_readl'; did you mean '__raw_read_lock'? [-Werror=implicit-function-declaration]
      89 |  val = __raw_readl(reset->regs);
         |        ^~~~~~~~~~~
         |        __raw_read_lock
>> drivers/clk/bcm/clk-bcm63268-timer.c:94:2: error: implicit declaration of function '__raw_writel'; did you mean '__raw_write_lock'? [-Werror=implicit-function-declaration]
      94 |  __raw_writel(val, reset->regs);
         |  ^~~~~~~~~~~~
         |  __raw_write_lock
   cc1: some warnings being treated as errors


vim +89 drivers/clk/bcm/clk-bcm63268-timer.c

    80	
    81	static int bcm63268_timer_reset_update(struct reset_controller_dev *rcdev,
    82					unsigned long id, bool assert)
    83	{
    84		struct bcm63268_tclkrst_hw *reset = to_bcm63268_timer_reset(rcdev);
    85		unsigned long flags;
    86		uint32_t val;
    87	
    88		spin_lock_irqsave(&reset->lock, flags);
  > 89		val = __raw_readl(reset->regs);
    90		if (assert)
    91			val &= ~BIT(id);
    92		else
    93			val |= BIT(id);
  > 94		__raw_writel(val, reset->regs);
    95		spin_unlock_irqrestore(&reset->lock, flags);
    96	
    97		return 0;
    98	}
    99	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 77622 bytes --]