All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v5 2/2] drm: bridge: cdns-mhdp8546: Enable HDCP
Date: Sat, 20 Mar 2021 15:34:51 +0800	[thread overview]
Message-ID: <202103201535.SAevwNYa-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3964 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <1616146736-7423-1-git-send-email-pthombar@cadence.com>
References: <1616146736-7423-1-git-send-email-pthombar@cadence.com>
TO: Parshuram Thombare <pthombar@cadence.com>
TO: robert.foss(a)linaro.org
TO: robh+dt(a)kernel.org
TO: laurent.pinchart(a)ideasonboard.com
TO: airlied(a)linux.ie
TO: daniel(a)ffwll.ch
CC: dri-devel(a)lists.freedesktop.org
CC: devicetree(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
CC: a.hajda(a)samsung.com
CC: narmstrong(a)baylibre.com

Hi Parshuram,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linux/master linus/master v5.12-rc3 next-20210319]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Parshuram-Thombare/enable-HDCP-in-Cadence-MHDP-bridge-driver/20210319-174219
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
:::::: branch date: 22 hours ago
:::::: commit date: 22 hours ago
config: i386-randconfig-m021-20210320 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c:426 _cdns_mhdp_hdcp_enable() error: uninitialized symbol 'ret'.

vim +/ret +426 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c

e222d14a2c434cd Parshuram Thombare 2021-03-19  403  
e222d14a2c434cd Parshuram Thombare 2021-03-19  404  static int _cdns_mhdp_hdcp_enable(struct cdns_mhdp_device *mhdp, u8 content_type)
e222d14a2c434cd Parshuram Thombare 2021-03-19  405  {
e222d14a2c434cd Parshuram Thombare 2021-03-19  406  	int ret, tries = 3;
e222d14a2c434cd Parshuram Thombare 2021-03-19  407  	u32 i;
e222d14a2c434cd Parshuram Thombare 2021-03-19  408  
e222d14a2c434cd Parshuram Thombare 2021-03-19  409  	for (i = 0; i < tries; i++) {
e222d14a2c434cd Parshuram Thombare 2021-03-19  410  		if (content_type == DRM_MODE_HDCP_CONTENT_TYPE0 ||
e222d14a2c434cd Parshuram Thombare 2021-03-19  411  		    content_type == DRM_MODE_HDCP_CONTENT_TYPE1) {
e222d14a2c434cd Parshuram Thombare 2021-03-19  412  			ret = cdns_mhdp_hdcp_auth(mhdp, HDCP_TX_2);
e222d14a2c434cd Parshuram Thombare 2021-03-19  413  			if (!ret)
e222d14a2c434cd Parshuram Thombare 2021-03-19  414  				return 0;
e222d14a2c434cd Parshuram Thombare 2021-03-19  415  			_cdns_mhdp_hdcp_disable(mhdp);
e222d14a2c434cd Parshuram Thombare 2021-03-19  416  		}
e222d14a2c434cd Parshuram Thombare 2021-03-19  417  
e222d14a2c434cd Parshuram Thombare 2021-03-19  418  		if (content_type == DRM_MODE_HDCP_CONTENT_TYPE0) {
e222d14a2c434cd Parshuram Thombare 2021-03-19  419  			ret = cdns_mhdp_hdcp_auth(mhdp, HDCP_TX_1);
e222d14a2c434cd Parshuram Thombare 2021-03-19  420  			if (!ret)
e222d14a2c434cd Parshuram Thombare 2021-03-19  421  				return 0;
e222d14a2c434cd Parshuram Thombare 2021-03-19  422  			_cdns_mhdp_hdcp_disable(mhdp);
e222d14a2c434cd Parshuram Thombare 2021-03-19  423  		}
e222d14a2c434cd Parshuram Thombare 2021-03-19  424  	}
e222d14a2c434cd Parshuram Thombare 2021-03-19  425  
e222d14a2c434cd Parshuram Thombare 2021-03-19 @426  	dev_err(mhdp->dev, "HDCP authentication failed (%d tries/%d)\n",
e222d14a2c434cd Parshuram Thombare 2021-03-19  427  		tries, ret);
e222d14a2c434cd Parshuram Thombare 2021-03-19  428  
e222d14a2c434cd Parshuram Thombare 2021-03-19  429  	return ret;
e222d14a2c434cd Parshuram Thombare 2021-03-19  430  }
e222d14a2c434cd Parshuram Thombare 2021-03-19  431  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35238 bytes --]

             reply	other threads:[~2021-03-20  7:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20  7:34 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-19  9:37 [PATCH v5 0/2] enable HDCP in Cadence MHDP bridge driver Parshuram Thombare
2021-03-19  9:38 ` [PATCH v5 2/2] drm: bridge: cdns-mhdp8546: Enable HDCP Parshuram Thombare
2021-03-19  9:38   ` Parshuram Thombare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202103201535.SAevwNYa-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.