From: Ingo Molnar <mingo@kernel.org>
To: Randy Dunlap <rdunlap@bombadil.infradead.org>
Cc: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: A typo fix
Date: Sun, 21 Mar 2021 23:54:28 +0100 [thread overview]
Message-ID: <20210321225428.GA1885130@gmail.com> (raw)
In-Reply-To: <f9d4429-d594-8898-935a-e222bb8c247@bombadil.infradead.org>
* Randy Dunlap <rdunlap@bombadil.infradead.org> wrote:
>
>
> On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote:
>
> >
> > s/resued/resumed/
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
>
> > ---
> > arch/x86/include/asm/kvm_host.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> > index 9bc091ecaaeb..eae82551acb1 100644
> > --- a/arch/x86/include/asm/kvm_host.h
> > +++ b/arch/x86/include/asm/kvm_host.h
> > @@ -1470,7 +1470,7 @@ extern u64 kvm_mce_cap_supported;
> > /*
> > * EMULTYPE_NO_DECODE - Set when re-emulating an instruction (after completing
> > * userspace I/O) to indicate that the emulation context
> > - * should be resued as is, i.e. skip initialization of
> > + * should be resumed as is, i.e. skip initialization of
> > * emulation context, instruction fetch and decode.
This is the *wrong* fix, the correct word in this context is 'reused',
not 'resumed' ...
See how I fixed most arch/x86/ typo fixes in tip:x86/cleanups:
d9f6e12fb0b7: ("x86: Fix various typos in comments")
163b099146b8: ("x86: Fix various typos in comments, take #2")
These single file typo fixes are a bad idea for another reason as
well, as they create a lot of unnecessary churn.
Thanks,
Ingo
next prev parent reply other threads:[~2021-03-21 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 19:04 [PATCH] KVM: x86: A typo fix Bhaskar Chowdhury
2021-03-20 19:12 ` Randy Dunlap
2021-03-21 22:54 ` Ingo Molnar [this message]
2021-03-22 5:29 ` Bhaskar Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210321225428.GA1885130@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rdunlap@bombadil.infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=unixbhaskar@gmail.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.