All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kunal Joshi <kunal1.joshi@intel.com>
To: Martin Peres <martin.peres@mupuf.org>,
	igt-dev@lists.freedesktop.org, petri.latvala@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_kms: only check chamelium's presence in chamelium tests
Date: Mon, 22 Mar 2021 12:59:23 +0530	[thread overview]
Message-ID: <20210322072923.GA20972@intel.com> (raw)
In-Reply-To: <f3a01f1b-3805-2ee8-866c-daa9086c893b@mupuf.org>

On 2021-03-22 at 08:29:02 +0200, Martin Peres wrote:
> On 22/03/2021 07:26, Kunal Joshi wrote:
> > Avoid checking if chamelium is present or not in non chamelium
> > tests as its just an overhead.
> 
> The point of doing this was to stop having screens in CI and instead mostly
> have chameliums. This means that we need to make sure the chamelium exposes
> all the ports before starting a KMS test, since some tests may have left the
> screens disconnected.
> 
> Is that making sense?

Thanks martin for having a look and yeah i got your point,

But for checking all the ports are connected we can have a script which
checks it before the execution starts rather than checking it everytime

Currently when chamelium is not reachable we get SIGQUIT on all the
tests

Starting subtest: basic-fence-flip
Received signal SIGQUIT.
Stack trace:
#0 [fatal_sig_handler+0xd6]
#1 [killpg+0x40]
#2 [pselect+0x59]
#3 [xmlrpc_server_info_disallow_auth_ntlm+0x389]
#4 [xmlrpc_server_info_disallow_auth_ntlm+0x786]
#5 [xmlrpc_server_info_disallow_auth_ntlm+0xd1f]
#6 [xmlrpc_client_call2+0xa8]
#7 [xmlrpc_client_call2f_va+0x9e]
#8 [__chamelium_rpc_va+0x87]
#9 [__chamelium_rpc.constprop.8+0x8c]
#10 [chamelium_wait_reachable+0x65]
#11 [igt_display_require+0xbe]
#12 [test_flip+0x4b]
#13 [__real_main1093+0x1c38]
#14 [main+0x27]
#15 [__libc_start_main+0xe7]
#16 [_start+0x2a]

When chamelium is not reachable chamelium_wait_reachable() never returns
back and we have inactivity timeout which kills the test.

Regards
Kunal Joshi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-03-22  7:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22  5:26 [igt-dev] [PATCH i-g-t] lib/igt_kms: only check chamelium's presence in chamelium tests Kunal Joshi
2021-03-22  6:29 ` Martin Peres
2021-03-22  7:29   ` Kunal Joshi [this message]
2021-03-22  8:16     ` Martin Peres
2021-03-22  8:39       ` Kunal Joshi
2021-03-22  8:50         ` Martin Peres
2021-03-22  8:21     ` Petri Latvala
2021-03-22  6:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-03-22  7:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322072923.GA20972@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=martin.peres@mupuf.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.