All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Chi <chi962464zy@163.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	lars@metafoo.de, Michael.Hennerich@analog.com,
	marcelo.schmitt1@gmail.com, pmeerw@pmeerw.net,
	chiguoqing@yulong.com
Subject: Re: [PATCH] iio: adc: ad7292: Modify the bool initialization assignment
Date: Mon, 22 Mar 2021 09:42:19 +0800	[thread overview]
Message-ID: <20210322094219.000046d4@163.com> (raw)
In-Reply-To: <20210320150730.67635739@jic23-huawei>

On Sat, 20 Mar 2021 15:07:30 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Fri, 19 Mar 2021 14:27:06 +0800
> Guoqing chi <chi962464zy@163.com> wrote:
> 
> > From: Guoqing Chi <chiguoqing@yulong.com>
> > 
> > A bool initializer is best assigned to false rather than 0.
> > 
> > Signed-off-by: Guoqing Chi <chiguoqing@yulong.com>  
> 
> Hi
> 
> This one is a bit marginal as counting as noise rather that a useful
> change in an existing driver. I'll take it this time, but I'm not
> keen to see lots of these unless they form part of larger sets
> cleaning up the drivers in question.
> 
> Applied to the togreg branch of iio.git and pushed out as testing for
> the auto builders to ignore it.
> 
> thanks,
> 
> Jonathan

Hi Jonathan

Okay, I'll be mindful of that.
Thanks for your advice.

Thanks.

> 
> > ---
> >  drivers/iio/adc/ad7292.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c
> > index 70e33dd1c9f7..3271a31afde1 100644
> > --- a/drivers/iio/adc/ad7292.c
> > +++ b/drivers/iio/adc/ad7292.c
> > @@ -260,7 +260,7 @@ static int ad7292_probe(struct spi_device *spi)
> >  	struct ad7292_state *st;
> >  	struct iio_dev *indio_dev;
> >  	struct device_node *child;
> > -	bool diff_channels = 0;
> > +	bool diff_channels = false;
> >  	int ret;
> >  
> >  	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> >  


      reply	other threads:[~2021-03-22  1:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  6:27 [PATCH] iio: adc: ad7292: Modify the bool initialization assignment Guoqing chi
2021-03-20 14:21 ` Marcelo Schmitt
2021-03-20 15:07 ` Jonathan Cameron
2021-03-22  1:42   ` Guoqing Chi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322094219.000046d4@163.com \
    --to=chi962464zy@163.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=chiguoqing@yulong.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.