From: Jason Gunthorpe <jgg@nvidia.com>
To: Gal Pressman <galpress@amazon.com>
Cc: Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, Firas JahJah <firasj@amazon.com>,
Yossi Leybovich <sleybo@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Use strscpy instead of strlcpy
Date: Mon, 22 Mar 2021 10:01:31 -0300 [thread overview]
Message-ID: <20210322130131.GC247894@nvidia.com> (raw)
In-Reply-To: <20210316132416.83578-1-galpress@amazon.com>
On Tue, Mar 16, 2021 at 03:24:16PM +0200, Gal Pressman wrote:
> The strlcpy function doesn't limit the source length, use the preferred
> strscpy function instead.
Why do we need to limit the source length here? Either this is a bug
because the source string is no NULL terminated or it is OK as is?
Jason
next prev parent reply other threads:[~2021-03-22 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 13:24 [PATCH for-next] RDMA/efa: Use strscpy instead of strlcpy Gal Pressman
2021-03-22 13:01 ` Jason Gunthorpe [this message]
2021-03-22 13:11 ` Gal Pressman
2021-03-22 16:55 ` Jason Gunthorpe
2021-03-22 17:14 ` Gal Pressman
2021-03-23 0:21 ` Jason Gunthorpe
2021-03-29 7:04 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322130131.GC247894@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=firasj@amazon.com \
--cc=galpress@amazon.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.