All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: dev-next - tests: avoid leaking unkilled commands
Date: Mon, 22 Mar 2021 15:39:07 +0000 (GMT)	[thread overview]
Message-ID: <20210322153907.161F93854808@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=583cf413d530927bccf2b7a11f3d5690edca4f8d
Commit:        583cf413d530927bccf2b7a11f3d5690edca4f8d
Parent:        fda7bc1297640d739067727b6165cde0613d1fe3
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Wed Mar 17 00:44:45 2021 +0100
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Wed Mar 17 00:59:50 2021 +0100

tests: avoid leaking unkilled commands

Between each new test here we want to kill previous commands,
otherwise they will influence results of next test.
---
 test/shell/pvmove-resume-multiseg.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/test/shell/pvmove-resume-multiseg.sh b/test/shell/pvmove-resume-multiseg.sh
index a8e409f56..3a92dbaf3 100644
--- a/test/shell/pvmove-resume-multiseg.sh
+++ b/test/shell/pvmove-resume-multiseg.sh
@@ -78,6 +78,9 @@ test_pvmove_resume() {
 		aux prepare_clvmd
 	fi
 
+##	rm -f debug.log_DEBUG*
+#	lvs -ao+devices  $vg
+
 	# call resume function (see below)
 	# with expected number of spawned
 	# bg polling as parameter
@@ -153,7 +156,7 @@ pvmove_fg() {
 	aux enable_dev "$dev4"
 	aux enable_dev "$dev5"
 
-	pvmove
+	LVM_TEST_TAG="kill_me_$PREFIX" pvmove
 }
 
 pvmove_bg() {
@@ -198,8 +201,8 @@ pvmove_fg_single() {
 	aux enable_dev "$dev4"
 	aux enable_dev "$dev5"
 
-	pvmove "$dev1"
-	pvmove "$dev3"
+	LVM_TEST_TAG="kill_me_$PREFIX" pvmove "$dev1"
+	LVM_TEST_TAG="kill_me_$PREFIX" pvmove "$dev3"
 }
 
 pvmove_bg_single() {



                 reply	other threads:[~2021-03-22 15:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322153907.161F93854808@sourceware.org \
    --to=teigland@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.