Re: [EXTERNAL] Re: [meta-ti][dunfell/master][PATCH v2] ti-sci-fw: Update J7200 deploy to install ti-sci-fw

["Denys Dmytriyenko" <denis@denix.org>]

On Mon, Mar 22, 2021 at 11:54:10AM -0500, Weaver, Lucas wrote:
> 
> 
> On 3/22/2021 11:21 AM, Denys Dmytriyenko wrote:
> >On Mon, Mar 22, 2021 at 09:37:06PM +0530, l-weaver via lists.yoctoproject.org wrote:
> >>From: Lucas Weaver <l-weaver@ti.com>
> >>
> >>The J7200 ti-sci-fw needs to be installed in the deploy
> >>directory so that it can be packaged in Processor SDK bundle
> >>
> >>This is required because the ti-sci-fw is needed in the
> >>installer prebuilt-images in order to build the combined boot
> >>image for J7200
> >>
> >>Signed-off-by: Lucas Weaver <l-weaver@ti.com>
> >>---
> >>  recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >>diff --git a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >>index e7580a57..25fac359 100644
> >>--- a/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >>+++ b/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb
> >>@@ -99,6 +99,7 @@ do_deploy_j7200-evm-k3r5() {
> >>  	install -m 644 ${WORKDIR}/imggen/${UBOOT_BINARY} ${DEPLOYDIR}/${UBOOT_IMAGE}
> >>  	ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK}
> >>  	ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_BINARY}
> >>+	install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/
> >
> >This is already done for all platforms:
> >
> >https://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb#n87
> >
> >do_deploy () {
> >	...
> >
> >	install -m 644 ${SYSFW_TISCI} ${DEPLOYDIR}/
> >}
> >
> >
> From my understanding, I thought that the do_deploy_j7200-evm-k3r5
> shown below will overwrite the do_deploy task for the j7200-evm-k3r5
> platform.  This was seemingly confirmed when I tried to bundle the
> ti-sci-fw for J7200 in the Processor SDK bundle but this file was
> not found.  After adding the change from this patch, the bundle step
> succeeded.  Could you please clarify my understanding?

Ah, you are right. I somehow misread those as appends and not complete 
overrides. In that case your change is correct.

I just wonder if the same change is needed for am64x platforms. And that 
portion of the code needs some unification and cleanup...


> https://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-bsp/ti-sci-fw/ti-sci-fw_git.bb#n97
> 
> 
> do_deploy_j7200-evm-k3r5() {
> 	install -d ${DEPLOYDIR}
> 	install -m 644 ${WORKDIR}/imggen/${UBOOT_BINARY}
> ${DEPLOYDIR}/${UBOOT_IMAGE}
> 	ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_SYMLINK}
> 	ln -sf ${UBOOT_IMAGE} ${DEPLOYDIR}/${UBOOT_BINARY}
> }
> >>  }
> >>  do_install_am64xx-evm-k3r5() {
> >>-- 
> >>2.17.1
> >>
> 

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964