From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB255C433E4 for ; Tue, 23 Mar 2021 09:41:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F156619CA for ; Tue, 23 Mar 2021 09:41:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbhCWJkz (ORCPT ); Tue, 23 Mar 2021 05:40:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbhCWJkr (ORCPT ); Tue, 23 Mar 2021 05:40:47 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFE5BC0613D8 for ; Tue, 23 Mar 2021 02:40:46 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id l4so25953569ejc.10 for ; Tue, 23 Mar 2021 02:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zXs5SbjReTCcPNHIOjgz/S/VxQjjjOm2F5VH26PFX/A=; b=vj5G9pjhGIJnSvkO3MxGjzGfY8QUgcgIr8he+j8CuGbyyEfP5EQNfrmrCqoMO2CZZR bdckdLSvsCoLrRu48EzAHYo4oxQAXRsUdNra/JouZ1qUvhf0uMbOSV9a8F/maOBLtAGe RV8MmfA3GtVVlaVinDJ3S/lzsL0qE8O+YupeIpqcYG0BGXJHE1Cmp6/9QWlQ43zL/NC1 yqNdlWiaSh5Wv3ibiPp3WlVe3b07LVjSxW+cyyrOQWmSgGZNcN5r0izAQP2icBVact0v 03lDSR3Wp+6bfpj+WhlvsvC7QM5dX/IjE1uKpWf59cRSsmbH828i6f8T/ahuVCQ1UXlk uGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zXs5SbjReTCcPNHIOjgz/S/VxQjjjOm2F5VH26PFX/A=; b=afYN/s5Meoq/h6feyMELm+IpDla+/6mtaDrx2ooL5nbHrewnVpnXyar1YWeuajUjIZ fsWa0UlEFRSNNpv5g3+4WKpTzyWx+gYLDYvOQomB9NXAYPYnh/4Epp7FVJ8sm8E48nlv aSTowS5fLCkgTRR5KrGW8zLEomUdZom6ypD/MHh/CS4BSh0RBKrVLSdbJTJFJBmWBiSN lFJnETJsiM2UjOnK7pP8BLarRJY2ZQLaaECZtuDDAgRkkxdKymjhAazhFWLUUTN2uGvw g5bDEZNFaF+16y4iY3WwJ5QxJxEQ1sc/rxGu/B4e6mEV0FJNoNGO7OrwEsuqi9f5PtSZ rhwg== X-Gm-Message-State: AOAM532bhSKo4tGUmJ1nmb/6apKCP4AGPJVEry+FhpK+O6q4raDO6Yvv AidqGJUdCqI34zkULV+jFYZkQA== X-Google-Smtp-Source: ABdhPJwpBn5eyAJHqJLdU0Wab+Ro1IIWRDZ1hGuA1iPJeA/Fp0ww4Ebsg8Pw9LsY5dn4holDmh/FWw== X-Received: by 2002:a17:906:53d7:: with SMTP id p23mr4111539ejo.140.1616492445327; Tue, 23 Mar 2021 02:40:45 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id 90sm12948482edf.31.2021.03.23.02.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 02:40:44 -0700 (PDT) Date: Tue, 23 Mar 2021 09:40:41 +0000 From: Lee Jones To: Kiran Gunda Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH V5 2/2] backlight: qcom-wled: Correct the sync_toggle sequence Message-ID: <20210323094041.GT2916463@dell> References: <1616071180-24493-1-git-send-email-kgunda@codeaurora.org> <1616071180-24493-3-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1616071180-24493-3-git-send-email-kgunda@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 18 Mar 2021, Kiran Gunda wrote: > As per the current implementation, after FSC (Full Scale Current) > and brightness update the sync bits are set-then-cleared. > But, the FSC and brightness sync takes place when the sync bits are > set (e.g. on a rising edge). So the hardware team recommends a > clear-then-set approach in order to guarantee such a transition > regardless of the previous register state. > > Signed-off-by: Kiran Gunda > Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/qcom-wled.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D7B8C433DB for ; Tue, 23 Mar 2021 09:40:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4BE5619B8 for ; Tue, 23 Mar 2021 09:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4BE5619B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BA3B6E87C; Tue, 23 Mar 2021 09:40:48 +0000 (UTC) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by gabe.freedesktop.org (Postfix) with ESMTPS id A63606E87D for ; Tue, 23 Mar 2021 09:40:46 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id r12so25977797ejr.5 for ; Tue, 23 Mar 2021 02:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zXs5SbjReTCcPNHIOjgz/S/VxQjjjOm2F5VH26PFX/A=; b=vj5G9pjhGIJnSvkO3MxGjzGfY8QUgcgIr8he+j8CuGbyyEfP5EQNfrmrCqoMO2CZZR bdckdLSvsCoLrRu48EzAHYo4oxQAXRsUdNra/JouZ1qUvhf0uMbOSV9a8F/maOBLtAGe RV8MmfA3GtVVlaVinDJ3S/lzsL0qE8O+YupeIpqcYG0BGXJHE1Cmp6/9QWlQ43zL/NC1 yqNdlWiaSh5Wv3ibiPp3WlVe3b07LVjSxW+cyyrOQWmSgGZNcN5r0izAQP2icBVact0v 03lDSR3Wp+6bfpj+WhlvsvC7QM5dX/IjE1uKpWf59cRSsmbH828i6f8T/ahuVCQ1UXlk uGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zXs5SbjReTCcPNHIOjgz/S/VxQjjjOm2F5VH26PFX/A=; b=rsNp2und4F0+uVnd7wdJ0IOQnAclqHoCjrQpF7IhER+of/SZ2ZZ1me3qL7jfxbub+r VuIV03uqGEHFHWsKqWcG0uKPRUfddxMsSm3JytYDEGnTLCUgrO/TcNnZCHpkfqoPSkH7 +pMYpU2rwd0SYJNOStrmEZYTpCbQzpBo1zMmT/Svs0hgIByhJns15WMhk4FrpsiwGDYW xFZYluCDmB6AFrmXmERSyFMpRocTccX23HIjmDjNmi4ecZk7R3at5/FNH+GAReW8NkqV R7I0P/VPlXLGbua32LWyrTQStHnR94qWVKw3BTx+U5uCp0F26GsS1u/h+lLr5xA/YHD+ f+zA== X-Gm-Message-State: AOAM530f7fRzxhC0bk2KY08zQlm67kKMXQpk6NnLXTM1/BOVGlR2+07j c84YsDCljPgWB2zUpQhcSLUKiQ== X-Google-Smtp-Source: ABdhPJwpBn5eyAJHqJLdU0Wab+Ro1IIWRDZ1hGuA1iPJeA/Fp0ww4Ebsg8Pw9LsY5dn4holDmh/FWw== X-Received: by 2002:a17:906:53d7:: with SMTP id p23mr4111539ejo.140.1616492445327; Tue, 23 Mar 2021 02:40:45 -0700 (PDT) Received: from dell ([91.110.221.180]) by smtp.gmail.com with ESMTPSA id 90sm12948482edf.31.2021.03.23.02.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 02:40:44 -0700 (PDT) Date: Tue, 23 Mar 2021 09:40:41 +0000 From: Lee Jones To: Kiran Gunda Subject: Re: [PATCH V5 2/2] backlight: qcom-wled: Correct the sync_toggle sequence Message-ID: <20210323094041.GT2916463@dell> References: <1616071180-24493-1-git-send-email-kgunda@codeaurora.org> <1616071180-24493-3-git-send-email-kgunda@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1616071180-24493-3-git-send-email-kgunda@codeaurora.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, daniel.thompson@linaro.org, b.zolnierkie@samsung.com, jingoohan1@gmail.com, Andy Gross , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, linux-fbdev@vger.kernel.org, robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, linux-leds@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCAxOCBNYXIgMjAyMSwgS2lyYW4gR3VuZGEgd3JvdGU6Cgo+IEFzIHBlciB0aGUgY3Vy cmVudCBpbXBsZW1lbnRhdGlvbiwgYWZ0ZXIgRlNDIChGdWxsIFNjYWxlIEN1cnJlbnQpCj4gYW5k IGJyaWdodG5lc3MgdXBkYXRlIHRoZSBzeW5jIGJpdHMgYXJlIHNldC10aGVuLWNsZWFyZWQuCj4g QnV0LCB0aGUgRlNDIGFuZCBicmlnaHRuZXNzIHN5bmMgdGFrZXMgcGxhY2Ugd2hlbiB0aGUgc3lu YyBiaXRzIGFyZQo+IHNldCAoZS5nLiBvbiBhIHJpc2luZyBlZGdlKS4gU28gdGhlIGhhcmR3YXJl IHRlYW0gcmVjb21tZW5kcyBhCj4gY2xlYXItdGhlbi1zZXQgYXBwcm9hY2ggaW4gb3JkZXIgdG8g Z3VhcmFudGVlIHN1Y2ggYSB0cmFuc2l0aW9uCj4gcmVnYXJkbGVzcyBvZiB0aGUgcHJldmlvdXMg cmVnaXN0ZXIgc3RhdGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogS2lyYW4gR3VuZGEgPGtndW5kYUBj b2RlYXVyb3JhLm9yZz4KPiBSZXZpZXdlZC1ieTogRGFuaWVsIFRob21wc29uIDxkYW5pZWwudGhv bXBzb25AbGluYXJvLm9yZz4KPiAtLS0KPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcWNvbS13 bGVkLmMgfCAxMiArKysrKystLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygr KSwgNiBkZWxldGlvbnMoLSkKCkFwcGxpZWQsIHRoYW5rcy4KCi0tIApMZWUgSm9uZXMgW+adjueQ vOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5v cmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBG YWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=