All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - tests: wipefs with udev_wait
Date: Tue, 23 Mar 2021 20:36:05 +0000 (GMT)	[thread overview]
Message-ID: <20210323203605.2B23D3857829@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=93f2d194aca4a589cd38dd8bdd99cad2945dd21c
Commit:        93f2d194aca4a589cd38dd8bdd99cad2945dd21c
Parent:        14a3c34983fa8ab99773a47f1ee8bdd02d84feef
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Tue Mar 23 14:57:10 2021 +0100
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Tue Mar 23 14:57:10 2021 +0100

tests: wipefs with udev_wait

Try to synchronize with colliding udev.
Also retry once if there is some failure with some
sleep between next retry.

Use oflag=direct for wipping without wipefs.
---
 test/lib/aux.sh | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/test/lib/aux.sh b/test/lib/aux.sh
index 20736260f..386918041 100644
--- a/test/lib/aux.sh
+++ b/test/lib/aux.sh
@@ -818,10 +818,16 @@ wipefs_a() {
 		echo "$have_wipefs" > HAVE_WIPEFS
 	fi
 
+	udev_wait
 	if [ "$have_wipefs" = "1" ] ; then
-		wipefs -a "$dev"
+		wipefs -a "$dev" || {
+			echo "$dev: device in-use, retrying wipe again."
+			sleep 1
+			udev_wait
+			wipefs -a "$dev"
+		}
 	else
-		dd if=/dev/zero of="$dev" bs=4096 count=8 >/dev/null || true
+		dd if=/dev/zero of="$dev" bs=4096 count=8 oflag=direct >/dev/null || true
 		mdadm --zero-superblock "$dev" 2>/dev/null || true
 	fi
 



                 reply	other threads:[~2021-03-23 20:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323203605.2B23D3857829@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.