From: Sergei Shtepa <sergei.shtepa@veeam.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <pavel.tide@veeam.com>
Subject: Re: [PATCH 1/1] block: fix potential infinite loop in the negative branch in __submit_bio_noacct_mq()
Date: Wed, 24 Mar 2021 18:14:05 +0300 [thread overview]
Message-ID: <20210324151405.GA4260@veeam.com> (raw)
In-Reply-To: <20210324111803.GA2687609@infradead.org>
The 03/24/2021 11:18, Christoph Hellwig wrote:
> On Tue, Mar 23, 2021 at 02:48:36PM +0300, Sergei Shtepa wrote:
> > When the blk_crypto_bio_prep() function returns false, the processing
> > of the bio request must end. Repeated access to blk_crypto_bio_prep()
> > for this same bio may lead to access to already released data, since in
> > this case the bio_endio() function was already called for bio.
> >
> > The changes allow to leave the processing of the failed bio and
> > go to the next one from the bio_list.
> >
> > The error can only occur when using inline encryption on
> > request-based blk-mq devices and something went wrong in the
> > __blk_crypto_bio_prep().
>
> A continue in a do { } while statement evaluates the while condition,
> so your patch is a no-op.
Thank you Christoph!
Shame on my bald head.
I apologize and will be more attentive in the future.
--
Sergei Shtepa
Veeam Software developer.
prev parent reply other threads:[~2021-03-24 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 11:48 [PATCH 0/1] block: fix potential infinite loop in the negative branch in __submit_bio_noacct_mq() Sergei Shtepa
2021-03-23 11:48 ` [PATCH 1/1] " Sergei Shtepa
2021-03-24 11:18 ` Christoph Hellwig
2021-03-24 15:14 ` Sergei Shtepa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324151405.GA4260@veeam.com \
--to=sergei.shtepa@veeam.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel.tide@veeam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.