From: Rob Herring <robh@kernel.org>
To: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
devicetree@vger.kernel.org, mka@chromium.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org,
bgodavar@codeaurora.org, rjliao@codeaurora.org,
hbandi@codeaurora.org, abhishekpandit@chromium.org
Subject: Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn6750
Date: Wed, 24 Mar 2021 09:18:50 -0600 [thread overview]
Message-ID: <20210324151850.GA3083022@robh.at.kernel.org> (raw)
In-Reply-To: <1615481904-9400-3-git-send-email-gubbaven@codeaurora.org>
On Thu, Mar 11, 2021 at 10:28:24PM +0530, Venkata Lakshmi Narayana Gubba wrote:
> This patch enables regulators and gpios for the Qualcomm Bluetooth wcn6750
> controller.
>
> Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
> ---
> .../devicetree/bindings/net/qualcomm-bluetooth.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
This is a large change. Please convert to DT schema first.
>
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> index 709ca6d..e70fcb7 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> @@ -15,6 +15,7 @@ Required properties:
> * "qcom,wcn3991-bt"
> * "qcom,wcn3998-bt"
> * "qcom,qca6390-bt"
> + * "qcom,wcn6750-bt"
>
> Optional properties for compatible string qcom,qca6174-bt:
>
> @@ -39,6 +40,26 @@ Optional properties for compatible string qcom,wcn399x-bt:
> - firmware-name: specify the name of nvm firmware to load
> - clocks: clock provided to the controller
>
> +Required properties for compatible string qcom,wcn6750-bt:
> +
> + - enable-gpios: gpio specifier used to enable chip
> + - swctrl-gpios: gpio specifier is output from SoC,used to find status
> + of clock supply to SoC.
> + - vddio-supply: VDD_IO supply regulator handle.
> + - vddaon-supply: VDD_AON supply regulator handle.
> + - vddbtcxmx-suppl: VDD_BT_CXMX supply regualtor handle.
> + - vddrfacmn-supply: VDD_RFA_CMN supply regulator handle.
> + - vddrfa0p8-supply: VDD_RFA_0P8 suppply regulator handle.
> + - vddrfa1p7-supply: VDD_RFA_1P7 supply regulator handle.
> + - vddrfa1p2-supply: VDD_RFA_1P2 supply regulator handle.
> + - vddrfa2p2-supply: VDD_RFA_2P2 supply regulator handle.
> + - vddasd-supply: VDD_ASD supply regulator handle.
> +
> +Optional properties for compatible string qcom,wcn6750-bt:
> +
> + - max-speed: see Documentation/devicetree/bindings/serial/serial.yaml
> + - firmware-name: specify the name of nvm firmware to load
> +
> Examples:
>
> serial@7570000 {
> @@ -67,3 +88,25 @@ serial@898000 {
> clocks = <&rpmhcc RPMH_RF_CLK2>;
> };
> };
> +
> +serial@99c000 {
> + bluetooth {
> + compatible = "qcom,wcn6750-bt";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&bt_en_default>;
> + enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
> + swctrl-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>;
> + vddio-supply = <&vreg_l19b_1p8>;
> + vddaon-supply = <&vreg_s7b_0p9>;
> + vddbtcxmx-supply = <&vreg_s7b_0p9>;
> + vddrfacmn-supply = <&vreg_s7b_0p9>;
> + vddrfa0p8-supply = <&vreg_s7b_0p9>;
> + vddrfa1p7-supply = <&vreg_s1b_1p8>;
> + vddrfa1p2-supply = <&vreg_s8b_1p2>;
> + vddrfa2p2-supply = <&vreg_s1c_2p2>;
> + vddasd-supply = <&vreg_l11c_2p8>;
> + max-speed = <3200000>;
> + firmware-name = "msnv11.bin";
> + };
> +};
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
prev parent reply other threads:[~2021-03-24 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 16:58 [PATCH v1 0/2] Enable Bluetooth functinality for WCN6750 Venkata Lakshmi Narayana Gubba
2021-03-11 16:58 ` [PATCH v1 1/2] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6750 Venkata Lakshmi Narayana Gubba
2021-03-11 17:53 ` Enable Bluetooth functinality for WCN6750 bluez.test.bot
2021-03-11 16:58 ` [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn6750 Venkata Lakshmi Narayana Gubba
2021-03-24 15:18 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324151850.GA3083022@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gubbaven@codeaurora.org \
--cc=hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.