From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2 1/7] pm80xx: Add sysfs attribute to check mpi state
Date: Thu, 25 Mar 2021 06:49:57 +0800 [thread overview]
Message-ID: <202103250642.WL1kuKK4-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3237 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210324170357.9765-2-Viswas.G@microchip.com>
References: <20210324170357.9765-2-Viswas.G@microchip.com>
TO: Viswas G <Viswas.G@microchip.com>
TO: linux-scsi(a)vger.kernel.org
CC: Vasanthalakshmi.Tharmarajan(a)microchip.com
CC: Viswas.G(a)microchip.com
CC: Ruksar.devadi(a)microchip.com
CC: vishakhavc(a)google.com
CC: radha(a)google.com
CC: jinpu.wang(a)cloud.ionos.com
CC: Ashokkumar N <Ashokkumar.N@microchip.com>
CC: John Garry <john.garry@huawei.com>
Hi Viswas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next v5.12-rc4 next-20210324]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Viswas-G/pm80xx-updates/20210325-005709
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: x86_64-randconfig-m001-20210323 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/scsi/pm8001/pm8001_ctl.c:916 ctl_mpi_state_show() warn: mask and shift to zero
Old smatch warnings:
drivers/scsi/pm8001/pm8001_ctl.c:758 pm8001_update_flash() warn: inconsistent indenting
vim +916 drivers/scsi/pm8001/pm8001_ctl.c
47c563cdbc763e Vishakha Channapattan 2021-03-24 904
47c563cdbc763e Vishakha Channapattan 2021-03-24 905 static ssize_t ctl_mpi_state_show(struct device *cdev,
47c563cdbc763e Vishakha Channapattan 2021-03-24 906 struct device_attribute *attr, char *buf)
47c563cdbc763e Vishakha Channapattan 2021-03-24 907 {
47c563cdbc763e Vishakha Channapattan 2021-03-24 908 struct Scsi_Host *shost = class_to_shost(cdev);
47c563cdbc763e Vishakha Channapattan 2021-03-24 909 struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost);
47c563cdbc763e Vishakha Channapattan 2021-03-24 910 struct pm8001_hba_info *pm8001_ha = sha->lldd_ha;
47c563cdbc763e Vishakha Channapattan 2021-03-24 911 unsigned int mpidw0;
47c563cdbc763e Vishakha Channapattan 2021-03-24 912 int c;
47c563cdbc763e Vishakha Channapattan 2021-03-24 913
47c563cdbc763e Vishakha Channapattan 2021-03-24 914 mpidw0 = pm8001_mr32(pm8001_ha->general_stat_tbl_addr, 0);
47c563cdbc763e Vishakha Channapattan 2021-03-24 915 c = sysfs_emit(buf, "MPI-S=%s\t HMI_ERR=%x\n", mpiStateText[mpidw0 & 0x0003],
47c563cdbc763e Vishakha Channapattan 2021-03-24 @916 ((mpidw0 & 0xff00) >> 16));
47c563cdbc763e Vishakha Channapattan 2021-03-24 917 return c;
47c563cdbc763e Vishakha Channapattan 2021-03-24 918 }
47c563cdbc763e Vishakha Channapattan 2021-03-24 919 static DEVICE_ATTR_RO(ctl_mpi_state);
47c563cdbc763e Vishakha Channapattan 2021-03-24 920
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31712 bytes --]
next reply other threads:[~2021-03-24 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 22:49 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-24 17:03 [PATCH v2 0/7] pm80xx updates Viswas G
2021-03-24 17:03 ` [PATCH v2 1/7] pm80xx: Add sysfs attribute to check mpi state Viswas G
2021-03-24 20:04 ` kernel test robot
2021-03-24 20:04 ` kernel test robot
2021-03-25 4:55 ` Jinpu Wang
2021-03-25 7:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103250642.WL1kuKK4-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.