From: Muhammad Usama Anjum <musamaanjum@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, colin.king@canonical.com,
dan.carpenter@oracle.com
Cc: musamaanjum@gmail.com
Subject: [PATCH] ALSA: usb-audio: Don't store returned value and check for errors
Date: Thu, 25 Mar 2021 13:36:41 +0500 [thread overview]
Message-ID: <20210325083641.GA644957@LEGION> (raw)
The returned value by create_autodetect_quirk isn't being used other
than in the success check on next line. Remove the return value
assignement. Check for error values instead of success check.
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
---
sound/usb/quirks.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 9e5e37eff10e..5ce5f4ecb9d0 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -425,9 +425,9 @@ static int create_autodetect_quirks(struct snd_usb_audio *chip,
USB_CLASS_VENDOR_SPEC)
continue;
- err = create_autodetect_quirk(chip, iface, driver);
- if (err >= 0)
- usb_driver_claim_interface(driver, iface, (void *)-1L);
+ if (create_autodetect_quirk(chip, iface, driver) < 0)
+ continue;
+ usb_driver_claim_interface(driver, iface, (void *)-1L);
}
return 0;
--
2.25.1
next reply other threads:[~2021-03-25 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 8:36 Muhammad Usama Anjum [this message]
2021-03-26 8:00 ` [PATCH] ALSA: usb-audio: Don't store returned value and check for errors Takashi Iwai
2021-03-26 8:00 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325083641.GA644957@LEGION \
--to=musamaanjum@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.