From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09DAAC433C1 for ; Thu, 25 Mar 2021 12:50:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D310061879 for ; Thu, 25 Mar 2021 12:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbhCYMti (ORCPT ); Thu, 25 Mar 2021 08:49:38 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:11012 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbhCYMtW (ORCPT ); Thu, 25 Mar 2021 08:49:22 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12PChLdv032518; Thu, 25 Mar 2021 13:46:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=EsJHfVuK6OPv47dlPTn33o0Xtea7CvUSJM49t+zRfMo=; b=nJrfBvdzjGVJbwnP7SVX7HgdWRcC8ULtQLKpdNmZjnl6TrWyX5oLx/qOpI7ady4/G/k3 FMq1M/waiSpEdMjK0+z4vLG7pf3eRcBIy34BPershUqNKWwSP5ctoqkR01JkBOPIRtZh +oGdbLdjfwA5B/++cqGsXVNsMOb3VVYk1z6ZygrV2VK6DMyqDEAD2UoB7SMfYXBR9Kqs vPNWZbkJfNRF1Lht+3NXwEXPmqW4H12IEkjK0NHyxTaXQvsocxWLkGoM/8yx4Z09KXj+ 1eIHCJG3dEduZJFpePLn/viGz0N45Unl7++eTfIbslYMqqK1MEilnYv13tzF2rAffggZ kg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37fb17q769-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 13:46:56 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E6582100034; Thu, 25 Mar 2021 13:46:55 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C69DA256DE1; Thu, 25 Mar 2021 13:46:55 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.75.127.48) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Mar 2021 13:46:55 +0100 Date: Thu, 25 Mar 2021 13:46:47 +0100 From: Alain Volmat To: Tian Tao CC: , , , , , , , , Subject: Re: [PATCH] i2c: stm32f7: Remove useless error message Message-ID: <20210325124647.GA29312@gnbcxd0016.gnb.st.com> Mail-Followup-To: Tian Tao , pierre-yves.mordret@foss.st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, p.zabel@pengutronix.de, sumit.semwal@linaro.org, christian.koenig@amd.com, linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <1616673872-4382-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1616673872-4382-1-git-send-email-tiantao6@hisilicon.com> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG3NODE2.st.com (10.75.127.8) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-25_03:2021-03-24,2021-03-25 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hello, Thanks for the patch. Reviewed-by: Alain Volmat Alain On Thu, Mar 25, 2021 at 08:04:32PM +0800, Tian Tao wrote: > Fix the following coccicheck report: > > drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq : > line 2032 is redundant because platform_get_irq() already prints an error > > Remove dev_err() messages after platform_get_irq() failures. > > Signed-off-by: Tian Tao > Signed-off-by: Zihao Tang > --- > drivers/i2c/busses/i2c-stm32f7.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 162a3b0..9fbcbd1 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -2035,12 +2035,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) > phy_addr = (dma_addr_t)res->start; > > irq_event = platform_get_irq(pdev, 0); > - if (irq_event <= 0) { > - if (irq_event != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Failed to get IRQ event: %d\n", > - irq_event); > + if (irq_event <= 0) > return irq_event ? : -ENOENT; > - } > > irq_error = platform_get_irq(pdev, 1); > if (irq_error <= 0) > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262C6C433C1 for ; Thu, 25 Mar 2021 14:05:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75A1C61962 for ; Thu, 25 Mar 2021 14:04:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75A1C61962 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Ytmgd35fQGt6cIXIrDlZLAum+Sn4LVFYxycvFqviFU=; b=lwNpwQtQ1O4KUMGCNgRE5wzcS YVPh5Vq16n+wMhe8HwpDIr1rAO53DQs3seAu0gC9r8YQQy3T/+MrlLic2GDsyrDDiLhcEaZYB/RK/ 7BrZGQI6sm6DQaOdjDSPRteMllA+GcIi/2namvPVs9L53d/Y+q2wcXwqL7rFguBpSQT3b2oRfeL26 qjJprvbay7vULZfi5vXKrzCyD6COy/LkU/PAlDGmXwcpqgLto7QI6/nZPjCUSWki9sxRnB6w7sCok ooIvBYkWAaPRwJLP6f3TNbtBzQr6CjZSdqBnlUpOm4Qg6elKa8IlpF2jn482pPbTUmcYe+E9vTwUv xuU7UyB6A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPQZh-001Zgm-8c; Thu, 25 Mar 2021 14:03:01 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPPOC-001R1W-Je for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 12:49:08 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12PChLdv032518; Thu, 25 Mar 2021 13:46:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=selector1; bh=EsJHfVuK6OPv47dlPTn33o0Xtea7CvUSJM49t+zRfMo=; b=nJrfBvdzjGVJbwnP7SVX7HgdWRcC8ULtQLKpdNmZjnl6TrWyX5oLx/qOpI7ady4/G/k3 FMq1M/waiSpEdMjK0+z4vLG7pf3eRcBIy34BPershUqNKWwSP5ctoqkR01JkBOPIRtZh +oGdbLdjfwA5B/++cqGsXVNsMOb3VVYk1z6ZygrV2VK6DMyqDEAD2UoB7SMfYXBR9Kqs vPNWZbkJfNRF1Lht+3NXwEXPmqW4H12IEkjK0NHyxTaXQvsocxWLkGoM/8yx4Z09KXj+ 1eIHCJG3dEduZJFpePLn/viGz0N45Unl7++eTfIbslYMqqK1MEilnYv13tzF2rAffggZ kg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 37fb17q769-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 13:46:56 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E6582100034; Thu, 25 Mar 2021 13:46:55 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C69DA256DE1; Thu, 25 Mar 2021 13:46:55 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.75.127.48) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Mar 2021 13:46:55 +0100 Date: Thu, 25 Mar 2021 13:46:47 +0100 From: Alain Volmat To: Tian Tao CC: , , , , , , , , Subject: Re: [PATCH] i2c: stm32f7: Remove useless error message Message-ID: <20210325124647.GA29312@gnbcxd0016.gnb.st.com> Mail-Followup-To: Tian Tao , pierre-yves.mordret@foss.st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, p.zabel@pengutronix.de, sumit.semwal@linaro.org, christian.koenig@amd.com, linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <1616673872-4382-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1616673872-4382-1-git-send-email-tiantao6@hisilicon.com> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG3NODE2.st.com (10.75.127.8) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-25_03:2021-03-24, 2021-03-25 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_124904_960999_4901D693 X-CRM114-Status: GOOD ( 20.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, Thanks for the patch. Reviewed-by: Alain Volmat Alain On Thu, Mar 25, 2021 at 08:04:32PM +0800, Tian Tao wrote: > Fix the following coccicheck report: > > drivers/i2c/busses/i2c-stm32f7.c:2032:3-10 : platform_get_irq : > line 2032 is redundant because platform_get_irq() already prints an error > > Remove dev_err() messages after platform_get_irq() failures. > > Signed-off-by: Tian Tao > Signed-off-by: Zihao Tang > --- > drivers/i2c/busses/i2c-stm32f7.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 162a3b0..9fbcbd1 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -2035,12 +2035,8 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) > phy_addr = (dma_addr_t)res->start; > > irq_event = platform_get_irq(pdev, 0); > - if (irq_event <= 0) { > - if (irq_event != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Failed to get IRQ event: %d\n", > - irq_event); > + if (irq_event <= 0) > return irq_event ? : -ENOENT; > - } > > irq_error = platform_get_irq(pdev, 1); > if (irq_error <= 0) > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel