From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCC89C433DB for ; Thu, 25 Mar 2021 14:22:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59893619EC for ; Thu, 25 Mar 2021 14:22:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59893619EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XlA+EcTVdHtB/c4DPJfnUNx+tRS+nA1Hz4twY1CHZLU=; b=ioTM+FOcPKzpT5MRzJNMiwJUG faiS9N6C1oijgD+KTI/smrgIlx0oLarzfi4NGLXoSijB+N9Dm4HKurTVMCVpqdBUiBkjwREkUd8e6 GlxnMdwvrT+KwzblIV1skvvmV8V9Bvb2WHGQzQgl2Fdw7v4J0J5XSN0lNENtQIkwe4PEDIgtwpG7y 16f0HDUh4vZSsUF8yoXY+XRuGYrX0hwsWs6HOPaBvlKlS9BomW4hJP7o8Xe3maBD/xiO04F+NfBMW anBKKuvHCxhlt06P/AsgsCOayx32FI1QvAhnuxVfX2nDfKsxlFkoJwLT34gXSSw8v4CtB9yOXQCUn yEO1lmUeA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPQqa-001bEK-Fo; Thu, 25 Mar 2021 14:20:28 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPQqV-001bDt-9E for linux-arm-kernel@lists.infradead.org; Thu, 25 Mar 2021 14:20:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bwkza07CK3I496mJr/hRCcP/6zzNBPLmmcQvRMvQpIk=; b=bNiYsVmUPdL0JtJJdhnG+Pjgt nNOQ2c0vi3MKCbNbXiAQ9lkCp1aSp7x6yBuZfpJE7/LYeFhyi9rfZB4XRS6L++c0eWn6aks6doT+m WOdDyXJfpbLlN//9cHJb22+tenfVjS20UEuDRRpoVy9t4yzjH1cK8eyN+Qs55vl1EnbqMzDBPnx6p J389/4oPWk8pUYgQvP3qq5V+J2mCoYxCb+85SwAu1onF0zvs+TjgijaCqV4iI+TH7FDgRxkVGq6gI TpPDa0TYEnyYDtaBXhWLs2XfQlt1dGQOE8NtsXDA9TRiUf6Sktze9xjLNdgjIEF1BGYhZfzL9XVOw 0uZiBLjNw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51724) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPQqO-0001pW-Ar; Thu, 25 Mar 2021 14:20:16 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lPQqJ-000658-TU; Thu, 25 Mar 2021 14:20:11 +0000 Date: Thu, 25 Mar 2021 14:20:11 +0000 From: Russell King - ARM Linux admin To: Liu Xiang Cc: Liu Xiang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liuxiang_1999@126.com Subject: Re: [PATCH] ARM: fix smp_processor_id() in preemptible warning in harden_branch_predictor() Message-ID: <20210325142011.GN1463@shell.armlinux.org.uk> References: <20210325095049.6948-1-liu.xiang@zlingsmart.com> <20210325100605.GL1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210325_142023_790906_727E1B75 X-CRM114-Status: GOOD ( 20.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXIgMjUsIDIwMjEgYXQgMDk6MzI6MzVQTSArMDgwMCwgTGl1IFhpYW5nIHdyb3Rl Ogo+IFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCBhZG1pbiA8bGludXhAYXJtbGludXgub3JnLnVr PiDkuo4yMDIx5bm0M+aciDI15pel5ZGo5ZubIOS4i+WNiDY6MDblhpnpgZPvvJoKPiA+Cj4gPiBP biBUaHUsIE1hciAyNSwgMjAyMSBhdCAwNTo1MDo0OVBNICswODAwLCBMaXUgWGlhbmcgd3JvdGU6 Cj4gPiA+IFdoZW4gQ09ORklHX0hBUkRFTl9CUkFOQ0hfUFJFRElDVE9SIGlzIHNlbGVjdGVkIGFu ZCB1c2VyIGFib3J0cyBvY2N1ciwKPiA+ID4gdGhlcmUgaXMgYSB3YXJuaW5nOgo+ID4gPgo+ID4g PiBCVUc6IHVzaW5nIHNtcF9wcm9jZXNzb3JfaWQoKSBpbiBwcmVlbXB0aWJsZSBbMDAwMDAwMDBd IGNvZGU6IGVycm5vdGVzdC81NzcKPiA+ID4gY2FsbGVyIGlzIF9fZG9fdXNlcl9mYXVsdC5jb25z dHByb3AuNCsweDI0LzB4ODgKPiA+ID4gQ1BVOiAxIFBJRDogNTc3IENvbW06IGVycm5vdGVzdCBO b3QgdGFpbnRlZCA0LjE0LjE4OC1ydDg3LWZtc2gtMDAwMDQtZzU4MDU1ODc3YSAjMQo+ID4gPiBI YXJkd2FyZSBuYW1lOiBGTVNIIFBTT0MgUGxhdGZvcm0KPiA+ID4gWzw4MDEwZDZkND5dICh1bndp bmRfYmFja3RyYWNlKSBmcm9tIFs8ODAxMGEyMjg+XSAoc2hvd19zdGFjaysweDEwLzB4MTQpCj4g PiA+IFs8ODAxMGEyMjg+XSAoc2hvd19zdGFjaykgZnJvbSBbPDgwNjk4ZjQ0Pl0gKGR1bXBfc3Rh Y2srMHg3Yy8weDk4KQo+ID4gPiBbPDgwNjk4ZjQ0Pl0gKGR1bXBfc3RhY2spIGZyb20gWzw4MDNk MTdkMD5dIChjaGVja19wcmVlbXB0aW9uX2Rpc2FibGVkKzB4YzQvMHhmYykKPiA+ID4gWzw4MDNk MTdkMD5dIChjaGVja19wcmVlbXB0aW9uX2Rpc2FibGVkKSBmcm9tIFs8ODAxMTBlYjg+XSAoX19k b191c2VyX2ZhdWx0LmNvbnN0cHJvcC40KzB4MjQvMHg4OCkKPiA+ID4gWzw4MDExMGViOD5dIChf X2RvX3VzZXJfZmF1bHQuY29uc3Rwcm9wLjQpIGZyb20gWzw4MDExMTJlND5dIChkb19wYWdlX2Zh dWx0KzB4MmRjLzB4MzEwKQo+ID4gPiBbPDgwMTExMmU0Pl0gKGRvX3BhZ2VfZmF1bHQpIGZyb20g Wzw4MDEwMTJhOD5dIChkb19EYXRhQWJvcnQrMHgzOC8weGI4KQo+ID4gPiBbPDgwMTAxMmE4Pl0g KGRvX0RhdGFBYm9ydCkgZnJvbSBbPDgwMTBiMDNjPl0gKF9fZGFidF91c3IrMHgzYy8weDQwKQo+ ID4gPiBFeGNlcHRpb24gc3RhY2soMHhiMjFkMWZiMCB0byAweGIyMWQxZmY4KQo+ID4gPiAxZmEw OiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmZmZmZmZmNCAwMDAwMDAwMCAw MDAwMDA1NCBmZmZmZmZmNAo+ID4gPiAxZmMwOiAwMDAwMDAwMCAwMDAwMDAwMCA3ZWQ4MWNjOCA3 ZWQ4MWNhMCAwMDA3YTQ0MCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMAo+ID4gPiAxZmUwOiAw MDAwMDAwMCA3ZWQ4MWNhMCAwMDAxMDQ5MyAwMDAxZjMzMCAyMDAzMDAxMCBmZmZmZmZmZgo+ID4K PiA+IFRoaXMgaXMgbm90IHRoZSByaWdodCBmaXggLSBwcmVlbXB0aW9uIGlzIHN1cHBvc2VkIHRv IGJlIGRpc2FibGVkIGJlZm9yZQo+ID4gdGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQuIEknbSBub3Qg c3VyZSBhdCB0aGUgcHJlc2VudCB0aW1lIHdoYXQgdGhlIHJpZ2h0Cj4gPiBmaXggaXMgc3VwcG9z ZWQgdG8gYmUgYmVjYXVzZSBJJ3ZlIGZvcmdvdHRlbiBtb3N0IG9mIHRoZSBiYWNrZ3JvdW5kCj4g PiBiZWhpbmQgd2h5IHRoaXMgd2FzIHBsYWNlZCB3aGVyZSBpdCBpcy4KPiA+Cj4gPiAtLQo+ID4g Uk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1saW51eC5vcmcudWsvZGV2ZWxvcGVy L3BhdGNoZXMvCj4gPiBGVFRQIGlzIGhlcmUhIDQwTWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50 IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQo+IAo+IEkgaGF2ZSB0ZXN0ZWQgd2l0aCB0aGUgY3VycmVu dCBtYWlubGluZSBrZXJuZWwsIHRoZSB3YXJuaW5nIHN0aWxsIGV4aXN0cy4KClllcywgaXQgc3Rp bGwgZXhpc3RzLCBiZWNhdXNlIGl0J3MgbmV2ZXIgYmVlbiBmaXhlZCwgYnV0IHRoZSB3YXkgeW91 IGFyZQpmaXhpbmcgaXQgaXMgbm90IGNvcnJlY3QuIFdlIGRvIG5vdCBwYXBlciBvdmVyIHdhcm5p bmdzIHdpdGggaW5jb3JyZWN0CmZpeGVzLgoKLS0gClJNSydzIFBhdGNoIHN5c3RlbTogaHR0cHM6 Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRQIGlzIGhlcmUhIDQw TWJwcyBkb3duIDEwTWJwcyB1cC4gRGVjZW50IGNvbm5lY3Rpdml0eSBhdCBsYXN0IQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DCFC433C1 for ; Thu, 25 Mar 2021 14:21:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48D9A61A23 for ; Thu, 25 Mar 2021 14:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbhCYOUf (ORCPT ); Thu, 25 Mar 2021 10:20:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbhCYOUY (ORCPT ); Thu, 25 Mar 2021 10:20:24 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89A5CC06174A for ; Thu, 25 Mar 2021 07:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Bwkza07CK3I496mJr/hRCcP/6zzNBPLmmcQvRMvQpIk=; b=bNiYsVmUPdL0JtJJdhnG+Pjgt nNOQ2c0vi3MKCbNbXiAQ9lkCp1aSp7x6yBuZfpJE7/LYeFhyi9rfZB4XRS6L++c0eWn6aks6doT+m WOdDyXJfpbLlN//9cHJb22+tenfVjS20UEuDRRpoVy9t4yzjH1cK8eyN+Qs55vl1EnbqMzDBPnx6p J389/4oPWk8pUYgQvP3qq5V+J2mCoYxCb+85SwAu1onF0zvs+TjgijaCqV4iI+TH7FDgRxkVGq6gI TpPDa0TYEnyYDtaBXhWLs2XfQlt1dGQOE8NtsXDA9TRiUf6Sktze9xjLNdgjIEF1BGYhZfzL9XVOw 0uZiBLjNw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51724) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPQqO-0001pW-Ar; Thu, 25 Mar 2021 14:20:16 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lPQqJ-000658-TU; Thu, 25 Mar 2021 14:20:11 +0000 Date: Thu, 25 Mar 2021 14:20:11 +0000 From: Russell King - ARM Linux admin To: Liu Xiang Cc: Liu Xiang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liuxiang_1999@126.com Subject: Re: [PATCH] ARM: fix smp_processor_id() in preemptible warning in harden_branch_predictor() Message-ID: <20210325142011.GN1463@shell.armlinux.org.uk> References: <20210325095049.6948-1-liu.xiang@zlingsmart.com> <20210325100605.GL1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King - ARM Linux admin Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 09:32:35PM +0800, Liu Xiang wrote: > Russell King - ARM Linux admin 于2021年3月25日周四 下午6:06写道： > > > > On Thu, Mar 25, 2021 at 05:50:49PM +0800, Liu Xiang wrote: > > > When CONFIG_HARDEN_BRANCH_PREDICTOR is selected and user aborts occur, > > > there is a warning: > > > > > > BUG: using smp_processor_id() in preemptible [00000000] code: errnotest/577 > > > caller is __do_user_fault.constprop.4+0x24/0x88 > > > CPU: 1 PID: 577 Comm: errnotest Not tainted 4.14.188-rt87-fmsh-00004-g58055877a #1 > > > Hardware name: FMSH PSOC Platform > > > [<8010d6d4>] (unwind_backtrace) from [<8010a228>] (show_stack+0x10/0x14) > > > [<8010a228>] (show_stack) from [<80698f44>] (dump_stack+0x7c/0x98) > > > [<80698f44>] (dump_stack) from [<803d17d0>] (check_preemption_disabled+0xc4/0xfc) > > > [<803d17d0>] (check_preemption_disabled) from [<80110eb8>] (__do_user_fault.constprop.4+0x24/0x88) > > > [<80110eb8>] (__do_user_fault.constprop.4) from [<801112e4>] (do_page_fault+0x2dc/0x310) > > > [<801112e4>] (do_page_fault) from [<801012a8>] (do_DataAbort+0x38/0xb8) > > > [<801012a8>] (do_DataAbort) from [<8010b03c>] (__dabt_usr+0x3c/0x40) > > > Exception stack(0xb21d1fb0 to 0xb21d1ff8) > > > 1fa0: fffffff4 00000000 00000054 fffffff4 > > > 1fc0: 00000000 00000000 7ed81cc8 7ed81ca0 0007a440 00000000 00000000 00000000 > > > 1fe0: 00000000 7ed81ca0 00010493 0001f330 20030010 ffffffff > > > > This is not the right fix - preemption is supposed to be disabled before > > this function is called. I'm not sure at the present time what the right > > fix is supposed to be because I've forgotten most of the background > > behind why this was placed where it is. > > > > -- > > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > > I have tested with the current mainline kernel, the warning still exists. Yes, it still exists, because it's never been fixed, but the way you are fixing it is not correct. We do not paper over warnings with incorrect fixes. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!