All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, ecree.xilinx@gmail.com,
	michael.chan@broadcom.com, paul.greenwalt@intel.com,
	rajur@chelsio.com, jaroslawx.gawin@intel.com,
	vkochan@marvell.com, alobakin@pm.me, snelson@pensando.io,
	shayagr@amazon.com, ayal@nvidia.com, shenjian15@huawei.com,
	saeedm@nvidia.com, mkubecek@suse.cz, andrew@lunn.ch,
	roopa@nvidia.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 2/6] ethtool: fec: remove long structure description
Date: Thu, 25 Mar 2021 19:07:23 -0700	[thread overview]
Message-ID: <20210326020727.246828-3-kuba@kernel.org> (raw)
In-Reply-To: <20210326020727.246828-1-kuba@kernel.org>

Digging through the mailing list archive @autoneg was part
of the first version of the RFC, this left over comment was
pointed out twice in review but wasn't removed.

The sentence is an exact copy-paste from pauseparam.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 include/uapi/linux/ethtool.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 1433d6278018..36bf435d232c 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -1377,18 +1377,14 @@ struct ethtool_per_queue_op {
 
 /**
  * struct ethtool_fecparam - Ethernet forward error correction(fec) parameters
  * @cmd: Command number = %ETHTOOL_GFECPARAM or %ETHTOOL_SFECPARAM
  * @active_fec: FEC mode which is active on the port
  * @fec: Bitmask of supported/configured FEC modes
  * @rsvd: Reserved for future extensions. i.e FEC bypass feature.
- *
- * Drivers should reject a non-zero setting of @autoneg when
- * autoneogotiation is disabled (or not supported) for the link.
- *
  */
 struct ethtool_fecparam {
 	__u32   cmd;
 	/* bitmask of FEC modes */
 	__u32   active_fec;
 	__u32   fec;
 	__u32   reserved;
-- 
2.30.2


  parent reply	other threads:[~2021-03-26  2:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  2:07 [PATCH net-next v2 0/6] ethtool: clarify the ethtool FEC interface Jakub Kicinski
2021-03-26  2:07 ` [PATCH net-next v2 1/6] ethtool: fec: fix typo in kdoc Jakub Kicinski
2021-03-26  2:07 ` Jakub Kicinski [this message]
2021-03-26  2:07 ` [PATCH net-next v2 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved Jakub Kicinski
2021-03-26 12:17   ` Andrew Lunn
2021-03-26  2:07 ` [PATCH net-next v2 4/6] ethtool: fec: sanitize ethtool_fecparam->active_fec Jakub Kicinski
2021-03-26  2:07 ` [PATCH net-next v2 5/6] ethtool: fec: sanitize ethtool_fecparam->fec Jakub Kicinski
2021-03-26 12:18   ` Andrew Lunn
2021-03-26  2:07 ` [PATCH net-next v2 6/6] ethtool: clarify the ethtool FEC interface Jakub Kicinski
2021-03-26 12:20   ` Andrew Lunn
2021-03-26 21:49 ` [PATCH net-next v2 0/6] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326020727.246828-3-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=alobakin@pm.me \
    --cc=andrew@lunn.ch \
    --cc=ayal@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=ecree.xilinx@gmail.com \
    --cc=jaroslawx.gawin@intel.com \
    --cc=michael.chan@broadcom.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=paul.greenwalt@intel.com \
    --cc=rajur@chelsio.com \
    --cc=roopa@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=shayagr@amazon.com \
    --cc=shenjian15@huawei.com \
    --cc=snelson@pensando.io \
    --cc=vkochan@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.