All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Cc: Arnd Bergmann <arnd@arndb.de>, Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH 0/3] Fix Footbridge PCI I/O resources
Date: Fri, 26 Mar 2021 12:17:35 +0000	[thread overview]
Message-ID: <20210326121735.GQ1463@shell.armlinux.org.uk> (raw)

This series fixes the PCI I/O resources for the Footbridge platforms
which were broken quite some time ago by misinterpretation of what
pcibios_min_io actually means, and the introduction of bus level PCI
I/O resources.

The changes become a particular problem when a Southbridge is present
on the PCI bus, which is a PCI-to-ISA bridge, and hence is where all
the ISA resources live. It is made worse when you have an IDE
controller which operates in legacy mode, with resources at the
0x170/0x1f0/0x376/0x3f6 addresses.

Worse than that, the previous changes removed the CSR I/O resource
allocation entirely, setting the 21285 to respond to I/O transactions
at bus address 0, which may overlap ISA resources on the Southbridge.

This series fixes the resource problems by restoring the old behaviour
via a flag that omits the PCI I/O resource, enabling this flag for all
footbridge platforms, and restoring the allocation of the CSR I/O
resource. This approach offers minimal impact for other platforms.

 arch/arm/include/asm/mach/pci.h          |  1 +
 arch/arm/kernel/bios32.c                 | 37 +++++++++++++++++++-------------
 arch/arm/mach-footbridge/cats-pci.c      |  1 +
 arch/arm/mach-footbridge/dc21285.c       | 15 ++++++++++++-
 arch/arm/mach-footbridge/ebsa285-pci.c   |  1 +
 arch/arm/mach-footbridge/netwinder-pci.c |  1 +
 arch/arm/mach-footbridge/personal-pci.c  |  1 +
 7 files changed, 41 insertions(+), 16 deletions(-)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-03-26 12:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 12:17 Russell King - ARM Linux admin [this message]
2021-03-26 12:18 ` [PATCH 1/3] ARM: pci: make bus I/O resources optional Russell King
2021-03-26 13:33   ` Arnd Bergmann
2021-03-26 13:39     ` Russell King - ARM Linux admin
2021-03-26 14:01       ` Arnd Bergmann
2021-03-26 12:18 ` [PATCH 2/3] ARM: footbridge: avoid using separate PCI I/O bus resource Russell King
2021-03-26 12:18 ` [PATCH 3/3] ARM: footbridge: restore allocation of CSR I/O resource Russell King
2021-03-26 13:37   ` Arnd Bergmann
2021-03-26 13:40     ` Russell King - ARM Linux admin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326121735.GQ1463@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.