From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH] cifs: add support for FALLOC_FL_COLLAPSE_RANGE
Date: Fri, 26 Mar 2021 15:40:10 +0800 [thread overview]
Message-ID: <202103261510.LJ7BCDUe-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4375 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210326013146.80962-1-lsahlber@redhat.com>
References: <20210326013146.80962-1-lsahlber@redhat.com>
TO: Ronnie Sahlberg <lsahlber@redhat.com>
TO: "linux-cifs" <linux-cifs@vger.kernel.org>
CC: Steve French <smfrench@gmail.com>
Hi Ronnie,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on cifs/for-next]
[also build test WARNING on v5.12-rc4 next-20210325]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ronnie-Sahlberg/cifs-add-support-for-FALLOC_FL_COLLAPSE_RANGE/20210326-093328
base: git://git.samba.org/sfrench/cifs-2.6.git for-next
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: i386-randconfig-m021-20210325 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
fs/cifs/smb2ops.c:3654 smb3_collapse_range() warn: statement has no effect 5
fs/cifs/smb2ops.c:3654 smb3_collapse_range() error: uninitialized symbol 'rc'.
Old smatch warnings:
fs/cifs/smb2ops.c:3660 smb3_collapse_range() warn: statement has no effect 5
fs/cifs/smb2ops.c:3660 smb3_collapse_range() error: uninitialized symbol 'rc'.
vim +3654 fs/cifs/smb2ops.c
9ccf3216238ca7 Steve French 2014-10-18 3642
0536911dc253bd Ronnie Sahlberg 2021-03-26 3643 static long smb3_collapse_range(struct file *file, struct cifs_tcon *tcon,
0536911dc253bd Ronnie Sahlberg 2021-03-26 3644 loff_t off, loff_t len)
0536911dc253bd Ronnie Sahlberg 2021-03-26 3645 {
0536911dc253bd Ronnie Sahlberg 2021-03-26 3646 int rc;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3647 unsigned int xid;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3648 struct cifsFileInfo *cfile = file->private_data;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3649 __le64 eof;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3650
0536911dc253bd Ronnie Sahlberg 2021-03-26 3651 xid = get_xid();
0536911dc253bd Ronnie Sahlberg 2021-03-26 3652
0536911dc253bd Ronnie Sahlberg 2021-03-26 3653 if (off + len < off) {
0536911dc253bd Ronnie Sahlberg 2021-03-26 @3654 rc -EFBIG;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3655 goto out;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3656 }
0536911dc253bd Ronnie Sahlberg 2021-03-26 3657
0536911dc253bd Ronnie Sahlberg 2021-03-26 3658 if (off >= i_size_read(file->f_inode) ||
0536911dc253bd Ronnie Sahlberg 2021-03-26 3659 off + len >= i_size_read(file->f_inode)) {
0536911dc253bd Ronnie Sahlberg 2021-03-26 3660 rc -EINVAL;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3661 goto out;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3662 }
0536911dc253bd Ronnie Sahlberg 2021-03-26 3663
0536911dc253bd Ronnie Sahlberg 2021-03-26 3664 rc = smb2_copychunk_range(xid, cfile, cfile, off + len,
0536911dc253bd Ronnie Sahlberg 2021-03-26 3665 i_size_read(file->f_inode) - off - len, off);
0536911dc253bd Ronnie Sahlberg 2021-03-26 3666 if (rc < 0)
0536911dc253bd Ronnie Sahlberg 2021-03-26 3667 goto out;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3668
0536911dc253bd Ronnie Sahlberg 2021-03-26 3669 eof = i_size_read(file->f_inode) - len;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3670 rc = SMB2_set_eof(xid, tcon, cfile->fid.persistent_fid,
0536911dc253bd Ronnie Sahlberg 2021-03-26 3671 cfile->fid.volatile_fid, cfile->pid, &eof);
0536911dc253bd Ronnie Sahlberg 2021-03-26 3672 if (rc < 0)
0536911dc253bd Ronnie Sahlberg 2021-03-26 3673 goto out;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3674
0536911dc253bd Ronnie Sahlberg 2021-03-26 3675 rc = 0;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3676 out:
0536911dc253bd Ronnie Sahlberg 2021-03-26 3677 free_xid(xid);
0536911dc253bd Ronnie Sahlberg 2021-03-26 3678 return rc;
0536911dc253bd Ronnie Sahlberg 2021-03-26 3679 }
0536911dc253bd Ronnie Sahlberg 2021-03-26 3680
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39072 bytes --]
next reply other threads:[~2021-03-26 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 7:40 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-26 19:52 [PATCH] cifs: add support for FALLOC_FL_COLLAPSE_RANGE Ronnie Sahlberg
2021-03-30 14:21 ` Aurélien Aptel
2021-03-30 22:09 ` ronnie sahlberg
2021-03-30 22:15 ` Steve French
2021-04-01 5:41 ` Steve French
2021-03-26 1:31 Ronnie Sahlberg
2021-03-26 5:58 ` kernel test robot
2021-03-26 5:58 ` kernel test robot
2021-03-26 8:35 ` Dan Carpenter
2021-03-26 8:35 ` Dan Carpenter
2021-03-26 8:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103261510.LJ7BCDUe-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.