From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57537C433DB for ; Fri, 26 Mar 2021 18:30:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B306B61A24 for ; Fri, 26 Mar 2021 18:30:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B306B61A24 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q88Xr2sd2fQY0GhTqPyr3pweSgHeNuHZ7aKuIHfbxSo=; b=byyGd5KE510FPWpQz5pndhutq WigQ0SvE6YiQi5X7K6Bj6pdUKqTGD5O+NwbEREnlrO7d9dYwkTKqWCcBx4RGfiTfcNurUfdhNImyX SB51tybLJ+437fYlohKRQGfiYJ53qkurLZPKKUsCDE1XNMRuvVdLuFyGR4gJe8SEnX69PcqmkULJh EeyZ+EAU5MHkNfIVhovqxWt1oZRH67LG7vzfh6pb/J+NlJQav1pyKlJPr0xtYWQYdlJO1WXC8T0+5 gGMh4yUC4MATNPgbwkcAe+wDD3LbkZLsknkFOXQB6w3DiukvrsLGxanro7Kt2vaoZajhJVFnsRRr7 7kNUoFM2Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPrCT-004915-3t; Fri, 26 Mar 2021 18:28:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPrCP-00490U-EM for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 18:28:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A8A061A3F; Fri, 26 Mar 2021 18:28:42 +0000 (UTC) Date: Fri, 26 Mar 2021 18:28:40 +0000 From: Catalin Marinas To: Andrei Vagin Cc: Will Deacon , Oleg Nesterov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Keno Fischer Subject: Re: [PATCH 1/4] arm64: expose orig_x0 in the user_pt_regs structure Message-ID: <20210326182839.GE5126@arm.com> References: <20210322225053.428615-1-avagin@gmail.com> <20210322225053.428615-2-avagin@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210322225053.428615-2-avagin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_182845_672142_3EB50133 X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 22, 2021 at 03:50:50PM -0700, Andrei Vagin wrote: > diff --git a/arch/arm64/include/uapi/asm/ptrace.h b/arch/arm64/include/uapi/asm/ptrace.h > index 758ae984ff97..3c118c5b0893 100644 > --- a/arch/arm64/include/uapi/asm/ptrace.h > +++ b/arch/arm64/include/uapi/asm/ptrace.h > @@ -90,6 +90,7 @@ struct user_pt_regs { > __u64 sp; > __u64 pc; > __u64 pstate; > + __u64 orig_x0; > }; That's a UAPI change, likely to go wrong. For example, a ptrace(PTRACE_GETREGSET, pid, REGSET_GPR, data) would write past the end of an old struct user_pt_regs in the debugger. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F636C433DB for ; Fri, 26 Mar 2021 18:29:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4151261A24 for ; Fri, 26 Mar 2021 18:29:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhCZS3D (ORCPT ); Fri, 26 Mar 2021 14:29:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:35632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230134AbhCZS2o (ORCPT ); Fri, 26 Mar 2021 14:28:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A8A061A3F; Fri, 26 Mar 2021 18:28:42 +0000 (UTC) Date: Fri, 26 Mar 2021 18:28:40 +0000 From: Catalin Marinas To: Andrei Vagin Cc: Will Deacon , Oleg Nesterov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Keno Fischer Subject: Re: [PATCH 1/4] arm64: expose orig_x0 in the user_pt_regs structure Message-ID: <20210326182839.GE5126@arm.com> References: <20210322225053.428615-1-avagin@gmail.com> <20210322225053.428615-2-avagin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322225053.428615-2-avagin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 03:50:50PM -0700, Andrei Vagin wrote: > diff --git a/arch/arm64/include/uapi/asm/ptrace.h b/arch/arm64/include/uapi/asm/ptrace.h > index 758ae984ff97..3c118c5b0893 100644 > --- a/arch/arm64/include/uapi/asm/ptrace.h > +++ b/arch/arm64/include/uapi/asm/ptrace.h > @@ -90,6 +90,7 @@ struct user_pt_regs { > __u64 sp; > __u64 pc; > __u64 pstate; > + __u64 orig_x0; > }; That's a UAPI change, likely to go wrong. For example, a ptrace(PTRACE_GETREGSET, pid, REGSET_GPR, data) would write past the end of an old struct user_pt_regs in the debugger. -- Catalin