From: Rob Herring <robh@kernel.org>
To: jack.yu@realtek.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lars@metafoo.de, kent_chen@realtek.com, kenny_chen@realtek.com,
lgirdwood@gmail.com, broonie@kernel.org, derek.fang@realtek.com,
shumingf@realtek.com, flove@realtek.com
Subject: Re: [PATCH v2] ASoC: rt1019: add rt1019 amplifier driver
Date: Fri, 26 Mar 2021 14:34:07 -0600 [thread overview]
Message-ID: <20210326203407.GA3815424@robh.at.kernel.org> (raw)
In-Reply-To: <20210311025809.31852-1-jack.yu@realtek.com>
On Thu, Mar 11, 2021 at 10:58:09AM +0800, jack.yu@realtek.com wrote:
> From: Jack Yu <jack.yu@realtek.com>
>
> This is initial amplifier driver for rt1019.
>
> Signed-off-by: Jack Yu <jack.yu@realtek.com>
> ---
> .../devicetree/bindings/sound/rt1019.yaml | 33 +
Bindings should be a separate patch. checkpatch.pl will tell you this.
Bindings should also be sent to the DT list. get_maintainer.pl will tell
you this.
Now this causes warnings in linux-next:
Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/rt1019.example.dts:19.13-24.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus
Documentation/devicetree/bindings/sound/rt1019.example.dts:19.13-24.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus
Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/sound/rt1019.example.dts:20.30-23.15: Warning (avoid_default_addr_size): /example-0/i2c/codec@28: Relying on default #address-cells value
Documentation/devicetree/bindings/sound/rt1019.example.dts:20.30-23.15: Warning (avoid_default_addr_size): /example-0/i2c/codec@28: Relying on default #size-cells value
Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size'
> sound/soc/codecs/Kconfig | 7 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/rt1019.c | 940 ++++++++++++++++++
> sound/soc/codecs/rt1019.h | 320 ++++++
> 5 files changed, 1302 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/rt1019.yaml
> create mode 100644 sound/soc/codecs/rt1019.c
> create mode 100644 sound/soc/codecs/rt1019.h
next prev parent reply other threads:[~2021-03-26 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 2:58 [PATCH v2] ASoC: rt1019: add rt1019 amplifier driver jack.yu
2021-03-18 18:33 ` Mark Brown
2021-03-18 18:36 ` Mark Brown
2021-03-26 20:34 ` Rob Herring [this message]
[not found] ` <1b6969cffa9e4a65be0d2df114d2ef21@realtek.com>
2021-03-29 15:37 ` Mark Brown
[not found] ` <c414d49d283947878a0c5021388b8ac0@realtek.com>
2021-03-30 13:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326203407.GA3815424@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=kenny_chen@realtek.com \
--cc=kent_chen@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.