From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B4BC433C1 for ; Sun, 28 Mar 2021 12:21:46 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 599EC6196E for ; Sun, 28 Mar 2021 12:21:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 599EC6196E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E0DC54B1F5; Sun, 28 Mar 2021 08:21:44 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HwDzoLs+Ijtn; Sun, 28 Mar 2021 08:21:43 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D98B64B1EB; Sun, 28 Mar 2021 08:21:43 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3BF584B1E3 for ; Sun, 28 Mar 2021 08:21:42 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GrIQ1hHhTxcd for ; Sun, 28 Mar 2021 08:21:41 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 0629C4B1E1 for ; Sun, 28 Mar 2021 08:21:40 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 80ACF6196C; Sun, 28 Mar 2021 12:21:35 +0000 (UTC) Date: Sun, 28 Mar 2021 13:21:33 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature Message-ID: <20210328122131.GB17535@arm.com> References: <20210312151902.17853-1-steven.price@arm.com> <20210312151902.17853-3-steven.price@arm.com> <20210327152324.GA28167@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210327152324.GA28167@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Sat, Mar 27, 2021 at 03:23:24PM +0000, Catalin Marinas wrote: > On Fri, Mar 12, 2021 at 03:18:58PM +0000, Steven Price wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 77cb2d28f2a4..b31b7a821f90 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -879,6 +879,22 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > if (vma_pagesize == PAGE_SIZE && !force_pte) > > vma_pagesize = transparent_hugepage_adjust(memslot, hva, > > &pfn, &fault_ipa); > > + > > + if (fault_status != FSC_PERM && kvm_has_mte(kvm) && pfn_valid(pfn)) { > > + /* > > + * VM will be able to see the page's tags, so we must ensure > > + * they have been initialised. if PG_mte_tagged is set, tags > > + * have already been initialised. > > + */ > > + struct page *page = pfn_to_page(pfn); > > + unsigned long i, nr_pages = vma_pagesize >> PAGE_SHIFT; > > + > > + for (i = 0; i < nr_pages; i++, page++) { > > + if (!test_and_set_bit(PG_mte_tagged, &page->flags)) > > + mte_clear_page_tags(page_address(page)); > > + } > > + } > > This pfn_valid() check may be problematic. Following commit eeb0753ba27b > ("arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory"), it returns > true for ZONE_DEVICE memory but such memory is allowed not to support > MTE. Some more thinking, this should be safe as any ZONE_DEVICE would be mapped as untagged memory in the kernel linear map. It could be slightly inefficient if it unnecessarily tries to clear tags in ZONE_DEVICE, untagged memory. Another overhead is pfn_valid() which will likely end up calling memblock_is_map_memory(). However, the bigger issue is that Stage 2 cannot disable tagging for Stage 1 unless the memory is Non-cacheable or Device at S2. Is there a way to detect what gets mapped in the guest as Normal Cacheable memory and make sure it's only early memory or hotplug but no ZONE_DEVICE (or something else like on-chip memory)? If we can't guarantee that all Cacheable memory given to a guest supports tags, we should disable the feature altogether. > I now wonder if we can get a MAP_ANONYMOUS mapping of ZONE_DEVICE pfn > even without virtualisation. I haven't checked all the code paths but I don't think we can get a MAP_ANONYMOUS mapping of ZONE_DEVICE memory as we normally need a file descriptor. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA331C433C1 for ; Mon, 29 Mar 2021 21:39:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76A0A6187E for ; Mon, 29 Mar 2021 21:39:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76A0A6187E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8/9EvqOQIYrOjMsxjv5vf9gAevv3jbz1hyjgfOPv4C8=; b=nHqaTAtLvDAp4SZJKukXlCcdM M6e0EcMWW26W2GVbGA+wfWWic/Cn0RjklkNb0wFyq8w2u7W7/uCVW7UZkxJ8nr1Uta5iqf3kiZT2q Y6CYu7s7nzYhUsTZBTQtjUccJDDUC8hS/q/H5Op4r3Q3gO3AZKVF2HKNO1BSP7Bkqxe9irWWCPl0c 8BRvKFWIqxjUVMaXHTGd60MUewppsMNQ4ZUIo7OFOnoyaMSArgTclnttKerjq+2gBZHE4qhpsNYll gc9d7j11/d2FPM6etuyZGgTq1zLw7aKp8Jb4RCzigDx6uZB6d/EOPi0AJKtn24pBtOsQDGlgqyBif HcrS01kHw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQza7-001Upy-Us; Mon, 29 Mar 2021 21:37:56 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQp4N-000Zzs-R8 for linux-arm-kernel@desiato.infradead.org; Mon, 29 Mar 2021 10:24:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mh93SIzs5V77BlMR39CnUx2e9DyhZkGg2UabdQwegLE=; b=aQFV7JDGgWwmcqJ9oGJiSIXYeA tg68O9PCGNb2ZtuEmcjtPeAmLoQqPMYdxtINE53ecdUEz47TziwiTfY0AiHAaX3hR3YvWm9A/FcmL LLm/DC90NU5TPJKbAUozVY61RdJnJlMjYiylpG5bGFxh6D+PmA8TgklY45XvciqRlhgKD1DP+Fz9M aA+a7aey66U+pwP7TZygJbzyHerPFIVlgyIcEJZzCAs4eaI1cW7HRrgHVt4qfvEUAUMKXgbN2xSX2 wP1VIGdAoJXwGkxrk26jBV5XiaLP/Kt+eqKbaZNfIfGlySRpsHYsKQEXjNbXtCyyhCAikk7Zr6sfv 8B2oYZoQ==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQUQM-0003fY-Kt for linux-arm-kernel@lists.infradead.org; Sun, 28 Mar 2021 12:21:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 80ACF6196C; Sun, 28 Mar 2021 12:21:35 +0000 (UTC) Date: Sun, 28 Mar 2021 13:21:33 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature Message-ID: <20210328122131.GB17535@arm.com> References: <20210312151902.17853-1-steven.price@arm.com> <20210312151902.17853-3-steven.price@arm.com> <20210327152324.GA28167@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210327152324.GA28167@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210328_132149_338710_F847F7FE X-CRM114-Status: GOOD ( 22.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 27, 2021 at 03:23:24PM +0000, Catalin Marinas wrote: > On Fri, Mar 12, 2021 at 03:18:58PM +0000, Steven Price wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 77cb2d28f2a4..b31b7a821f90 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -879,6 +879,22 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > if (vma_pagesize == PAGE_SIZE && !force_pte) > > vma_pagesize = transparent_hugepage_adjust(memslot, hva, > > &pfn, &fault_ipa); > > + > > + if (fault_status != FSC_PERM && kvm_has_mte(kvm) && pfn_valid(pfn)) { > > + /* > > + * VM will be able to see the page's tags, so we must ensure > > + * they have been initialised. if PG_mte_tagged is set, tags > > + * have already been initialised. > > + */ > > + struct page *page = pfn_to_page(pfn); > > + unsigned long i, nr_pages = vma_pagesize >> PAGE_SHIFT; > > + > > + for (i = 0; i < nr_pages; i++, page++) { > > + if (!test_and_set_bit(PG_mte_tagged, &page->flags)) > > + mte_clear_page_tags(page_address(page)); > > + } > > + } > > This pfn_valid() check may be problematic. Following commit eeb0753ba27b > ("arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory"), it returns > true for ZONE_DEVICE memory but such memory is allowed not to support > MTE. Some more thinking, this should be safe as any ZONE_DEVICE would be mapped as untagged memory in the kernel linear map. It could be slightly inefficient if it unnecessarily tries to clear tags in ZONE_DEVICE, untagged memory. Another overhead is pfn_valid() which will likely end up calling memblock_is_map_memory(). However, the bigger issue is that Stage 2 cannot disable tagging for Stage 1 unless the memory is Non-cacheable or Device at S2. Is there a way to detect what gets mapped in the guest as Normal Cacheable memory and make sure it's only early memory or hotplug but no ZONE_DEVICE (or something else like on-chip memory)? If we can't guarantee that all Cacheable memory given to a guest supports tags, we should disable the feature altogether. > I now wonder if we can get a MAP_ANONYMOUS mapping of ZONE_DEVICE pfn > even without virtualisation. I haven't checked all the code paths but I don't think we can get a MAP_ANONYMOUS mapping of ZONE_DEVICE memory as we normally need a file descriptor. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 183EAC433DB for ; Sun, 28 Mar 2021 12:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5510617ED for ; Sun, 28 Mar 2021 12:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231126AbhC1MVo (ORCPT ); Sun, 28 Mar 2021 08:21:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:46310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhC1MVi (ORCPT ); Sun, 28 Mar 2021 08:21:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 80ACF6196C; Sun, 28 Mar 2021 12:21:35 +0000 (UTC) Date: Sun, 28 Mar 2021 13:21:33 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature Message-ID: <20210328122131.GB17535@arm.com> References: <20210312151902.17853-1-steven.price@arm.com> <20210312151902.17853-3-steven.price@arm.com> <20210327152324.GA28167@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210327152324.GA28167@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 27, 2021 at 03:23:24PM +0000, Catalin Marinas wrote: > On Fri, Mar 12, 2021 at 03:18:58PM +0000, Steven Price wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 77cb2d28f2a4..b31b7a821f90 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -879,6 +879,22 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > if (vma_pagesize == PAGE_SIZE && !force_pte) > > vma_pagesize = transparent_hugepage_adjust(memslot, hva, > > &pfn, &fault_ipa); > > + > > + if (fault_status != FSC_PERM && kvm_has_mte(kvm) && pfn_valid(pfn)) { > > + /* > > + * VM will be able to see the page's tags, so we must ensure > > + * they have been initialised. if PG_mte_tagged is set, tags > > + * have already been initialised. > > + */ > > + struct page *page = pfn_to_page(pfn); > > + unsigned long i, nr_pages = vma_pagesize >> PAGE_SHIFT; > > + > > + for (i = 0; i < nr_pages; i++, page++) { > > + if (!test_and_set_bit(PG_mte_tagged, &page->flags)) > > + mte_clear_page_tags(page_address(page)); > > + } > > + } > > This pfn_valid() check may be problematic. Following commit eeb0753ba27b > ("arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory"), it returns > true for ZONE_DEVICE memory but such memory is allowed not to support > MTE. Some more thinking, this should be safe as any ZONE_DEVICE would be mapped as untagged memory in the kernel linear map. It could be slightly inefficient if it unnecessarily tries to clear tags in ZONE_DEVICE, untagged memory. Another overhead is pfn_valid() which will likely end up calling memblock_is_map_memory(). However, the bigger issue is that Stage 2 cannot disable tagging for Stage 1 unless the memory is Non-cacheable or Device at S2. Is there a way to detect what gets mapped in the guest as Normal Cacheable memory and make sure it's only early memory or hotplug but no ZONE_DEVICE (or something else like on-chip memory)? If we can't guarantee that all Cacheable memory given to a guest supports tags, we should disable the feature altogether. > I now wonder if we can get a MAP_ANONYMOUS mapping of ZONE_DEVICE pfn > even without virtualisation. I haven't checked all the code paths but I don't think we can get a MAP_ANONYMOUS mapping of ZONE_DEVICE memory as we normally need a file descriptor. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A98C433C1 for ; Sun, 28 Mar 2021 12:22:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D724861954 for ; Sun, 28 Mar 2021 12:22:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D724861954 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQUQw-0002eW-PX for qemu-devel@archiver.kernel.org; Sun, 28 Mar 2021 08:22:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQUQN-0002Eh-9N for qemu-devel@nongnu.org; Sun, 28 Mar 2021 08:21:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:58078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQUQI-0007hH-QX for qemu-devel@nongnu.org; Sun, 28 Mar 2021 08:21:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 80ACF6196C; Sun, 28 Mar 2021 12:21:35 +0000 (UTC) Date: Sun, 28 Mar 2021 13:21:33 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature Message-ID: <20210328122131.GB17535@arm.com> References: <20210312151902.17853-1-steven.price@arm.com> <20210312151902.17853-3-steven.price@arm.com> <20210327152324.GA28167@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210327152324.GA28167@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=198.145.29.99; envelope-from=cmarinas@kernel.org; helo=mail.kernel.org X-Spam_score_int: -66 X-Spam_score: -6.7 X-Spam_bar: ------ X-Spam_report: (-6.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Haibo Xu , Suzuki K Poulose , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Mar 27, 2021 at 03:23:24PM +0000, Catalin Marinas wrote: > On Fri, Mar 12, 2021 at 03:18:58PM +0000, Steven Price wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 77cb2d28f2a4..b31b7a821f90 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -879,6 +879,22 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > if (vma_pagesize == PAGE_SIZE && !force_pte) > > vma_pagesize = transparent_hugepage_adjust(memslot, hva, > > &pfn, &fault_ipa); > > + > > + if (fault_status != FSC_PERM && kvm_has_mte(kvm) && pfn_valid(pfn)) { > > + /* > > + * VM will be able to see the page's tags, so we must ensure > > + * they have been initialised. if PG_mte_tagged is set, tags > > + * have already been initialised. > > + */ > > + struct page *page = pfn_to_page(pfn); > > + unsigned long i, nr_pages = vma_pagesize >> PAGE_SHIFT; > > + > > + for (i = 0; i < nr_pages; i++, page++) { > > + if (!test_and_set_bit(PG_mte_tagged, &page->flags)) > > + mte_clear_page_tags(page_address(page)); > > + } > > + } > > This pfn_valid() check may be problematic. Following commit eeb0753ba27b > ("arm64/mm: Fix pfn_valid() for ZONE_DEVICE based memory"), it returns > true for ZONE_DEVICE memory but such memory is allowed not to support > MTE. Some more thinking, this should be safe as any ZONE_DEVICE would be mapped as untagged memory in the kernel linear map. It could be slightly inefficient if it unnecessarily tries to clear tags in ZONE_DEVICE, untagged memory. Another overhead is pfn_valid() which will likely end up calling memblock_is_map_memory(). However, the bigger issue is that Stage 2 cannot disable tagging for Stage 1 unless the memory is Non-cacheable or Device at S2. Is there a way to detect what gets mapped in the guest as Normal Cacheable memory and make sure it's only early memory or hotplug but no ZONE_DEVICE (or something else like on-chip memory)? If we can't guarantee that all Cacheable memory given to a guest supports tags, we should disable the feature altogether. > I now wonder if we can get a MAP_ANONYMOUS mapping of ZONE_DEVICE pfn > even without virtualisation. I haven't checked all the code paths but I don't think we can get a MAP_ANONYMOUS mapping of ZONE_DEVICE memory as we normally need a file descriptor. -- Catalin