From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1432C433DB for ; Mon, 29 Mar 2021 21:40:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B26E6187E for ; Mon, 29 Mar 2021 21:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B26E6187E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zhiy2EDC/yx+oTeVYqyM4/zqVFzDtAxddIfP4YtqcDc=; b=b7+tWBdmSQo0gk7V0wB281Kyk e7E/IDmbqRD0FDZnxqIqsCVvILPUe252RSoY+OFPirUvKfFxV+XJmzyeZXneWVtqS/2jgDVyItsGi oYr6+ouITaAgpCY/F9GUcPKeGJBXyMR6yxwS4nziZFjy8JRx6sdLRMk6IIYmFiiEuzWl5Fh/WzEYh WcC3SBqQHRpMP6yRcQtI7QdAOKJ8lBn2wH+UgDgDM6NNX1YdMPx80CKwOqCQfnS6IKSWDo1W9w2u5 0YouwS1oh8Uq02ktFbZP0k3W9bSI6N98Mmd1BvUHn9H2hlx1Po3hpK+NMjjdF/WwrT4UAd4QDx7mK pqZzy/aRw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQzaz-001VBk-G5; Mon, 29 Mar 2021 21:38:49 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQp5O-000a1n-Qn for linux-arm-kernel@desiato.infradead.org; Mon, 29 Mar 2021 10:25:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=XBAaJYxZnPe/Tvu+Mzh/YIyCmpZvsgfyT1JLXBpsiV0=; b=ofFfKxZr5LAQs4H+d/vTdJOpNW Xkx8xH+mcErpajE+H8J+TUXtaShJwZaFSKXjlKc64R3CY2Hg5HmJUuAZT7CXZ8lEyHvmscIWlanVa ABfCu3XEGfd+nNbG1YfqdKcJotHA8wf4irNuSf2LhsNAETWZG6VJTahnCjtNzKasi8OBPY4QOQAC0 uTemYDJ3pPhROkYTpjzWyIB3VzawJ+m/yxpylf50TLPy9BaWZaLTFf7+Vk9zf/SPDVC5dXchz60d8 aY28UmS03wrmDQGg7MXCMvb5gcTjp3G4PIPFk7NzU5jRsPjbaMiyrxgJWPq5ZM6w1xD7hJlDWsbh+ xibKvT+Q==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQZ6r-000KAr-Of for linux-arm-kernel@lists.infradead.org; Sun, 28 Mar 2021 17:22:01 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 29DA16197E; Sun, 28 Mar 2021 17:21:51 +0000 (UTC) Date: Sun, 28 Mar 2021 18:21:48 +0100 From: Catalin Marinas To: Chen Lifu Cc: will@kernel.org, valentin.schneider@arm.com, maz@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, heying24@huawei.com, yuehaibing@huawei.com, weiyongjun1@huawei.com, johnny.chenyi@huawei.com Subject: Re: [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions Message-ID: <20210328172147.GA19252@arm.com> References: <20210327070651.70773-1-chenlifu@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210327070651.70773-1-chenlifu@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210328_182158_594175_3A867C28 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBNYXIgMjcsIDIwMjEgYXQgMDM6MDY6NTFQTSArMDgwMCwgQ2hlbiBMaWZ1IHdyb3Rl Ogo+IEluIGNvbW1pdCBlYjYzMWJiNWJmNWIKPiAoImFybTY0OiBTdXBwb3J0IGFyY2hfaXJxX3dv cmtfcmFpc2UoKSB2aWEgc2VsZiBJUElzIikgYSBuZXcKPiBmdW5jdGlvbiAiYXJjaF9pcnFfd29y a19yYWlzZSIgd2FzIGFkZGVkIHdpdGhvdXQgYSBwcm90b3R5cGUKPiBpbiBoZWFkZXIgaXJxX3dv cmsuaAo+IAo+IEluIGNvbW1pdCBkOTE0ZDRkNDk3NDUKPiAoImFybTY0OiBJbXBsZW1lbnQgcGFu aWNfc21wX3NlbGZfc3RvcCgpIikgYSBuZXcKPiBmdW5jdGlvbiAicGFuaWNfc21wX3NlbGZfc3Rv cCIgd2FzIGFkZGVkIHdpdGhvdXQgYSBwcm90b3R5cGUKPiBpbiBoZWFkZXIgaXJxX3dvcmsuaAo+ IAo+IFdlIGdldCB0aGUgZm9sbG93aW5nIHdhcm5pbmdzIG9uIFc9MToKPiBhcmNoL2FybTY0L2tl cm5lbC9zbXAuYzo4NDI6Njogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlCj4gZm9yIOKA mGFyY2hfaXJxX3dvcmtfcmFpc2XigJkgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+IGFyY2gvYXJt NjQva2VybmVsL3NtcC5jOjg2Mjo2OiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUKPiBm b3Ig4oCYcGFuaWNfc21wX3NlbGZfc3RvcOKAmSBbLVdtaXNzaW5nLXByb3RvdHlwZXNdCj4gCj4g Rml4IHRoZSBzYW1lIGJ5IGFkZGluZyB0aGUgbWlzc2luZyBwcm90b3R5cGUgaW4gaGVhZGVyIGly cV93b3JrLmgKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaGVuIExpZnUgPGNoZW5saWZ1QGh1YXdlaS5j b20+Cj4gLS0tCj4gIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vaXJxX3dvcmsuaCB8IDMgKysrCj4g IDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9h cm02NC9pbmNsdWRlL2FzbS9pcnFfd29yay5oIGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9pcnFf d29yay5oCj4gaW5kZXggYTEwMjAyODVlYTc1Li5mNzY2ZTIxOTBlN2MgMTAwNjQ0Cj4gLS0tIGEv YXJjaC9hcm02NC9pbmNsdWRlL2FzbS9pcnFfd29yay5oCj4gKysrIGIvYXJjaC9hcm02NC9pbmNs dWRlL2FzbS9pcnFfd29yay5oCj4gQEAgLTIsNiArMiw5IEBACj4gICNpZm5kZWYgX19BU01fSVJR X1dPUktfSAo+ICAjZGVmaW5lIF9fQVNNX0lSUV9XT1JLX0gKPiAgCj4gK2V4dGVybiB2b2lkIGFy Y2hfaXJxX3dvcmtfcmFpc2Uodm9pZCk7Cj4gK2V4dGVybiB2b2lkIHBhbmljX3NtcF9zZWxmX3N0 b3Aodm9pZCk7CgpUaGUgc2Vjb25kIHByb3RvdHlwZSBtYWtlcyBtb3JlIHNlbnNlIGluIGFyY2gv YXJtNjQvaW5jbHVkZS9hc20vc21wLmgKd2hlcmUgd2UgYWxyZWFkeSBoYXZlIGNyYXNoX3NtcF9z ZW5kX3N0b3AoKS4KCi0tIApDYXRhbGluCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45042C433DB for ; Sun, 28 Mar 2021 17:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BB606197F for ; Sun, 28 Mar 2021 17:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbhC1RWC (ORCPT ); Sun, 28 Mar 2021 13:22:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:58486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbhC1RVx (ORCPT ); Sun, 28 Mar 2021 13:21:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 29DA16197E; Sun, 28 Mar 2021 17:21:51 +0000 (UTC) Date: Sun, 28 Mar 2021 18:21:48 +0100 From: Catalin Marinas To: Chen Lifu Cc: will@kernel.org, valentin.schneider@arm.com, maz@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, heying24@huawei.com, yuehaibing@huawei.com, weiyongjun1@huawei.com, johnny.chenyi@huawei.com Subject: Re: [PATCH -next] arm64: smp: Add missing prototype for some smp.c functions Message-ID: <20210328172147.GA19252@arm.com> References: <20210327070651.70773-1-chenlifu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210327070651.70773-1-chenlifu@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 27, 2021 at 03:06:51PM +0800, Chen Lifu wrote: > In commit eb631bb5bf5b > ("arm64: Support arch_irq_work_raise() via self IPIs") a new > function "arch_irq_work_raise" was added without a prototype > in header irq_work.h > > In commit d914d4d49745 > ("arm64: Implement panic_smp_self_stop()") a new > function "panic_smp_self_stop" was added without a prototype > in header irq_work.h > > We get the following warnings on W=1: > arch/arm64/kernel/smp.c:842:6: warning: no previous prototype > for ‘arch_irq_work_raise’ [-Wmissing-prototypes] > arch/arm64/kernel/smp.c:862:6: warning: no previous prototype > for ‘panic_smp_self_stop’ [-Wmissing-prototypes] > > Fix the same by adding the missing prototype in header irq_work.h > > Signed-off-by: Chen Lifu > --- > arch/arm64/include/asm/irq_work.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/include/asm/irq_work.h b/arch/arm64/include/asm/irq_work.h > index a1020285ea75..f766e2190e7c 100644 > --- a/arch/arm64/include/asm/irq_work.h > +++ b/arch/arm64/include/asm/irq_work.h > @@ -2,6 +2,9 @@ > #ifndef __ASM_IRQ_WORK_H > #define __ASM_IRQ_WORK_H > > +extern void arch_irq_work_raise(void); > +extern void panic_smp_self_stop(void); The second prototype makes more sense in arch/arm64/include/asm/smp.h where we already have crash_smp_send_stop(). -- Catalin