All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/libqmi: needs headers >= 4.14
Date: Mon, 29 Mar 2021 23:19:57 +0200	[thread overview]
Message-ID: <20210329211957.321612-2-fontaine.fabrice@gmail.com> (raw)
In-Reply-To: <20210329211957.321612-1-fontaine.fabrice@gmail.com>

libqmi unconditionnally uses ARPHRD_RAWIP since version 1.28.0 and
https://github.com/freedesktop/libqmi/commit/4085a2d6b771a40fb637433ed6a05b9d5d4d94b9
https://github.com/freedesktop/libqmi/commit/19f4b39ee85500e7e868b8a100fba19c04fb3c30

However, ARPHRD_RAWIP is only available since kernel 4.14 and
https://github.com/torvalds/linux/commit/cdf4969c42a6c1a376dd03a9e846cf638d3cd4b1

Fixes:
 - http://autobuild.buildroot.org/results/c8853b7161bd85d46c1282c6c097e7ef4042ae68

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libqmi/Config.in        | 6 ++++--
 package/modem-manager/Config.in | 5 +++++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/package/libqmi/Config.in b/package/libqmi/Config.in
index f1d111b7c9..53400acb0a 100644
--- a/package/libqmi/Config.in
+++ b/package/libqmi/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBQMI
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_USE_MMU # libglib2
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14
 	select BR2_PACKAGE_LIBGLIB2
 	help
 	  libqmi is a glib-based library for talking to WWAN modems and
@@ -10,6 +11,7 @@ config BR2_PACKAGE_LIBQMI
 
 	  http://www.freedesktop.org/wiki/Software/libqmi/
 
-comment "libqmi needs a toolchain w/ wchar, threads"
+comment "libqmi needs a toolchain w/ wchar, threads, headers >= 4.14"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14
diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
index c4c723776d..688fcc4c3b 100644
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -22,9 +22,14 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBMBIM
 
 config BR2_PACKAGE_MODEM_MANAGER_LIBQMI
 	bool "QMI support"
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14
 	select BR2_PACKAGE_LIBQMI
 	help
 	  This option enables support for QMI protocol
+
+comment "QMI support needs a toolchain w/ headers >= 4.14"
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14
+
 endif
 
 comment "modemmanager needs a toolchain w/ wchar, threads"
-- 
2.30.2

  reply	other threads:[~2021-03-29 21:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 21:19 [Buildroot] [PATCH 1/2] package/libqmi: drop unrecognized option Fabrice Fontaine
2021-03-29 21:19 ` Fabrice Fontaine [this message]
2021-03-29 21:40   ` [Buildroot] [PATCH 2/2] package/libqmi: needs headers >= 4.14 Aleksander Morgado
2021-03-29 21:44     ` Fabrice Fontaine
2021-03-29 22:13       ` Aleksander Morgado
2021-03-29 21:46 ` [Buildroot] [PATCH 1/2] package/libqmi: drop unrecognized option Aleksander Morgado
2021-03-30 19:37   ` Yann E. MORIN
2021-03-30 19:51     ` Aleksander Morgado
2021-04-03 10:33 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210329211957.321612-2-fontaine.fabrice@gmail.com \
    --to=fontaine.fabrice@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.