Re: [PATCH v2 5/5] tracing: Add "func_no_repeats" option for function tracing

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2872 bytes --]

Hi "Yordan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on linux/master trace/for-next linus/master v5.12-rc5 next-20210329]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yordan-Karadzhov-VMware/Add-func_no_repete-tracing-option/20210329-211207
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 08ef1af4de5fe7de9c6d69f1e22e51b66e385d9b
config: mips-randconfig-r001-20210329 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 482283042f795ecc27838a3b2f76b5494991401c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/1aad52db914f80d753799262fa90fc0ccf79320d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yordan-Karadzhov-VMware/Add-func_no_repete-tracing-option/20210329-211207
        git checkout 1aad52db914f80d753799262fa90fc0ccf79320d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> kernel/trace/trace_functions.c:243:50: error: too few arguments to function call, expected 2, have 1
                           ring_buffer_time_stamp(tr->array_buffer.buffer);
                           ~~~~~~~~~~~~~~~~~~~~~~                        ^
   include/linux/ring_buffer.h:183:5: note: 'ring_buffer_time_stamp' declared here
   u64 ring_buffer_time_stamp(struct trace_buffer *buffer, int cpu);
       ^
   1 error generated.


vim +243 kernel/trace/trace_functions.c

   234	
   235	static inline bool is_repeat_check(struct trace_array *tr,
   236					   struct trace_func_repeats *last_info,
   237					   unsigned long ip, unsigned long parent_ip)
   238	{
   239		if (last_info->ip == ip &&
   240		    last_info->parent_ip == parent_ip &&
   241		    last_info->count < U16_MAX) {
   242			last_info->ts_last_call =
 > 243				ring_buffer_time_stamp(tr->array_buffer.buffer);
   244			last_info->count++;
   245			return true;
   246		}
   247	
   248		return false;
   249	}
   250	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33979 bytes --]