From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [linux-next:master 3841/8469] drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)
Date: Tue, 30 Mar 2021 13:05:02 +0800 [thread overview]
Message-ID: <202103301359.60vgPN2l-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4067 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: "Noralf Trønnes" <noralf@tronnes.org>
CC: Peter Stuge <peter@stuge.se>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 9d49ed9ca93b8c564033c1d6808017bc9052b5db
commit: 40e1a70b4aedf2859a1829991b48ef0ebe650bf2 [3841/8469] drm: Add GUD USB Display driver
:::::: branch date: 19 hours ago
:::::: commit date: 2 weeks ago
config: openrisc-randconfig-m031-20210330 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536)
vim +/fb +544 drivers/gpu/drm/gud/gud_pipe.c
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 507
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 508 void gud_pipe_update(struct drm_simple_display_pipe *pipe,
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 509 struct drm_plane_state *old_state)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 510 {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 511 struct drm_device *drm = pipe->crtc.dev;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 512 struct gud_device *gdrm = to_gud_device(drm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 513 struct drm_plane_state *state = pipe->plane.state;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 514 struct drm_framebuffer *fb = state->fb;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 515 struct drm_crtc *crtc = &pipe->crtc;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 516 struct drm_rect damage;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 517 int idx;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 518
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 519 if (crtc->state->mode_changed || !crtc->state->enable) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 520 cancel_work_sync(&gdrm->work);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 521 mutex_lock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 522 if (gdrm->fb) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 523 drm_framebuffer_put(gdrm->fb);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 524 gdrm->fb = NULL;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 525 }
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 526 gud_clear_damage(gdrm);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 527 mutex_unlock(&gdrm->damage_lock);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 528 }
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 529
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 530 if (!drm_dev_enter(drm, &idx))
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 531 return;
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 532
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 533 if (!old_state->fb)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 534 gud_usb_set_u8(gdrm, GUD_REQ_SET_CONTROLLER_ENABLE, 1);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 535
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @536 if (fb && (crtc->state->mode_changed || crtc->state->connectors_changed))
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 537 gud_usb_set(gdrm, GUD_REQ_SET_STATE_COMMIT, 0, NULL, 0);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 538
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 539 if (crtc->state->active_changed)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 540 gud_usb_set_u8(gdrm, GUD_REQ_SET_DISPLAY_ENABLE, crtc->state->active);
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 541
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 542 if (drm_atomic_helper_damage_merged(old_state, state, &damage)) {
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 543 if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE)
40e1a70b4aedf2 Noralf Trønnes 2021-03-13 @544 drm_rect_init(&damage, 0, 0, fb->width, fb->height);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 25387 bytes --]
next reply other threads:[~2021-03-30 5:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 5:05 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-30 10:08 [linux-next:master 3841/8469] drivers/gpu/drm/gud/gud_pipe.c:544 gud_pipe_update() error: we previously assumed 'fb' could be null (see line 536) Dan Carpenter
2021-03-30 10:08 ` Dan Carpenter
2021-03-30 11:49 ` Noralf Trønnes
2021-03-30 13:20 ` Dan Carpenter
2021-03-30 13:20 ` Dan Carpenter
2021-03-31 0:25 ` Rong Chen
2021-03-31 4:15 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103301359.60vgPN2l-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.